All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ralf Schlatterbeck <rsc@runtux.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Miguel Ojeda <ojeda@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Robin van der Gracht <robin@protonic.nl>,
	Paul Burton <paulburton@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: auxdisplay: hit, hd44780: drop redundant GPIO node
Date: Tue, 13 Feb 2024 10:19:05 -0600	[thread overview]
Message-ID: <20240213161905.GA1459669-robh@kernel.org> (raw)
In-Reply-To: <d603a588-d312-486e-b6c9-647a6b90580c@linaro.org>

On Mon, Feb 12, 2024 at 02:59:02PM +0100, Krzysztof Kozlowski wrote:
> On 12/02/2024 14:43, Andy Shevchenko wrote:
> > On Mon, Feb 12, 2024 at 02:38:27PM +0100, Krzysztof Kozlowski wrote:
> >> On 12/02/2024 12:58, Ralf Schlatterbeck wrote:
> > 
> > ...
> > 
> >> Anyway, binding examples should not be collection of unrelated
> >> solutions, because then we should accept for each device schema several
> >> other variations and combinations.
> > 
> > Is this documented?
> 
> Yes, writing schema says what the example is. We repeated it multiple
> times on multiple reviews, we made multiple commits multiple times and I
> briefly mentioned it also in my talks.

While yes, this is the guidance, I think this case has provided enough 
justification to keep it. Let's move on please.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ralf Schlatterbeck <rsc@runtux.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Miguel Ojeda <ojeda@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Robin van der Gracht <robin@protonic.nl>,
	Paul Burton <paulburton@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: auxdisplay: hit, hd44780: drop redundant GPIO node
Date: Tue, 13 Feb 2024 10:19:05 -0600	[thread overview]
Message-ID: <20240213161905.GA1459669-robh@kernel.org> (raw)
In-Reply-To: <d603a588-d312-486e-b6c9-647a6b90580c@linaro.org>

On Mon, Feb 12, 2024 at 02:59:02PM +0100, Krzysztof Kozlowski wrote:
> On 12/02/2024 14:43, Andy Shevchenko wrote:
> > On Mon, Feb 12, 2024 at 02:38:27PM +0100, Krzysztof Kozlowski wrote:
> >> On 12/02/2024 12:58, Ralf Schlatterbeck wrote:
> > 
> > ...
> > 
> >> Anyway, binding examples should not be collection of unrelated
> >> solutions, because then we should accept for each device schema several
> >> other variations and combinations.
> > 
> > Is this documented?
> 
> Yes, writing schema says what the example is. We repeated it multiple
> times on multiple reviews, we made multiple commits multiple times and I
> briefly mentioned it also in my talks.

While yes, this is the guidance, I think this case has provided enough 
justification to keep it. Let's move on please.

Rob

  parent reply	other threads:[~2024-02-13 16:19 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12  8:34 [PATCH 1/3] dt-bindings: auxdisplay: hit,hd44780: drop redundant GPIO node Krzysztof Kozlowski
2024-02-12  8:34 ` Krzysztof Kozlowski
2024-02-12  8:34 ` [PATCH 2/3] dt-bindings: auxdisplay: adjust example indentation and use generic node names Krzysztof Kozlowski
2024-02-12  8:34   ` Krzysztof Kozlowski
2024-02-12 12:14   ` Andy Shevchenko
2024-02-12 12:14     ` Andy Shevchenko
2024-02-12  8:34 ` [PATCH 3/3] dt-bindings: auxdisplay: hit,hd44780: use defines for GPIO flags Krzysztof Kozlowski
2024-02-12  8:34   ` Krzysztof Kozlowski
2024-02-12 12:15   ` Andy Shevchenko
2024-02-12 12:15     ` Andy Shevchenko
2024-02-12  8:41 ` [PATCH 1/3] dt-bindings: auxdisplay: hit,hd44780: drop redundant GPIO node Geert Uytterhoeven
2024-02-12  8:41   ` Geert Uytterhoeven
2024-02-12 11:25   ` Krzysztof Kozlowski
2024-02-12 11:25     ` Krzysztof Kozlowski
2024-02-12 11:58     ` [PATCH 1/3] dt-bindings: auxdisplay: hit, hd44780: " Ralf Schlatterbeck
2024-02-12 11:58       ` Ralf Schlatterbeck
2024-02-12 13:38       ` Krzysztof Kozlowski
2024-02-12 13:38         ` Krzysztof Kozlowski
2024-02-12 13:43         ` Andy Shevchenko
2024-02-12 13:43           ` Andy Shevchenko
2024-02-12 13:59           ` Krzysztof Kozlowski
2024-02-12 13:59             ` Krzysztof Kozlowski
2024-02-12 14:04             ` Andy Shevchenko
2024-02-12 14:04               ` Andy Shevchenko
2024-02-13 16:19             ` Rob Herring [this message]
2024-02-13 16:19               ` Rob Herring
2024-02-13 16:43               ` Andy Shevchenko
2024-02-13 16:43                 ` Andy Shevchenko
2024-02-14  9:57                 ` Krzysztof Kozlowski
2024-02-14  9:57                   ` Krzysztof Kozlowski
2024-02-12 14:39         ` Ralf Schlatterbeck
2024-02-12 14:39           ` Ralf Schlatterbeck
2024-02-12 15:24           ` Geert Uytterhoeven
2024-02-12 15:24             ` Geert Uytterhoeven
2024-02-13  9:07         ` Ralf Schlatterbeck
2024-02-13  9:07           ` Ralf Schlatterbeck
2024-02-12 13:39 ` [PATCH 1/3] dt-bindings: auxdisplay: hit,hd44780: " Andy Shevchenko
2024-02-12 13:39   ` Andy Shevchenko
2024-02-12 13:56   ` Krzysztof Kozlowski
2024-02-12 13:56     ` Krzysztof Kozlowski
2024-02-12 14:09     ` Andy Shevchenko
2024-02-12 14:09       ` Andy Shevchenko
2024-02-12 14:20       ` Krzysztof Kozlowski
2024-02-12 14:20         ` Krzysztof Kozlowski
2024-02-12 14:31         ` Andy Shevchenko
2024-02-12 14:31           ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240213161905.GA1459669-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=paulburton@kernel.org \
    --cc=robin@protonic.nl \
    --cc=rsc@runtux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.