From: Jakub Kicinski <kuba@kernel.org>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Kory Maincent <kory.maincent@bootlin.com>,
Ariel Elior <aelior@marvell.com>,
Manish Chopra <manishc@marvell.com>,
netdev@vger.kernel.org,
Richard Cochran <richardcochran@gmail.com>,
Maxim Georgiev <glipus@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Emeel Hakim <ehakim@nvidia.com>,
Eric Dumazet <edumazet@google.com>,
intel-wired-lan@lists.osuosl.org,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Subbaraya Sundeep <sbhatta@marvell.com>,
Raju Rangoju <rajur@chelsio.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Paolo Abeni <pabeni@redhat.com>,
Sudarsana Kalluru <skalluru@marvell.com>
Subject: Re: [Intel-wired-lan] [PATCH RFC net-next v1] net: rework FCOE and RFS ops
Date: Tue, 13 Feb 2024 18:13:50 -0800 [thread overview]
Message-ID: <20240213181350.1755f669@kernel.org> (raw)
In-Reply-To: <20240210021000.2011419-1-jesse.brandeburg@intel.com>
On Fri, 9 Feb 2024 18:09:57 -0800 Jesse Brandeburg wrote:
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> @@ -10416,14 +10416,11 @@ static const struct net_device_ops ixgbe_netdev_ops = {
> .ndo_setup_tc = __ixgbe_setup_tc,
> #ifdef IXGBE_FCOE
> .ndo_select_queue = ixgbe_select_queue,
> - .ndo_fcoe_ddp_setup = ixgbe_fcoe_ddp_get,
> - .ndo_fcoe_ddp_target = ixgbe_fcoe_ddp_target,
> - .ndo_fcoe_ddp_done = ixgbe_fcoe_ddp_put,
> - .ndo_fcoe_enable = ixgbe_fcoe_enable,
> - .ndo_fcoe_disable = ixgbe_fcoe_disable,
> - .ndo_fcoe_get_wwn = ixgbe_fcoe_get_wwn,
> - .ndo_fcoe_get_hbainfo = ixgbe_fcoe_get_hbainfo,
> #endif /* IXGBE_FCOE */
> + SET_FCOE_OPS(ixgbe_fcoe_enable, ixgbe_fcoe_disable,
> + ixgbe_fcoe_ddp_target, ixgbe_fcoe_ddp_get,
> + ixgbe_fcoe_ddp_put, ixgbe_fcoe_get_hbainfo)
> + SET_FCOE_GET_WWN_OPS(ixgbe_fcoe_get_wwn)
> .ndo_set_features = ixgbe_set_features,
> .ndo_fix_features = ixgbe_fix_features,
> .ndo_fdb_add = ixgbe_ndo_fdb_add,
If we'd be having a vote - I personally find the #ifdef far more
readable.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Ariel Elior <aelior@marvell.com>,
Sudarsana Kalluru <skalluru@marvell.com>,
Manish Chopra <manishc@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Raju Rangoju <rajur@chelsio.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Jay Vosburgh <jay.vosburgh@canonical.com>,
Kory Maincent <kory.maincent@bootlin.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
Richard Cochran <richardcochran@gmail.com>,
Maxim Georgiev <glipus@gmail.com>,
Emeel Hakim <ehakim@nvidia.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>
Subject: Re: [PATCH RFC net-next v1] net: rework FCOE and RFS ops
Date: Tue, 13 Feb 2024 18:13:50 -0800 [thread overview]
Message-ID: <20240213181350.1755f669@kernel.org> (raw)
In-Reply-To: <20240210021000.2011419-1-jesse.brandeburg@intel.com>
On Fri, 9 Feb 2024 18:09:57 -0800 Jesse Brandeburg wrote:
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> @@ -10416,14 +10416,11 @@ static const struct net_device_ops ixgbe_netdev_ops = {
> .ndo_setup_tc = __ixgbe_setup_tc,
> #ifdef IXGBE_FCOE
> .ndo_select_queue = ixgbe_select_queue,
> - .ndo_fcoe_ddp_setup = ixgbe_fcoe_ddp_get,
> - .ndo_fcoe_ddp_target = ixgbe_fcoe_ddp_target,
> - .ndo_fcoe_ddp_done = ixgbe_fcoe_ddp_put,
> - .ndo_fcoe_enable = ixgbe_fcoe_enable,
> - .ndo_fcoe_disable = ixgbe_fcoe_disable,
> - .ndo_fcoe_get_wwn = ixgbe_fcoe_get_wwn,
> - .ndo_fcoe_get_hbainfo = ixgbe_fcoe_get_hbainfo,
> #endif /* IXGBE_FCOE */
> + SET_FCOE_OPS(ixgbe_fcoe_enable, ixgbe_fcoe_disable,
> + ixgbe_fcoe_ddp_target, ixgbe_fcoe_ddp_get,
> + ixgbe_fcoe_ddp_put, ixgbe_fcoe_get_hbainfo)
> + SET_FCOE_GET_WWN_OPS(ixgbe_fcoe_get_wwn)
> .ndo_set_features = ixgbe_set_features,
> .ndo_fix_features = ixgbe_fix_features,
> .ndo_fdb_add = ixgbe_ndo_fdb_add,
If we'd be having a vote - I personally find the #ifdef far more
readable.
next prev parent reply other threads:[~2024-02-14 2:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-10 2:09 [Intel-wired-lan] [PATCH RFC net-next v1] net: rework FCOE and RFS ops Jesse Brandeburg
2024-02-10 2:09 ` Jesse Brandeburg
2024-02-14 2:13 ` Jakub Kicinski [this message]
2024-02-14 2:13 ` Jakub Kicinski
2024-02-16 19:11 ` [Intel-wired-lan] " Jesse Brandeburg
2024-02-16 19:11 ` Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240213181350.1755f669@kernel.org \
--to=kuba@kernel.org \
--cc=aelior@marvell.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ehakim@nvidia.com \
--cc=glipus@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kory.maincent@bootlin.com \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rajur@chelsio.com \
--cc=richardcochran@gmail.com \
--cc=sbhatta@marvell.com \
--cc=skalluru@marvell.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.