[PATCH] usb: ehci-mx6: Add i.MX93 support

[PATCH] usb: ehci-mx6: Add i.MX93 support

[Mathieu Othacehe]

i.MX93 uses the same USB IP as i.MX8MM. It can then reuse the ehci-mx6
driver.

Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
---
 drivers/usb/host/Kconfig    | 6 +++---
 drivers/usb/host/ehci-mx6.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 0dd5736433c..f96027d7bd2 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -210,10 +210,10 @@ config USB_EHCI_MX6
 
 config USB_EHCI_MX7
 	bool "Support for i.MX7 on-chip EHCI USB controller"
-	depends on ARCH_MX7 || IMX8M
+	depends on ARCH_MX7 || IMX8M || IMX93
 	select EHCI_HCD_INIT_AFTER_RESET if ARCH_MX7
-	select PHY if IMX8M
-	select NOP_PHY if IMX8M
+	select PHY if IMX8M || IMX93
+	select NOP_PHY if IMX8M || IMX93
 	default y
 	---help---
 	  Enables support for the on-chip EHCI controller on i.MX7 SoCs.
diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c
index a9ed5e7a0d5..a35fcca43a2 100644
--- a/drivers/usb/host/ehci-mx6.c
+++ b/drivers/usb/host/ehci-mx6.c
@@ -538,7 +538,7 @@ static int ehci_usb_phy_mode(struct udevice *dev)
 			plat->init_type = USB_INIT_DEVICE;
 		else
 			plat->init_type = USB_INIT_HOST;
-	} else if (is_mx7() || is_imx8mm() || is_imx8mn()) {
+	} else if (is_mx7() || is_imx8mm() || is_imx8mn() || is_imx93()) {
 		phy_status = (void __iomem *)(addr +
 					      USBNC_PHY_STATUS_OFFSET);
 		val = readl(phy_status);
-- 
2.41.0

Re: [PATCH] usb: ehci-mx6: Add i.MX93 support

[Fabio Estevam]

Hi Mathieu,

On Mon, Feb 19, 2024 at 5:43 AM Mathieu Othacehe <othacehe@gnu.org> wrote:
>
> i.MX93 uses the same USB IP as i.MX8MM. It can then reuse the ehci-mx6
> driver.
>
> Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>

You missed copying Marek Vasut, who is the USB maintainer.

> ---
>  drivers/usb/host/Kconfig    | 6 +++---
>  drivers/usb/host/ehci-mx6.c | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 0dd5736433c..f96027d7bd2 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -210,10 +210,10 @@ config USB_EHCI_MX6
>
>  config USB_EHCI_MX7
>         bool "Support for i.MX7 on-chip EHCI USB controller"
> -       depends on ARCH_MX7 || IMX8M
> +       depends on ARCH_MX7 || IMX8M || IMX93
>         select EHCI_HCD_INIT_AFTER_RESET if ARCH_MX7
> -       select PHY if IMX8M
> -       select NOP_PHY if IMX8M
> +       select PHY if IMX8M || IMX93
> +       select NOP_PHY if IMX8M || IMX93
>         default y
>         ---help---
>           Enables support for the on-chip EHCI controller on i.MX7 SoCs.
> diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c
> index a9ed5e7a0d5..a35fcca43a2 100644
> --- a/drivers/usb/host/ehci-mx6.c
> +++ b/drivers/usb/host/ehci-mx6.c
> @@ -538,7 +538,7 @@ static int ehci_usb_phy_mode(struct udevice *dev)
>                         plat->init_type = USB_INIT_DEVICE;
>                 else
>                         plat->init_type = USB_INIT_HOST;
> -       } else if (is_mx7() || is_imx8mm() || is_imx8mn()) {
> +       } else if (is_mx7() || is_imx8mm() || is_imx8mn() || is_imx93()) {
>                 phy_status = (void __iomem *)(addr +
>                                               USBNC_PHY_STATUS_OFFSET);
>                 val = readl(phy_status);
> --
> 2.41.0
>

Re: [PATCH] usb: ehci-mx6: Add i.MX93 support

[Marek Vasut]

On 2/19/24 14:18, Fabio Estevam wrote:
> Hi Mathieu,
> 
> On Mon, Feb 19, 2024 at 5:43 AM Mathieu Othacehe <othacehe@gnu.org> wrote:
>>
>> i.MX93 uses the same USB IP as i.MX8MM. It can then reuse the ehci-mx6
>> driver.
>>
>> Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
> 
> You missed copying Marek Vasut, who is the USB maintainer.

The patch itself looks fine:

Reviewed-by: Marek Vasut <marex@denx.de>

Just send a V2 with the collected tags so it can be applied.

Thanks !