From: Simon Horman <horms@kernel.org>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Alan Brady <alan.brady@intel.com>,
Jakub Kicinski <kuba@kernel.org>,
intel-wired-lan@lists.osuosl.org, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 2/2] net: intel: implement modern PM ops declarations
Date: Mon, 19 Feb 2024 09:22:16 +0000 [thread overview]
Message-ID: <20240219092216.GT40273@kernel.org> (raw)
In-Reply-To: <20240210220109.3179408-3-jesse.brandeburg@intel.com>
On Sat, Feb 10, 2024 at 02:01:09PM -0800, Jesse Brandeburg wrote:
> Switch the Intel networking drivers to use the new power management ops
> declaration formats and macros, which allows us to drop __maybe_unused,
> as well as a bunch of ifdef checking CONFIG_PM.
>
> This is safe to do because the compiler drops the unused functions,
> verified by checking for any of the power management function symbols
> being present in System.map for a build without CONFIG_PM.
>
> If a driver has runtime PM, define the ops with pm_ptr(), and if the
> driver has Simple PM, use pm_sleep_ptr(), as well as the new versions of
> the macros for declaring the members of the pm_ops structs.
>
> Checked with network-enabled allnoconfig, allyesconfig, allmodconfig on
> x64_64.
>
> Reviewed-by: Alan Brady <alan.brady@intel.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Alan Brady <alan.brady@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH iwl-next v1 2/2] net: intel: implement modern PM ops declarations
Date: Mon, 19 Feb 2024 09:22:16 +0000 [thread overview]
Message-ID: <20240219092216.GT40273@kernel.org> (raw)
In-Reply-To: <20240210220109.3179408-3-jesse.brandeburg@intel.com>
On Sat, Feb 10, 2024 at 02:01:09PM -0800, Jesse Brandeburg wrote:
> Switch the Intel networking drivers to use the new power management ops
> declaration formats and macros, which allows us to drop __maybe_unused,
> as well as a bunch of ifdef checking CONFIG_PM.
>
> This is safe to do because the compiler drops the unused functions,
> verified by checking for any of the power management function symbols
> being present in System.map for a build without CONFIG_PM.
>
> If a driver has runtime PM, define the ops with pm_ptr(), and if the
> driver has Simple PM, use pm_sleep_ptr(), as well as the new versions of
> the macros for declaring the members of the pm_ops structs.
>
> Checked with network-enabled allnoconfig, allyesconfig, allmodconfig on
> x64_64.
>
> Reviewed-by: Alan Brady <alan.brady@intel.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-02-19 9:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-10 22:01 [Intel-wired-lan] [PATCH iwl-next v1 0/2] net: intel: cleanup power ops Jesse Brandeburg
2024-02-10 22:01 ` Jesse Brandeburg
2024-02-10 22:01 ` [Intel-wired-lan] [PATCH iwl-next v1 1/2] igb: simplify pci ops declaration Jesse Brandeburg
2024-02-10 22:01 ` Jesse Brandeburg
2024-02-14 10:32 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-02-14 10:32 ` Pucha, HimasekharX Reddy
2024-02-19 9:15 ` Simon Horman
2024-02-19 9:15 ` Simon Horman
2024-02-20 16:48 ` [Intel-wired-lan] " Jesse Brandeburg
2024-02-20 16:48 ` Jesse Brandeburg
2024-02-21 10:35 ` [Intel-wired-lan] " Simon Horman
2024-02-21 10:35 ` Simon Horman
2024-02-21 11:02 ` [Intel-wired-lan] " Paul Menzel
2024-02-21 11:02 ` Paul Menzel
2024-02-10 22:01 ` [Intel-wired-lan] [PATCH iwl-next v1 2/2] net: intel: implement modern PM ops declarations Jesse Brandeburg
2024-02-10 22:01 ` Jesse Brandeburg
2024-02-14 10:37 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-02-14 10:37 ` Pucha, HimasekharX Reddy
2024-02-19 9:22 ` Simon Horman [this message]
2024-02-19 9:22 ` Simon Horman
2024-02-22 13:05 ` [Intel-wired-lan] " Romanowski, Rafal
2024-02-22 13:05 ` Romanowski, Rafal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240219092216.GT40273@kernel.org \
--to=horms@kernel.org \
--cc=alan.brady@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.