* [PATCH 1/1] media: i2c: imx290: Fix IMX920 typo
@ 2024-02-21 7:15 Alexander Stein
2024-02-21 7:17 ` Manivannan Sadhasivam
2024-02-21 12:01 ` Laurent Pinchart
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Stein @ 2024-02-21 7:15 UTC (permalink / raw)
To: Manivannan Sadhasivam, Sakari Ailus, Mauro Carvalho Chehab,
Laurent Pinchart
Cc: Alexander Stein, linux-media
Replace IMX920 by IMX290.
Fixes: b4ab57b07c5b9 ("media: i2c: imx290: Add crop selection targets support")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/media/i2c/imx290.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
index 89fcebe178395..d75e36018cdc0 100644
--- a/drivers/media/i2c/imx290.c
+++ b/drivers/media/i2c/imx290.c
@@ -150,10 +150,10 @@
#define IMX290_PIXEL_ARRAY_WIDTH 1945
#define IMX290_PIXEL_ARRAY_HEIGHT 1097
-#define IMX920_PIXEL_ARRAY_MARGIN_LEFT 12
-#define IMX920_PIXEL_ARRAY_MARGIN_RIGHT 13
-#define IMX920_PIXEL_ARRAY_MARGIN_TOP 8
-#define IMX920_PIXEL_ARRAY_MARGIN_BOTTOM 9
+#define IMX290_PIXEL_ARRAY_MARGIN_LEFT 12
+#define IMX290_PIXEL_ARRAY_MARGIN_RIGHT 13
+#define IMX290_PIXEL_ARRAY_MARGIN_TOP 8
+#define IMX290_PIXEL_ARRAY_MARGIN_BOTTOM 9
#define IMX290_PIXEL_ARRAY_RECORDING_WIDTH 1920
#define IMX290_PIXEL_ARRAY_RECORDING_HEIGHT 1080
@@ -1161,10 +1161,10 @@ static int imx290_get_selection(struct v4l2_subdev *sd,
* The sensor moves the readout by 1 pixel based on flips to
* keep the Bayer order the same.
*/
- sel->r.top = IMX920_PIXEL_ARRAY_MARGIN_TOP
+ sel->r.top = IMX290_PIXEL_ARRAY_MARGIN_TOP
+ (IMX290_PIXEL_ARRAY_RECORDING_HEIGHT - format->height) / 2
+ imx290->vflip->val;
- sel->r.left = IMX920_PIXEL_ARRAY_MARGIN_LEFT
+ sel->r.left = IMX290_PIXEL_ARRAY_MARGIN_LEFT
+ (IMX290_PIXEL_ARRAY_RECORDING_WIDTH - format->width) / 2
+ imx290->hflip->val;
sel->r.width = format->width;
@@ -1183,8 +1183,8 @@ static int imx290_get_selection(struct v4l2_subdev *sd,
return 0;
case V4L2_SEL_TGT_CROP_DEFAULT:
- sel->r.top = IMX920_PIXEL_ARRAY_MARGIN_TOP;
- sel->r.left = IMX920_PIXEL_ARRAY_MARGIN_LEFT;
+ sel->r.top = IMX290_PIXEL_ARRAY_MARGIN_TOP;
+ sel->r.left = IMX290_PIXEL_ARRAY_MARGIN_LEFT;
sel->r.width = IMX290_PIXEL_ARRAY_RECORDING_WIDTH;
sel->r.height = IMX290_PIXEL_ARRAY_RECORDING_HEIGHT;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] media: i2c: imx290: Fix IMX920 typo
2024-02-21 7:15 [PATCH 1/1] media: i2c: imx290: Fix IMX920 typo Alexander Stein
@ 2024-02-21 7:17 ` Manivannan Sadhasivam
2024-02-21 12:01 ` Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2024-02-21 7:17 UTC (permalink / raw)
To: Alexander Stein
Cc: Sakari Ailus, Mauro Carvalho Chehab, Laurent Pinchart,
linux-media
On Wed, Feb 21, 2024 at 08:15:50AM +0100, Alexander Stein wrote:
> Replace IMX920 by IMX290.
>
> Fixes: b4ab57b07c5b9 ("media: i2c: imx290: Add crop selection targets support")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> drivers/media/i2c/imx290.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
> index 89fcebe178395..d75e36018cdc0 100644
> --- a/drivers/media/i2c/imx290.c
> +++ b/drivers/media/i2c/imx290.c
> @@ -150,10 +150,10 @@
>
> #define IMX290_PIXEL_ARRAY_WIDTH 1945
> #define IMX290_PIXEL_ARRAY_HEIGHT 1097
> -#define IMX920_PIXEL_ARRAY_MARGIN_LEFT 12
> -#define IMX920_PIXEL_ARRAY_MARGIN_RIGHT 13
> -#define IMX920_PIXEL_ARRAY_MARGIN_TOP 8
> -#define IMX920_PIXEL_ARRAY_MARGIN_BOTTOM 9
> +#define IMX290_PIXEL_ARRAY_MARGIN_LEFT 12
> +#define IMX290_PIXEL_ARRAY_MARGIN_RIGHT 13
> +#define IMX290_PIXEL_ARRAY_MARGIN_TOP 8
> +#define IMX290_PIXEL_ARRAY_MARGIN_BOTTOM 9
> #define IMX290_PIXEL_ARRAY_RECORDING_WIDTH 1920
> #define IMX290_PIXEL_ARRAY_RECORDING_HEIGHT 1080
>
> @@ -1161,10 +1161,10 @@ static int imx290_get_selection(struct v4l2_subdev *sd,
> * The sensor moves the readout by 1 pixel based on flips to
> * keep the Bayer order the same.
> */
> - sel->r.top = IMX920_PIXEL_ARRAY_MARGIN_TOP
> + sel->r.top = IMX290_PIXEL_ARRAY_MARGIN_TOP
> + (IMX290_PIXEL_ARRAY_RECORDING_HEIGHT - format->height) / 2
> + imx290->vflip->val;
> - sel->r.left = IMX920_PIXEL_ARRAY_MARGIN_LEFT
> + sel->r.left = IMX290_PIXEL_ARRAY_MARGIN_LEFT
> + (IMX290_PIXEL_ARRAY_RECORDING_WIDTH - format->width) / 2
> + imx290->hflip->val;
> sel->r.width = format->width;
> @@ -1183,8 +1183,8 @@ static int imx290_get_selection(struct v4l2_subdev *sd,
> return 0;
>
> case V4L2_SEL_TGT_CROP_DEFAULT:
> - sel->r.top = IMX920_PIXEL_ARRAY_MARGIN_TOP;
> - sel->r.left = IMX920_PIXEL_ARRAY_MARGIN_LEFT;
> + sel->r.top = IMX290_PIXEL_ARRAY_MARGIN_TOP;
> + sel->r.left = IMX290_PIXEL_ARRAY_MARGIN_LEFT;
> sel->r.width = IMX290_PIXEL_ARRAY_RECORDING_WIDTH;
> sel->r.height = IMX290_PIXEL_ARRAY_RECORDING_HEIGHT;
>
> --
> 2.34.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] media: i2c: imx290: Fix IMX920 typo
2024-02-21 7:15 [PATCH 1/1] media: i2c: imx290: Fix IMX920 typo Alexander Stein
2024-02-21 7:17 ` Manivannan Sadhasivam
@ 2024-02-21 12:01 ` Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2024-02-21 12:01 UTC (permalink / raw)
To: Alexander Stein
Cc: Manivannan Sadhasivam, Sakari Ailus, Mauro Carvalho Chehab,
linux-media
Hi Alexander,
Thank you for the patch.
On Wed, Feb 21, 2024 at 08:15:50AM +0100, Alexander Stein wrote:
> Replace IMX920 by IMX290.
>
> Fixes: b4ab57b07c5b9 ("media: i2c: imx290: Add crop selection targets support")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/imx290.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
> index 89fcebe178395..d75e36018cdc0 100644
> --- a/drivers/media/i2c/imx290.c
> +++ b/drivers/media/i2c/imx290.c
> @@ -150,10 +150,10 @@
>
> #define IMX290_PIXEL_ARRAY_WIDTH 1945
> #define IMX290_PIXEL_ARRAY_HEIGHT 1097
> -#define IMX920_PIXEL_ARRAY_MARGIN_LEFT 12
> -#define IMX920_PIXEL_ARRAY_MARGIN_RIGHT 13
> -#define IMX920_PIXEL_ARRAY_MARGIN_TOP 8
> -#define IMX920_PIXEL_ARRAY_MARGIN_BOTTOM 9
> +#define IMX290_PIXEL_ARRAY_MARGIN_LEFT 12
> +#define IMX290_PIXEL_ARRAY_MARGIN_RIGHT 13
> +#define IMX290_PIXEL_ARRAY_MARGIN_TOP 8
> +#define IMX290_PIXEL_ARRAY_MARGIN_BOTTOM 9
> #define IMX290_PIXEL_ARRAY_RECORDING_WIDTH 1920
> #define IMX290_PIXEL_ARRAY_RECORDING_HEIGHT 1080
>
> @@ -1161,10 +1161,10 @@ static int imx290_get_selection(struct v4l2_subdev *sd,
> * The sensor moves the readout by 1 pixel based on flips to
> * keep the Bayer order the same.
> */
> - sel->r.top = IMX920_PIXEL_ARRAY_MARGIN_TOP
> + sel->r.top = IMX290_PIXEL_ARRAY_MARGIN_TOP
> + (IMX290_PIXEL_ARRAY_RECORDING_HEIGHT - format->height) / 2
> + imx290->vflip->val;
> - sel->r.left = IMX920_PIXEL_ARRAY_MARGIN_LEFT
> + sel->r.left = IMX290_PIXEL_ARRAY_MARGIN_LEFT
> + (IMX290_PIXEL_ARRAY_RECORDING_WIDTH - format->width) / 2
> + imx290->hflip->val;
> sel->r.width = format->width;
> @@ -1183,8 +1183,8 @@ static int imx290_get_selection(struct v4l2_subdev *sd,
> return 0;
>
> case V4L2_SEL_TGT_CROP_DEFAULT:
> - sel->r.top = IMX920_PIXEL_ARRAY_MARGIN_TOP;
> - sel->r.left = IMX920_PIXEL_ARRAY_MARGIN_LEFT;
> + sel->r.top = IMX290_PIXEL_ARRAY_MARGIN_TOP;
> + sel->r.left = IMX290_PIXEL_ARRAY_MARGIN_LEFT;
> sel->r.width = IMX290_PIXEL_ARRAY_RECORDING_WIDTH;
> sel->r.height = IMX290_PIXEL_ARRAY_RECORDING_HEIGHT;
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-21 12:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-21 7:15 [PATCH 1/1] media: i2c: imx290: Fix IMX920 typo Alexander Stein
2024-02-21 7:17 ` Manivannan Sadhasivam
2024-02-21 12:01 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.