From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Mateusz Polchlopek <mateusz.polchlopek@intel.com>,
netdev@vger.kernel.org, Lukasz Czapnik <lukasz.czapnik@intel.com>,
intel-wired-lan@lists.osuosl.org, horms@kernel.org,
przemyslaw.kitszel@intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: Add tx_scheduling_layers devlink param
Date: Wed, 21 Feb 2024 15:38:05 -0800 [thread overview]
Message-ID: <20240221153805.20fbaf47@kernel.org> (raw)
In-Reply-To: <ZdNLkJm2qr1kZCis@nanopsycho>
On Mon, 19 Feb 2024 13:37:36 +0100 Jiri Pirko wrote:
> >devlink dev param show pci/0000:4b:00.0 name tx_scheduling_layers
> >pci/0000:4b:00.0:
> > name tx_scheduling_layers type driver-specific
> > values:
> > cmode permanent value 9
> >
> >Set:
> >devlink dev param set pci/0000:4b:00.0 name tx_scheduling_layers value 5
> >cmode permanent
It's been almost a year since v1 was posted, could you iterate quicker? :(
> This is kind of proprietary param similar to number of which were shot
> down for mlx5 in past. Jakub?
I remain somewhat confused about what this does.
Specifically IIUC the problem is that the radix of each node is
limited, so we need to start creating multi-layer hierarchies
if we want a higher radix. Or in the "5-layer mode" the radix
is automatically higher?
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Mateusz Polchlopek <mateusz.polchlopek@intel.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
horms@kernel.org, przemyslaw.kitszel@intel.com,
Lukasz Czapnik <lukasz.czapnik@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: Add tx_scheduling_layers devlink param
Date: Wed, 21 Feb 2024 15:38:05 -0800 [thread overview]
Message-ID: <20240221153805.20fbaf47@kernel.org> (raw)
In-Reply-To: <ZdNLkJm2qr1kZCis@nanopsycho>
On Mon, 19 Feb 2024 13:37:36 +0100 Jiri Pirko wrote:
> >devlink dev param show pci/0000:4b:00.0 name tx_scheduling_layers
> >pci/0000:4b:00.0:
> > name tx_scheduling_layers type driver-specific
> > values:
> > cmode permanent value 9
> >
> >Set:
> >devlink dev param set pci/0000:4b:00.0 name tx_scheduling_layers value 5
> >cmode permanent
It's been almost a year since v1 was posted, could you iterate quicker? :(
> This is kind of proprietary param similar to number of which were shot
> down for mlx5 in past. Jakub?
I remain somewhat confused about what this does.
Specifically IIUC the problem is that the radix of each node is
limited, so we need to start creating multi-layer hierarchies
if we want a higher radix. Or in the "5-layer mode" the radix
is automatically higher?
next prev parent reply other threads:[~2024-02-21 23:38 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 10:05 [Intel-wired-lan] [PATCH iwl-next v4 0/5] ice: Support 5 layer Tx scheduler topology Mateusz Polchlopek
2024-02-19 10:05 ` Mateusz Polchlopek
2024-02-19 10:05 ` [Intel-wired-lan] [PATCH iwl-next v1 1/5] ice: Support 5 layer topology Mateusz Polchlopek
2024-02-19 10:05 ` Mateusz Polchlopek
2024-02-19 10:16 ` Mateusz Polchlopek
2024-02-19 10:16 ` Mateusz Polchlopek
2024-02-19 10:05 ` [Intel-wired-lan] [PATCH iwl-next v4 2/5] ice: Adjust the VSI/Aggregator layers Mateusz Polchlopek
2024-02-19 10:05 ` Mateusz Polchlopek
2024-02-19 10:05 ` [Intel-wired-lan] [PATCH iwl-next v4 3/5] ice: Enable switching default Tx scheduler topology Mateusz Polchlopek
2024-02-19 10:05 ` Mateusz Polchlopek
2024-02-19 10:05 ` [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: Add tx_scheduling_layers devlink param Mateusz Polchlopek
2024-02-19 10:05 ` Mateusz Polchlopek
2024-02-19 12:37 ` Jiri Pirko
2024-02-19 12:37 ` Jiri Pirko
2024-02-19 13:33 ` Przemek Kitszel
2024-02-19 13:33 ` Przemek Kitszel
2024-02-19 17:15 ` Jiri Pirko
2024-02-19 17:15 ` Jiri Pirko
2024-02-21 23:38 ` Jakub Kicinski [this message]
2024-02-21 23:38 ` Jakub Kicinski
2024-02-22 13:25 ` Mateusz Polchlopek
2024-02-22 13:25 ` Mateusz Polchlopek
2024-02-22 23:07 ` Jakub Kicinski
2024-02-22 23:07 ` Jakub Kicinski
2024-02-23 9:45 ` Jiri Pirko
2024-02-23 9:45 ` Jiri Pirko
2024-02-23 14:27 ` Jakub Kicinski
2024-02-23 14:27 ` Jakub Kicinski
2024-02-25 7:18 ` Jiri Pirko
2024-02-25 7:18 ` Jiri Pirko
2024-02-27 2:37 ` Jakub Kicinski
2024-02-27 2:37 ` Jakub Kicinski
2024-02-27 12:17 ` Jiri Pirko
2024-02-27 12:17 ` Jiri Pirko
2024-02-27 13:05 ` Przemek Kitszel
2024-02-27 13:05 ` Przemek Kitszel
2024-02-27 15:39 ` Jiri Pirko
2024-02-27 15:39 ` Jiri Pirko
2024-02-27 15:41 ` Andrew Lunn
2024-02-27 15:41 ` Andrew Lunn
2024-02-27 16:04 ` Jiri Pirko
2024-02-27 16:04 ` Jiri Pirko
2024-02-27 20:38 ` Andrew Lunn
2024-02-27 20:38 ` Andrew Lunn
2024-02-19 10:05 ` [Intel-wired-lan] [PATCH iwl-next v4 5/5] ice: Document tx_scheduling_layers parameter Mateusz Polchlopek
2024-02-19 10:05 ` Mateusz Polchlopek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240221153805.20fbaf47@kernel.org \
--to=kuba@kernel.org \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jiri@resnulli.us \
--cc=lukasz.czapnik@intel.com \
--cc=mateusz.polchlopek@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.