From: Greg KH <gregkh@linuxfoundation.org>
To: max.oss.09@gmail.com
Cc: stable@vger.kernel.org, patches@lists.linux.dev,
s.hauer@pengutronix.de, han.xu@nxp.com,
tomasz.mon@camlingroup.com, richard@nod.at,
tharvey@gateworks.com, linux-mtd@lists.infradead.org,
Max Krummenacher <max.krummenacher@toradex.com>
Subject: Re: [regression 5.4.y][RFC][PATCH 0/1] mtd: rawnand: gpmi: busy_timeout_cycles
Date: Wed, 21 Feb 2024 12:00:56 +0100 [thread overview]
Message-ID: <2024022151-tinker-sprang-5fa2@gregkh> (raw)
In-Reply-To: <20240207174911.870822-1-max.oss.09@gmail.com>
On Wed, Feb 07, 2024 at 06:49:10PM +0100, max.oss.09@gmail.com wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
>
> Hello
>
> With the backported commit e09ff743e30b ("mtd: rawnand: gpmi: Set
> WAIT_FOR_READY timeout based on program/erase times") in kernel 5.4.y
> I see corruption of the NAND content during kernel boot.
> Reverting said commit on top of current 5.4.y fixes the issue.
>
> It seems that the commit relies on commit 71c76f56b97c ("mtd:
> rawnand: gpmi: Fix setting busy timeout setting"), but its
> backport got reverted.
> One should either backport both commits or none, having only one
> results in potential bugs.
>
> I've seen it in 5.4.y, however in 5.10.y and 5.15.y there one of
> the two backports is also reverted and likely the same regression
> exists.
>
> Any comments?
>
> Max
>
> Max Krummenacher (1):
> Revert "Revert "mtd: rawnand: gpmi: Fix setting busy timeout setting""
>
> drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.42.0
>
>
Now queeud up, thanks.
greg k-h
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: max.oss.09@gmail.com
Cc: stable@vger.kernel.org, patches@lists.linux.dev,
s.hauer@pengutronix.de, han.xu@nxp.com,
tomasz.mon@camlingroup.com, richard@nod.at,
tharvey@gateworks.com, linux-mtd@lists.infradead.org,
Max Krummenacher <max.krummenacher@toradex.com>
Subject: Re: [regression 5.4.y][RFC][PATCH 0/1] mtd: rawnand: gpmi: busy_timeout_cycles
Date: Wed, 21 Feb 2024 12:00:56 +0100 [thread overview]
Message-ID: <2024022151-tinker-sprang-5fa2@gregkh> (raw)
In-Reply-To: <20240207174911.870822-1-max.oss.09@gmail.com>
On Wed, Feb 07, 2024 at 06:49:10PM +0100, max.oss.09@gmail.com wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
>
> Hello
>
> With the backported commit e09ff743e30b ("mtd: rawnand: gpmi: Set
> WAIT_FOR_READY timeout based on program/erase times") in kernel 5.4.y
> I see corruption of the NAND content during kernel boot.
> Reverting said commit on top of current 5.4.y fixes the issue.
>
> It seems that the commit relies on commit 71c76f56b97c ("mtd:
> rawnand: gpmi: Fix setting busy timeout setting"), but its
> backport got reverted.
> One should either backport both commits or none, having only one
> results in potential bugs.
>
> I've seen it in 5.4.y, however in 5.10.y and 5.15.y there one of
> the two backports is also reverted and likely the same regression
> exists.
>
> Any comments?
>
> Max
>
> Max Krummenacher (1):
> Revert "Revert "mtd: rawnand: gpmi: Fix setting busy timeout setting""
>
> drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.42.0
>
>
Now queeud up, thanks.
greg k-h
next prev parent reply other threads:[~2024-02-21 11:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 17:49 [regression 5.4.y][RFC][PATCH 0/1] mtd: rawnand: gpmi: busy_timeout_cycles max.oss.09
2024-02-07 17:49 ` max.oss.09
2024-02-07 17:49 ` [regression 5.4.y][RFC][PATCH mtd: rawnand: gpmi: busy_timeout_cycles 1/1] Revert "Revert "mtd: rawnand: gpmi: Fix setting busy timeout setting"" max.oss.09
2024-02-07 17:49 ` max.oss.09
2024-02-21 11:10 ` Patch "Revert "Revert "mtd: rawnand: gpmi: Fix setting busy timeout setting""" has been added to the 5.4-stable tree gregkh
2024-02-21 11:10 ` gregkh
2024-02-21 11:00 ` Greg KH [this message]
2024-02-21 11:00 ` [regression 5.4.y][RFC][PATCH 0/1] mtd: rawnand: gpmi: busy_timeout_cycles Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024022151-tinker-sprang-5fa2@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=han.xu@nxp.com \
--cc=linux-mtd@lists.infradead.org \
--cc=max.krummenacher@toradex.com \
--cc=max.oss.09@gmail.com \
--cc=patches@lists.linux.dev \
--cc=richard@nod.at \
--cc=s.hauer@pengutronix.de \
--cc=stable@vger.kernel.org \
--cc=tharvey@gateworks.com \
--cc=tomasz.mon@camlingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.