All of lore.kernel.org
 help / color / mirror / Atom feed
* [merged mm-stable] mm-list_lru-disable-memcg_aware-when-cgroupmemory-is-set-to-nokmem.patch removed from -mm tree
@ 2024-02-22  0:01 Andrew Morton
  0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2024-02-22  0:01 UTC (permalink / raw)
  To: mm-commits, shakeelb, roman.gushchin, mhocko, hannes, haifeng.xu,
	akpm


The quilt patch titled
     Subject: mm: list_lru: disable memcg_aware when cgroup.memory is set to "nokmem"
has been removed from the -mm tree.  Its filename was
     mm-list_lru-disable-memcg_aware-when-cgroupmemory-is-set-to-nokmem.patch

This patch was dropped because it was merged into the mm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Haifeng Xu <haifeng.xu@shopee.com>
Subject: mm: list_lru: disable memcg_aware when cgroup.memory is set to "nokmem"
Date: Thu, 28 Dec 2023 06:27:14 +0000

Actually, when using a boot time kernel option "cgroup.memory=nokmem", all
lru items are inserted to list_lru_node.  But for those users who invoke
list_lru_init_memcg() to initialize list_lru, list_lru_memcg_aware()
returns true.  And this brings unneeded operations related to memcg.

To make things more convenient, let's disable memcg_aware when
cgroup.memory is set to "nokmem".

Link: https://lkml.kernel.org/r/20231228062715.338672-1-haifeng.xu@shopee.com
Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
Acked-by: Roman Gushchin <roman.gushchin@linux.dev>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Shakeel Butt <shakeelb@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/list_lru.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/mm/list_lru.c~mm-list_lru-disable-memcg_aware-when-cgroupmemory-is-set-to-nokmem
+++ a/mm/list_lru.c
@@ -567,6 +567,9 @@ int __list_lru_init(struct list_lru *lru
 		lru->shrinker_id = shrinker->id;
 	else
 		lru->shrinker_id = -1;
+
+	if (mem_cgroup_kmem_disabled())
+		memcg_aware = false;
 #endif
 
 	lru->node = kcalloc(nr_node_ids, sizeof(*lru->node), GFP_KERNEL);
_

Patches currently in -mm which might be from haifeng.xu@shopee.com are



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-02-22  0:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-22  0:01 [merged mm-stable] mm-list_lru-disable-memcg_aware-when-cgroupmemory-is-set-to-nokmem.patch removed from -mm tree Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.