From: Keith Busch <kbusch@meta.com>
To: <linux-block@vger.kernel.org>
Cc: <axboe@kernel.org>, <ming.lei@redhat.com>, <nilay@linux.ibm.com>,
<chaitanyak@nvidia.com>, Keith Busch <kbusch@kernel.org>
Subject: [PATCHv3 1/4] block: blkdev_issue_secure_erase loop style
Date: Thu, 22 Feb 2024 11:19:19 -0800 [thread overview]
Message-ID: <20240222191922.2130580-2-kbusch@meta.com> (raw)
In-Reply-To: <20240222191922.2130580-1-kbusch@meta.com>
From: Keith Busch <kbusch@kernel.org>
Use consistent coding style in this file. All the other loops for the
same purpose use "while (nr_sects)", so they win.
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
block/blk-lib.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/block/blk-lib.c b/block/blk-lib.c
index e59c3069e8351..91770da2239f2 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -322,7 +322,7 @@ int blkdev_issue_secure_erase(struct block_device *bdev, sector_t sector,
return -EPERM;
blk_start_plug(&plug);
- for (;;) {
+ while (nr_sects) {
unsigned int len = min_t(sector_t, nr_sects, max_sectors);
bio = blk_next_bio(bio, bdev, 0, REQ_OP_SECURE_ERASE, gfp);
@@ -331,13 +331,12 @@ int blkdev_issue_secure_erase(struct block_device *bdev, sector_t sector,
sector += len;
nr_sects -= len;
- if (!nr_sects) {
- ret = submit_bio_wait(bio);
- bio_put(bio);
- break;
- }
cond_resched();
}
+ if (bio) {
+ ret = submit_bio_wait(bio);
+ bio_put(bio);
+ }
blk_finish_plug(&plug);
return ret;
--
2.34.1
next prev parent reply other threads:[~2024-02-22 19:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 19:19 [PATCHv3 0/4] block: make long runnint operations killable Keith Busch
2024-02-22 19:19 ` Keith Busch [this message]
2024-02-23 3:22 ` [PATCHv3 1/4] block: blkdev_issue_secure_erase loop style Ming Lei
2024-02-23 6:41 ` Christoph Hellwig
2024-02-22 19:19 ` [PATCHv3 2/4] block: __blkdev_issue_write_zeroes cleanup Keith Busch
2024-02-23 3:29 ` Ming Lei
2024-02-23 6:42 ` Christoph Hellwig
2024-02-22 19:19 ` [PATCHv3 3/4] block: introduce io wait hang check helper Keith Busch
2024-02-23 3:31 ` Ming Lei
2024-02-23 6:43 ` Christoph Hellwig
2024-02-22 19:19 ` [PATCHv3 4/4] blk-lib: check for kill signal Keith Busch
2024-02-23 3:38 ` Ming Lei
2024-02-23 6:46 ` Christoph Hellwig
2024-02-23 11:00 ` Nilay Shroff
2024-02-23 15:58 ` Keith Busch
2024-02-23 11:25 ` [PATCHv3 0/4] block: make long runnint operations killable Nilay Shroff
2024-02-23 15:57 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240222191922.2130580-2-kbusch@meta.com \
--to=kbusch@meta.com \
--cc=axboe@kernel.org \
--cc=chaitanyak@nvidia.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nilay@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.