From: Christoph Hellwig <hch@infradead.org>
To: Keith Busch <kbusch@meta.com>
Cc: linux-block@vger.kernel.org, axboe@kernel.org,
ming.lei@redhat.com, nilay@linux.ibm.com, chaitanyak@nvidia.com,
Keith Busch <kbusch@kernel.org>,
Conrad Meyer <conradmeyer@meta.com>
Subject: Re: [PATCHv3 4/4] blk-lib: check for kill signal
Date: Thu, 22 Feb 2024 22:46:29 -0800 [thread overview]
Message-ID: <Zdg_RQ1xeu9O-K0Z@infradead.org> (raw)
In-Reply-To: <20240222191922.2130580-5-kbusch@meta.com>
> +static void abort_bio(struct bio *bio)
> +{
> + DECLARE_COMPLETION_ONSTACK_MAP(done,
> + bio->bi_bdev->bd_disk->lockdep_map);
> +
> + bio->bi_private = &done;
> + bio->bi_end_io = abort_bio_endio;
> + bio_endio(bio);
> + blk_wait_io(&done);
> +}
Without seeing the context below this looks pretty weird, but once
seeing that we're waiting for the previously submitted bios it all
makes sense. Please write a a good comment explaining this, and
maybe also use a name that is a bit more descriptive.
next prev parent reply other threads:[~2024-02-23 6:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 19:19 [PATCHv3 0/4] block: make long runnint operations killable Keith Busch
2024-02-22 19:19 ` [PATCHv3 1/4] block: blkdev_issue_secure_erase loop style Keith Busch
2024-02-23 3:22 ` Ming Lei
2024-02-23 6:41 ` Christoph Hellwig
2024-02-22 19:19 ` [PATCHv3 2/4] block: __blkdev_issue_write_zeroes cleanup Keith Busch
2024-02-23 3:29 ` Ming Lei
2024-02-23 6:42 ` Christoph Hellwig
2024-02-22 19:19 ` [PATCHv3 3/4] block: introduce io wait hang check helper Keith Busch
2024-02-23 3:31 ` Ming Lei
2024-02-23 6:43 ` Christoph Hellwig
2024-02-22 19:19 ` [PATCHv3 4/4] blk-lib: check for kill signal Keith Busch
2024-02-23 3:38 ` Ming Lei
2024-02-23 6:46 ` Christoph Hellwig [this message]
2024-02-23 11:00 ` Nilay Shroff
2024-02-23 15:58 ` Keith Busch
2024-02-23 11:25 ` [PATCHv3 0/4] block: make long runnint operations killable Nilay Shroff
2024-02-23 15:57 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zdg_RQ1xeu9O-K0Z@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.org \
--cc=chaitanyak@nvidia.com \
--cc=conradmeyer@meta.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nilay@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.