Re: [PATCH v2 4/4] arm64: dts: sun50i-a64-pinephone: change led type to status

From: Lee Jones <lee@kernel.org>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Aren Moynihan <aren@peacevolution.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org,
	Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
	Chen-Yu Tsai <wens@csie.org>, Ondrej Jirman <megi@xff.cz>,
	linux-sunxi@lists.linux.dev, Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org, linux-leds@vger.kernel.org,
	Conor Dooley <conor+dt@kernel.org>, Miles Alan <m@milesalan.com>,
	Samuel Holland <samuel@sholland.org>
Subject: Re: [PATCH v2 4/4] arm64: dts: sun50i-a64-pinephone: change led type to status
Date: Fri, 23 Feb 2024 10:29:14 +0000	[thread overview]
Message-ID: <20240223102914.GO10170@google.com> (raw)
In-Reply-To: <2792937.BEx9A2HvPv@jernej-laptop>

On Thu, 22 Feb 2024, Jernej Škrabec wrote:

> Dne torek, 06. februar 2024 ob 19:13:20 CET je Aren Moynihan napisal(a):
> > The status function is described in the documentation as being a rgb led
> > used for system notifications on phones[1][2]. This is exactly what this
> > led is used for on the PinePhone, so using status is probably more
> > accurate than indicator.
> > 
> > 1: Documentation/leds/well-known-leds.txt
> > 2: include/dt-bindings/leds/common.h
> > 
> > Signed-off-by: Aren Moynihan <aren@peacevolution.org>
> 
> Sorry for late review.
> 
> Please update subject in patches 2-3. Instead of "sun50i-a64-pinephone:"
> use "allwinner: pinephone:" (check commit history of sun50i-a64-pinephone.dtsi).
> Also rgb -> RGB, led -> LED. Last, please reword commit message to exclude
> links and just say DT bindings documentation.
> 
> Note that I'll merge patches 2-3 once patch 1 is merged.

Works for me - I'll go apply it now.

-- 
Lee Jones [李琼斯]