From: Zev Weiss <zweiss@equinix.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH 1/2] dt-bindings: arm: aspeed: add ASUS X4TF board
Date: Fri, 23 Feb 2024 22:01:15 +0000 [thread overview]
Message-ID: <20240223220115.GB9299@packtop> (raw)
In-Reply-To: <20240222-getting-nebulizer-8f75ba8063b1@spud>
On Thu, Feb 22, 2024 at 08:02:07AM PST, Conor Dooley wrote:
>On Thu, Feb 22, 2024 at 04:59:13PM +0800, Kelly Hung wrote:
>> Document the new compatibles used on ASUS X4TF.
>
>It would be good to mention here what the x4tf is - is it a bmc or
>an sbc etc.
>
...and if, as a quick web search indicates is likely the case, it's a
BMC for a server (or family of servers), following the existing naming
convention with something more like "asus,x4tf-bmc" might be nice.
Also, Kelly -- when sending revised versions of patches please use the
'-v' flag to git format-patch to include a version number in the subject
line so it's clearer what's going on. (So when posting the next version
incorporating the feedback on this one use '-v3', since this appears to
be a v2.)
Zev
WARNING: multiple messages have this Message-ID (diff)
From: Zev Weiss <zweiss@equinix.com>
To: Conor Dooley <conor@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
Kelly Hung <ppighouse@gmail.com>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kelly_hung@asus.com" <kelly_hung@asus.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"joel@jms.id.au" <joel@jms.id.au>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"Allenyy_Hsu@asus.com" <Allenyy_Hsu@asus.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] dt-bindings: arm: aspeed: add ASUS X4TF board
Date: Fri, 23 Feb 2024 22:01:15 +0000 [thread overview]
Message-ID: <20240223220115.GB9299@packtop> (raw)
In-Reply-To: <20240222-getting-nebulizer-8f75ba8063b1@spud>
On Thu, Feb 22, 2024 at 08:02:07AM PST, Conor Dooley wrote:
>On Thu, Feb 22, 2024 at 04:59:13PM +0800, Kelly Hung wrote:
>> Document the new compatibles used on ASUS X4TF.
>
>It would be good to mention here what the x4tf is - is it a bmc or
>an sbc etc.
>
...and if, as a quick web search indicates is likely the case, it's a
BMC for a server (or family of servers), following the existing naming
convention with something more like "asus,x4tf-bmc" might be nice.
Also, Kelly -- when sending revised versions of patches please use the
'-v' flag to git format-patch to include a version number in the subject
line so it's clearer what's going on. (So when posting the next version
incorporating the feedback on this one use '-v3', since this appears to
be a v2.)
Zev
WARNING: multiple messages have this Message-ID (diff)
From: Zev Weiss <zweiss@equinix.com>
To: Conor Dooley <conor@kernel.org>
Cc: Kelly Hung <ppighouse@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kelly_hung@asus.com" <kelly_hung@asus.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"joel@jms.id.au" <joel@jms.id.au>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"Allenyy_Hsu@asus.com" <Allenyy_Hsu@asus.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] dt-bindings: arm: aspeed: add ASUS X4TF board
Date: Fri, 23 Feb 2024 22:01:15 +0000 [thread overview]
Message-ID: <20240223220115.GB9299@packtop> (raw)
In-Reply-To: <20240222-getting-nebulizer-8f75ba8063b1@spud>
On Thu, Feb 22, 2024 at 08:02:07AM PST, Conor Dooley wrote:
>On Thu, Feb 22, 2024 at 04:59:13PM +0800, Kelly Hung wrote:
>> Document the new compatibles used on ASUS X4TF.
>
>It would be good to mention here what the x4tf is - is it a bmc or
>an sbc etc.
>
...and if, as a quick web search indicates is likely the case, it's a
BMC for a server (or family of servers), following the existing naming
convention with something more like "asus,x4tf-bmc" might be nice.
Also, Kelly -- when sending revised versions of patches please use the
'-v' flag to git format-patch to include a version number in the subject
line so it's clearer what's going on. (So when posting the next version
incorporating the feedback on this one use '-v3', since this appears to
be a v2.)
Zev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Zev Weiss <zweiss@equinix.com>
To: Conor Dooley <conor@kernel.org>
Cc: Kelly Hung <ppighouse@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kelly_hung@asus.com" <kelly_hung@asus.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"joel@jms.id.au" <joel@jms.id.au>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"Allenyy_Hsu@asus.com" <Allenyy_Hsu@asus.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] dt-bindings: arm: aspeed: add ASUS X4TF board
Date: Fri, 23 Feb 2024 22:01:15 +0000 [thread overview]
Message-ID: <20240223220115.GB9299@packtop> (raw)
In-Reply-To: <20240222-getting-nebulizer-8f75ba8063b1@spud>
On Thu, Feb 22, 2024 at 08:02:07AM PST, Conor Dooley wrote:
>On Thu, Feb 22, 2024 at 04:59:13PM +0800, Kelly Hung wrote:
>> Document the new compatibles used on ASUS X4TF.
>
>It would be good to mention here what the x4tf is - is it a bmc or
>an sbc etc.
>
...and if, as a quick web search indicates is likely the case, it's a
BMC for a server (or family of servers), following the existing naming
convention with something more like "asus,x4tf-bmc" might be nice.
Also, Kelly -- when sending revised versions of patches please use the
'-v' flag to git format-patch to include a version number in the subject
line so it's clearer what's going on. (So when posting the next version
incorporating the feedback on this one use '-v3', since this appears to
be a v2.)
Zev
next prev parent reply other threads:[~2024-02-23 22:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 8:59 [PATCH 1/2] dt-bindings: arm: aspeed: add ASUS X4TF board Kelly Hung
2024-02-22 8:59 ` Kelly Hung
2024-02-22 8:59 ` Kelly Hung
2024-02-22 8:59 ` Kelly Hung
2024-02-22 8:59 ` [PATCH 2/2] ARM: dts: aspeed: x4tf: Add dts for asus x4tf project Kelly Hung
2024-02-22 8:59 ` Kelly Hung
2024-02-22 8:59 ` Kelly Hung
2024-02-22 8:59 ` Kelly Hung
2024-02-23 21:56 ` Zev Weiss
2024-02-23 21:56 ` Zev Weiss
2024-02-23 21:56 ` Zev Weiss
2024-02-23 21:56 ` Zev Weiss
2024-02-29 7:23 ` Kelly Hung(洪嘉莉)
2024-02-29 7:23 ` Kelly Hung
2024-02-29 7:23 ` Kelly Hung(洪嘉莉)
2024-02-29 7:23 ` Kelly Hung(洪嘉莉)
2024-02-22 16:02 ` [PATCH 1/2] dt-bindings: arm: aspeed: add ASUS X4TF board Conor Dooley
2024-02-22 16:02 ` Conor Dooley
2024-02-22 16:02 ` Conor Dooley
2024-02-22 16:02 ` Conor Dooley
2024-02-23 2:47 ` Kelly Hung(洪嘉莉)
2024-02-23 2:47 ` Kelly Hung
2024-02-23 2:47 ` Kelly Hung(洪嘉莉)
2024-02-23 2:47 ` Kelly Hung(洪嘉莉)
2024-02-23 18:51 ` Conor Dooley
2024-02-23 18:51 ` Conor Dooley
2024-02-23 18:51 ` Conor Dooley
2024-02-23 18:51 ` Conor Dooley
2024-02-23 22:01 ` Zev Weiss [this message]
2024-02-23 22:01 ` Zev Weiss
2024-02-23 22:01 ` Zev Weiss
2024-02-23 22:01 ` Zev Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223220115.GB9299@packtop \
--to=zweiss@equinix.com \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.