All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	<linux-crypto@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwrng: hisi - use dev_err_probe
Date: Tue, 27 Feb 2024 12:20:46 +0000	[thread overview]
Message-ID: <20240227122046.00006c97@Huawei.com> (raw)
In-Reply-To: <20240226185700.39411-1-martin@kaiser.cx>

On Mon, 26 Feb 2024 19:57:00 +0100
Martin Kaiser <martin@kaiser.cx> wrote:

> Replace dev_err + return with dev_err_probe.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Maybe worth wrapping the line in this subsystem still strives for
<= 80 chars


> ---
>  drivers/char/hw_random/hisi-rng.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/char/hw_random/hisi-rng.c b/drivers/char/hw_random/hisi-rng.c
> index b6f27566e0ba..4e501d5c121f 100644
> --- a/drivers/char/hw_random/hisi-rng.c
> +++ b/drivers/char/hw_random/hisi-rng.c
> @@ -89,10 +89,8 @@ static int hisi_rng_probe(struct platform_device *pdev)
>  	rng->rng.read = hisi_rng_read;
>  
>  	ret = devm_hwrng_register(&pdev->dev, &rng->rng);
> -	if (ret) {
> -		dev_err(&pdev->dev, "failed to register hwrng\n");
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(&pdev->dev, ret, "failed to register hwrng\n");


















>  
>  	return 0;
>  }


WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	<linux-crypto@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwrng: hisi - use dev_err_probe
Date: Tue, 27 Feb 2024 12:20:46 +0000	[thread overview]
Message-ID: <20240227122046.00006c97@Huawei.com> (raw)
In-Reply-To: <20240226185700.39411-1-martin@kaiser.cx>

On Mon, 26 Feb 2024 19:57:00 +0100
Martin Kaiser <martin@kaiser.cx> wrote:

> Replace dev_err + return with dev_err_probe.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Maybe worth wrapping the line in this subsystem still strives for
<= 80 chars


> ---
>  drivers/char/hw_random/hisi-rng.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/char/hw_random/hisi-rng.c b/drivers/char/hw_random/hisi-rng.c
> index b6f27566e0ba..4e501d5c121f 100644
> --- a/drivers/char/hw_random/hisi-rng.c
> +++ b/drivers/char/hw_random/hisi-rng.c
> @@ -89,10 +89,8 @@ static int hisi_rng_probe(struct platform_device *pdev)
>  	rng->rng.read = hisi_rng_read;
>  
>  	ret = devm_hwrng_register(&pdev->dev, &rng->rng);
> -	if (ret) {
> -		dev_err(&pdev->dev, "failed to register hwrng\n");
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(&pdev->dev, ret, "failed to register hwrng\n");


















>  
>  	return 0;
>  }


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-02-27 12:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-26 18:57 [PATCH] hwrng: hisi - use dev_err_probe Martin Kaiser
2024-02-26 18:57 ` Martin Kaiser
2024-02-27 12:20 ` Jonathan Cameron [this message]
2024-02-27 12:20   ` Jonathan Cameron
2024-03-08 11:24 ` Herbert Xu
2024-03-08 11:24   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240227122046.00006c97@Huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin@kaiser.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.