Re: [PATCH V6 5/6] arm64: dts: imx8mp: add HDMI display pipeline

From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Adam Ford <aford173@gmail.com>
Cc: Marco Felsch <m.felsch@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-phy@lists.infradead.org, Marek Vasut <marex@denx.de>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Will Deacon <will@kernel.org>, Rob Herring <robh@kernel.org>,
	imx@lists.linux.dev, Sascha Hauer <s.hauer@pengutronix.de>,
	aford@beaconembedded.com, linux-kernel@vger.kernel.org,
	Vinod Koul <vkoul@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Shawn Guo <shawnguo@kernel.org>,
	devicetree@vger.kernel.org, Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [PATCH V6 5/6] arm64: dts: imx8mp: add HDMI display pipeline
Date: Tue, 27 Feb 2024 18:23:46 +0100	[thread overview]
Message-ID: <20240227182346.6e67cc88@booty> (raw)
In-Reply-To: <CAHCN7xKnEvrfYMZau95e7aknTkdqrQLfgWZTfb6mS3Yt5BT6+Q@mail.gmail.com>

On Tue, 27 Feb 2024 07:51:58 -0600
Adam Ford <aford173@gmail.com> wrote:

> On Tue, Feb 27, 2024 at 2:33 AM Marco Felsch <m.felsch@pengutronix.de> wrote:
> >
> > Hi Adam,
> >
> > thanks a lot for pushing this topic.
> >
> > On 24-02-26, Adam Ford wrote:  
> > > From: Lucas Stach <l.stach@pengutronix.de>
> > >
> > > This adds the DT nodes for all the peripherals that make up the
> > > HDMI display pipeline.
> > >
> > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > > Signed-off-by: Adam Ford <aford173@gmail.com>
> > > Tested-by: Marek Vasut <marex@denx.de>
> > > Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> > > ---
> > > V6:  Make LCDIF3 disabled by default
> > >
> > > V5:  No change
> > >
> > > V3:  Re-ordered the HDMI parts to properly come after irqstree_hdmi
> > >      inside AIPS4.  Change size of LCDIF3 and PVI to match TRM sizes
> > >      of 4KB.
> > >
> > > V2:  I took this from Lucas' original submission with the following:
> > >      Removed extra clock from HDMI-TX since it is now part of the
> > >      power domain
> > >      Added interrupt-parent to PVI
> > >      Changed the name of the HDMI tranmitter to fsl,imx8mp-hdmi-tx
> > >      Added ports to HDMI-tx
> > > ---
> > >  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 95 +++++++++++++++++++++++
> > >  1 file changed, 95 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > > index 18bfa7d9aa7f..637b0265b0f1 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > > @@ -1940,6 +1940,101 @@ irqsteer_hdmi: interrupt-controller@32fc2000 {
> > >                               clock-names = "ipg";
> > >                               power-domains = <&hdmi_blk_ctrl IMX8MP_HDMIBLK_PD_IRQSTEER>;
> > >                       };
> > > +
> > > +                     hdmi_pvi: display-bridge@32fc4000 {
> > > +                             compatible = "fsl,imx8mp-hdmi-pvi";
> > > +                             reg = <0x32fc4000 0x1000>;
> > > +                             interrupt-parent = <&irqsteer_hdmi>;
> > > +                             interrupts = <12>;
> > > +                             power-domains = <&hdmi_blk_ctrl IMX8MP_HDMIBLK_PD_PVI>;  
> >
> > this node should be 'status = "disabled";' as reported by Luca else this
> > node will EPROBE_DEFER. With that beeing fixed you can add my:  
> 
> sorry I missed that one...and I though I was done...sigh.  I hope it's
> not too late to get this into the next release.
> >
> > Tested-by: Marco Felsch <m.felsch@pengutronix.de>
> >  
> 
> I'll push a V7 tonight and add your tested-by.  Thanks for testing.

And with that fixed you can add to v7:

 Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com