* [kvm-unit-tests PATCH] arm64: Improve unhandled exception traces
@ 2024-02-27 19:09 Andrew Jones
2024-03-18 16:47 ` Andrew Jones
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Jones @ 2024-02-27 19:09 UTC (permalink / raw)
To: kvmarm; +Cc: alexandru.elisei, eric.auger
Put the stack trace at the bottom, rather than mixing it with
register dumps, and also start the trace from the current PC.
Signed-off-by: Andrew Jones <andrew.jones@linux.dev>
---
lib/arm64/processor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/arm64/processor.c b/lib/arm64/processor.c
index 5bcad679605e..06fd7cfcc548 100644
--- a/lib/arm64/processor.c
+++ b/lib/arm64/processor.c
@@ -130,9 +130,9 @@ static void bad_exception(enum vector v, struct pt_regs *regs,
printf("Vector: %d (%s)\n", v, vector_names[v]);
printf("ESR_EL1: %8s%08x, ec=%#x (%s)\n", "", esr, ec, ec_names[ec]);
printf("FAR_EL1: %016lx (%svalid)\n", far, far_valid ? "" : "not ");
- dump_stack();
printf("Exception frame registers:\n");
show_regs(regs);
+ dump_frame_stack((void *)regs->pc, (void *)regs->regs[29]);
abort();
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [kvm-unit-tests PATCH] arm64: Improve unhandled exception traces
2024-02-27 19:09 [kvm-unit-tests PATCH] arm64: Improve unhandled exception traces Andrew Jones
@ 2024-03-18 16:47 ` Andrew Jones
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Jones @ 2024-03-18 16:47 UTC (permalink / raw)
To: Andrew Jones; +Cc: kvmarm, alexandru.elisei, eric.auger
On Tue, Feb 27, 2024 at 08:09:36PM +0100, Andrew Jones wrote:
> Put the stack trace at the bottom, rather than mixing it with
> register dumps, and also start the trace from the current PC.
>
> Signed-off-by: Andrew Jones <andrew.jones@linux.dev>
> ---
> lib/arm64/processor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/arm64/processor.c b/lib/arm64/processor.c
> index 5bcad679605e..06fd7cfcc548 100644
> --- a/lib/arm64/processor.c
> +++ b/lib/arm64/processor.c
> @@ -130,9 +130,9 @@ static void bad_exception(enum vector v, struct pt_regs *regs,
> printf("Vector: %d (%s)\n", v, vector_names[v]);
> printf("ESR_EL1: %8s%08x, ec=%#x (%s)\n", "", esr, ec, ec_names[ec]);
> printf("FAR_EL1: %016lx (%svalid)\n", far, far_valid ? "" : "not ");
> - dump_stack();
> printf("Exception frame registers:\n");
> show_regs(regs);
> + dump_frame_stack((void *)regs->pc, (void *)regs->regs[29]);
> abort();
> }
>
> --
> 2.43.0
>
Merged.
Thanks,
drew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-18 16:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-27 19:09 [kvm-unit-tests PATCH] arm64: Improve unhandled exception traces Andrew Jones
2024-03-18 16:47 ` Andrew Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.