All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/2] drm: Add plane SIZE_HINTS property
@ 2024-02-27 19:35 Ville Syrjala
  2024-02-27 19:35 ` [PATCH v2 1/2] drm: Introduce " Ville Syrjala
                   ` (4 more replies)
  0 siblings, 5 replies; 23+ messages in thread
From: Ville Syrjala @ 2024-02-27 19:35 UTC (permalink / raw)
  To: dri-devel
  Cc: intel-gfx, Simon Ser, Jonas Ådahl, Daniel Stone,
	Sameer Lattannavar, Sebastian Wick, Harry Wentland,
	Pekka Paalanen

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Final version for a new plane SIZE_HINTS property to
essentially replace the cursor size caps, based on recent
discussion in this gitlab bug:
https://gitlab.freedesktop.org/drm/intel/-/issues/7687

As for userspace, so far I only did a quick modetest
blob decoder (mainly to verify that it looks correct):
https://gitlab.freedesktop.org/vsyrjala/libdrm/-/commits/plane_size_hints

Sameer & co. have done a real mutter implementation:
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3165

This final version follows the original idea of having
just a list of sizes in a blob, rather than the mode
complex "2D bitmap" approach I also proposed later.
I think that's fair, the bitmap was probably overly
complicated.

The only difference to the previous version of this approach
is that the documentation now states that the list is sorted
in order of preference, and thus userspace should pick the
first suitable size from the list. This should match the
aforementioned mutter implementation.

Cc: Simon Ser <contact@emersion.fr>
Cc: Jonas Ådahl <jadahl@redhat.com>
Cc: Daniel Stone <daniel@fooishbar.org>
Cc: Sameer Lattannavar <sameer.lattannavar@intel.com>
Cc: Sebastian Wick <sebastian.wick@redhat.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Pekka Paalanen <pekka.paalanen@collabora.com>

Ville Syrjälä (2):
  drm: Introduce plane SIZE_HINTS property
  drm/i915: Add SIZE_HINTS property for cursors

 drivers/gpu/drm/drm_mode_config.c           |  7 +++
 drivers/gpu/drm/drm_plane.c                 | 52 +++++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_cursor.c | 24 ++++++++++
 include/drm/drm_mode_config.h               |  5 ++
 include/drm/drm_plane.h                     |  4 ++
 include/uapi/drm/drm_mode.h                 | 11 +++++
 6 files changed, 103 insertions(+)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 23+ messages in thread
* [Intel-gfx] [PATCH 1/2] drm: Introduce plane SIZE_HINTS property
@ 2023-02-08  4:09 Ville Syrjala
  2023-02-08 21:10 ` [PATCH v2 " Ville Syrjala
  0 siblings, 1 reply; 23+ messages in thread
From: Ville Syrjala @ 2023-02-08  4:09 UTC (permalink / raw)
  To: dri-devel
  Cc: Simon Ser, intel-gfx, Pekka Paalanen, Jonas Ådahl,
	Daniel Stone

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Add a new immutable plane property by which a plane can advertise
a handful of recommended plane sizes. This would be mostly exposed
by cursor planes as a slightly more capable replacement for
the DRM_CAP_CURSOR_WIDTH/HEIGHT caps, which can only declare
a one size fits all limit for the whole device.

Currently eg. amdgpu/i915/nouveau just advertize the max cursor
size via the cursor size caps. But always using the max sized
cursor can waste a surprising amount of power, so a better
stragey is desirable.

Most other drivers don't specify any cursor size at all, in
which case the ioctl code just claims that 64x64 is a great
choice. Whether that is actually true is debatable.

A poll of various compositor developers informs us that
blindly probing with setcursor/atomic ioctl to determine
suitable cursor sizes is not acceptable, thus the
introduction of the new property to supplant the cursor
size caps. The compositor will now be free to select a
more optimal cursor size from the short list of options.

Note that the reported sizes (either via the property or the
caps) make no claims about things such as plane scaling. So
these things should only really be consulted for simple
"cursor like" use cases.

Cc: Simon Ser <contact@emersion.fr>
Cc: Jonas Ådahl <jadahl@redhat.com>
Cc: Daniel Stone <daniel@fooishbar.org>
Cc: Pekka Paalanen <pekka.paalanen@collabora.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/drm_mode_config.c |  7 +++++++
 drivers/gpu/drm/drm_plane.c       | 33 +++++++++++++++++++++++++++++++
 include/drm/drm_mode_config.h     |  5 +++++
 include/drm/drm_plane.h           |  4 ++++
 include/uapi/drm/drm_mode.h       |  5 +++++
 5 files changed, 54 insertions(+)

diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c
index 87eb591fe9b5..21860f94a18c 100644
--- a/drivers/gpu/drm/drm_mode_config.c
+++ b/drivers/gpu/drm/drm_mode_config.c
@@ -374,6 +374,13 @@ static int drm_mode_create_standard_properties(struct drm_device *dev)
 		return -ENOMEM;
 	dev->mode_config.modifiers_property = prop;
 
+	prop = drm_property_create(dev,
+				   DRM_MODE_PROP_IMMUTABLE | DRM_MODE_PROP_BLOB,
+				   "SIZE_HINTS", 0);
+	if (!prop)
+		return -ENOMEM;
+	dev->mode_config.size_hints_property = prop;
+
 	return 0;
 }
 
diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c
index 24e7998d1731..d0a277f4be1f 100644
--- a/drivers/gpu/drm/drm_plane.c
+++ b/drivers/gpu/drm/drm_plane.c
@@ -1582,3 +1582,36 @@ int drm_plane_create_scaling_filter_property(struct drm_plane *plane,
 	return 0;
 }
 EXPORT_SYMBOL(drm_plane_create_scaling_filter_property);
+
+/**
+ * drm_plane_add_size_hint_property - create a size hint property
+ *
+ * @plane: drm plane
+ * @hints: size hints
+ * @num_hints: number of size hints
+ *
+ * Create a size hints property for the plane.
+ *
+ * RETURNS:
+ * Zero for success or -errno
+ */
+int drm_plane_add_size_hints_property(struct drm_plane *plane,
+				      const struct drm_plane_size_hint *hints,
+				      int num_hints)
+{
+	struct drm_device *dev = plane->dev;
+	struct drm_mode_config *config = &dev->mode_config;
+	struct drm_property_blob *blob;
+
+	blob = drm_property_create_blob(dev,
+					array_size(sizeof(hints[0]), num_hints),
+					hints);
+	if (IS_ERR(blob))
+		return PTR_ERR(blob);
+
+	drm_object_attach_property(&plane->base, config->size_hints_property,
+				   blob->base.id);
+
+	return 0;
+}
+EXPORT_SYMBOL(drm_plane_add_size_hints_property);
diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
index e5b053001d22..ed9f6938dca1 100644
--- a/include/drm/drm_mode_config.h
+++ b/include/drm/drm_mode_config.h
@@ -949,6 +949,11 @@ struct drm_mode_config {
 	 */
 	struct drm_property *modifiers_property;
 
+	/**
+	 * @size_hints_property: Plane SIZE_HINTS property.
+	 */
+	struct drm_property *size_hints_property;
+
 	/* cursor size */
 	uint32_t cursor_width, cursor_height;
 
diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h
index 51291983ea44..1997d7d64b69 100644
--- a/include/drm/drm_plane.h
+++ b/include/drm/drm_plane.h
@@ -32,6 +32,7 @@
 #include <drm/drm_util.h>
 
 struct drm_crtc;
+struct drm_plane_size_hint;
 struct drm_printer;
 struct drm_modeset_acquire_ctx;
 
@@ -945,5 +946,8 @@ drm_plane_get_damage_clips(const struct drm_plane_state *state);
 
 int drm_plane_create_scaling_filter_property(struct drm_plane *plane,
 					     unsigned int supported_filters);
+int drm_plane_add_size_hints_property(struct drm_plane *plane,
+				      const struct drm_plane_size_hint *hints,
+				      int num_hints);
 
 #endif
diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
index 46becedf5b2f..4f0551d7f481 100644
--- a/include/uapi/drm/drm_mode.h
+++ b/include/uapi/drm/drm_mode.h
@@ -849,6 +849,11 @@ struct drm_color_lut {
 	__u16 reserved;
 };
 
+struct drm_plane_size_hint {
+	__u16 width;
+	__u16 height;
+};
+
 /**
  * struct hdr_metadata_infoframe - HDR Metadata Infoframe Data.
  *
-- 
2.39.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread
end of thread, other threads:[~2024-03-15 17:04 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-27 19:35 [PATCH v2 0/2] drm: Add plane SIZE_HINTS property Ville Syrjala
2024-02-27 19:35 ` [PATCH v2 1/2] drm: Introduce " Ville Syrjala
2024-02-27 20:32   ` Sebastian Wick
2024-02-28 10:12   ` Simon Ser
2024-03-15 17:03     ` Ville Syrjälä
2024-02-28 10:28   ` Daniel Stone
2024-02-27 19:35 ` [PATCH v2 2/2] drm/i915: Add SIZE_HINTS property for cursors Ville Syrjala
2024-02-27 20:12 ` ✗ Fi.CI.SPARSE: warning for drm: Add plane SIZE_HINTS property (rev5) Patchwork
2024-02-27 20:24 ` ✓ Fi.CI.BAT: success " Patchwork
2024-02-28 12:01 ` ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2023-02-08  4:09 [Intel-gfx] [PATCH 1/2] drm: Introduce plane SIZE_HINTS property Ville Syrjala
2023-02-08 21:10 ` [PATCH v2 " Ville Syrjala
2023-02-09 11:58   ` Pekka Paalanen
2023-02-09 13:10     ` Ville Syrjälä
2023-02-10  9:44       ` Pekka Paalanen
2023-02-09 14:16   ` Jonas Ådahl
2023-02-14  9:25     ` Ville Syrjälä
2023-02-14  9:54       ` Jonas Ådahl
2023-02-14 10:28         ` Ville Syrjälä
2023-02-14 11:01           ` Jonas Ådahl
2023-02-14 11:19             ` Ville Syrjälä
2023-02-22 18:34               ` Ville Syrjälä
2023-02-14 19:27           ` Harry Wentland
2023-02-14 19:59             ` Ville Syrjälä

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.