From: Jesper Nilsson <jesper.nilsson@axis.com>
To: "Uwe Kleine-König" <ukleinek@debian.org>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Lei Chuanhua" <lchuanhua@maxlinear.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Jesper Nilsson" <jesper.nilsson@axis.com>,
"Nobuhiro Iwamatsu" <nobuhiro1.iwamatsu@toshiba.co.jp>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Rob Herring" <robh@kernel.org>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2] PCI: dw-rockchip: Add error messages in .probe()s error paths
Date: Wed, 28 Feb 2024 10:52:28 +0100 [thread overview]
Message-ID: <20240228095228.GF30969@axis.com> (raw)
In-Reply-To: <20240227141256.413055-2-ukleinek@debian.org>
On Tue, Feb 27, 2024 at 03:12:54PM +0100, Uwe Kleine-König wrote:
> Drivers that silently fail to probe provide a bad user experience and
> make it unnecessarily hard to debug such a failure. Fix it by using
> dev_err_probe() instead of a plain return.
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Uwe Kleine-König <ukleinek@debian.org>
Reviewed-by: Jesper Nilsson <jesper.nilsson@axis.com>
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
WARNING: multiple messages have this Message-ID (diff)
From: Jesper Nilsson <jesper.nilsson@axis.com>
To: "Uwe Kleine-König" <ukleinek@debian.org>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Lei Chuanhua" <lchuanhua@maxlinear.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Jesper Nilsson" <jesper.nilsson@axis.com>,
"Nobuhiro Iwamatsu" <nobuhiro1.iwamatsu@toshiba.co.jp>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Rob Herring" <robh@kernel.org>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2] PCI: dw-rockchip: Add error messages in .probe()s error paths
Date: Wed, 28 Feb 2024 10:52:28 +0100 [thread overview]
Message-ID: <20240228095228.GF30969@axis.com> (raw)
In-Reply-To: <20240227141256.413055-2-ukleinek@debian.org>
On Tue, Feb 27, 2024 at 03:12:54PM +0100, Uwe Kleine-König wrote:
> Drivers that silently fail to probe provide a bad user experience and
> make it unnecessarily hard to debug such a failure. Fix it by using
> dev_err_probe() instead of a plain return.
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Uwe Kleine-König <ukleinek@debian.org>
Reviewed-by: Jesper Nilsson <jesper.nilsson@axis.com>
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Jesper Nilsson <jesper.nilsson@axis.com>
To: "Uwe Kleine-König" <ukleinek@debian.org>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Lei Chuanhua" <lchuanhua@maxlinear.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Jesper Nilsson" <jesper.nilsson@axis.com>,
"Nobuhiro Iwamatsu" <nobuhiro1.iwamatsu@toshiba.co.jp>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Rob Herring" <robh@kernel.org>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2] PCI: dw-rockchip: Add error messages in .probe()s error paths
Date: Wed, 28 Feb 2024 10:52:28 +0100 [thread overview]
Message-ID: <20240228095228.GF30969@axis.com> (raw)
In-Reply-To: <20240227141256.413055-2-ukleinek@debian.org>
On Tue, Feb 27, 2024 at 03:12:54PM +0100, Uwe Kleine-König wrote:
> Drivers that silently fail to probe provide a bad user experience and
> make it unnecessarily hard to debug such a failure. Fix it by using
> dev_err_probe() instead of a plain return.
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Uwe Kleine-König <ukleinek@debian.org>
Reviewed-by: Jesper Nilsson <jesper.nilsson@axis.com>
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-28 9:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 14:12 [PATCH v2] PCI: dw-rockchip: Add error messages in .probe()s error paths Uwe Kleine-König
2024-02-27 14:12 ` Uwe Kleine-König
2024-02-27 14:12 ` Uwe Kleine-König
2024-02-28 9:52 ` Jesper Nilsson [this message]
2024-02-28 9:52 ` Jesper Nilsson
2024-02-28 9:52 ` Jesper Nilsson
2024-03-10 13:10 ` Manivannan Sadhasivam
2024-03-10 13:10 ` Manivannan Sadhasivam
2024-03-10 13:10 ` Manivannan Sadhasivam
2024-05-15 20:57 ` Bjorn Helgaas
2024-05-15 20:57 ` Bjorn Helgaas
2024-05-15 20:57 ` Bjorn Helgaas
2024-05-15 21:13 ` Bjorn Helgaas
2024-05-15 21:13 ` Bjorn Helgaas
2024-05-15 21:13 ` Bjorn Helgaas
2024-05-17 11:18 ` Krzysztof Wilczyński
2024-05-17 11:18 ` Krzysztof Wilczyński
2024-05-17 11:18 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228095228.GF30969@axis.com \
--to=jesper.nilsson@axis.com \
--cc=bhelgaas@google.com \
--cc=dlemoal@kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=heiko@sntech.de \
--cc=kw@linux.com \
--cc=lchuanhua@maxlinear.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=robh@kernel.org \
--cc=ukleinek@debian.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.