All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Alexander Stein <alexander.stein@ew.tq-group.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] media: dt-bindings: nxp,imx8-isi: Allow single port for single pipeline models
Date: Fri, 1 Mar 2024 15:11:07 -0600	[thread overview]
Message-ID: <20240301211107.GA3037358-robh@kernel.org> (raw)
In-Reply-To: <20240223141731.GB1313@pendragon.ideasonboard.com>

On Fri, Feb 23, 2024 at 04:17:31PM +0200, Laurent Pinchart wrote:
> On Fri, Feb 23, 2024 at 04:16:31PM +0200, Laurent Pinchart wrote:
> > Hi Alexander,
> > 
> > Thank you for the patch.
> > 
> > On Fri, Feb 23, 2024 at 03:04:44PM +0100, Alexander Stein wrote:
> > > In case the hardware only supports just one pipeline, allow using a
> > > single port node as well.
> > 
> > This is frowned upon in DT bindings, as it makes them more complicated
> > for little gain. The recommendation is to always use a ports node if a
> > device can have multiple ports for at least one of its compatibles.
> 
> And reading the cover letter, I see this causes warnings. I think we
> need guidance from Rob on this.

The warning is for:

ports {
  port@0 {};
};

It should/could be changed like this to fix it:

ports {
  port {};
};

But I've also said some warnings are guidance, not absolute. This is one 
of them. Some devices have optional port@1. In those cases, switching 
between 'port' and 'port@0' depending on 'port@1' makes little sense.

Rob 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Alexander Stein <alexander.stein@ew.tq-group.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] media: dt-bindings: nxp,imx8-isi: Allow single port for single pipeline models
Date: Fri, 1 Mar 2024 15:11:07 -0600	[thread overview]
Message-ID: <20240301211107.GA3037358-robh@kernel.org> (raw)
In-Reply-To: <20240223141731.GB1313@pendragon.ideasonboard.com>

On Fri, Feb 23, 2024 at 04:17:31PM +0200, Laurent Pinchart wrote:
> On Fri, Feb 23, 2024 at 04:16:31PM +0200, Laurent Pinchart wrote:
> > Hi Alexander,
> > 
> > Thank you for the patch.
> > 
> > On Fri, Feb 23, 2024 at 03:04:44PM +0100, Alexander Stein wrote:
> > > In case the hardware only supports just one pipeline, allow using a
> > > single port node as well.
> > 
> > This is frowned upon in DT bindings, as it makes them more complicated
> > for little gain. The recommendation is to always use a ports node if a
> > device can have multiple ports for at least one of its compatibles.
> 
> And reading the cover letter, I see this causes warnings. I think we
> need guidance from Rob on this.

The warning is for:

ports {
  port@0 {};
};

It should/could be changed like this to fix it:

ports {
  port {};
};

But I've also said some warnings are guidance, not absolute. This is one 
of them. Some devices have optional port@1. In those cases, switching 
between 'port' and 'port@0' depending on 'port@1' makes little sense.

Rob 

  parent reply	other threads:[~2024-03-01 21:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 14:04 [PATCH 0/3] i.MX8M Nano ISI single port support Alexander Stein
2024-02-23 14:04 ` Alexander Stein
2024-02-23 14:04 ` [PATCH 1/3] media: dt-bindings: nxp,imx8-isi: Refuse port@1 for single pipeline models Alexander Stein
2024-02-23 14:04   ` Alexander Stein
2024-02-29 18:05   ` Krzysztof Kozlowski
2024-02-29 18:05     ` Krzysztof Kozlowski
2024-02-23 14:04 ` [PATCH 2/3] media: dt-bindings: nxp,imx8-isi: Allow single port " Alexander Stein
2024-02-23 14:04   ` Alexander Stein
2024-02-23 14:16   ` Laurent Pinchart
2024-02-23 14:16     ` Laurent Pinchart
2024-02-23 14:17     ` Laurent Pinchart
2024-02-23 14:17       ` Laurent Pinchart
2024-02-29 18:14       ` Krzysztof Kozlowski
2024-02-29 18:14         ` Krzysztof Kozlowski
2024-02-29 18:18         ` Krzysztof Kozlowski
2024-02-29 18:18           ` Krzysztof Kozlowski
2024-03-01  8:32           ` [PATCH 2/3] media: dt-bindings: nxp, imx8-isi: " Alexander Stein
2024-03-01  8:32             ` Alexander Stein
2024-03-01  8:49             ` Krzysztof Kozlowski
2024-03-01  8:49               ` Krzysztof Kozlowski
2024-03-01 21:11       ` Rob Herring [this message]
2024-03-01 21:11         ` [PATCH 2/3] media: dt-bindings: nxp,imx8-isi: " Rob Herring
2024-02-23 14:04 ` [PATCH 3/3] arm64: dts: imx8mn: Use single port for ISI Alexander Stein
2024-02-23 14:04   ` Alexander Stein
     [not found]   ` <CAHCN7xJ7uGXL6BF7CCvtqVQHy8X+x5nxJc+HS2_Mkd=EBT2g5Q@mail.gmail.com>
2024-02-29 18:15     ` Krzysztof Kozlowski
2024-02-29 18:15       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240301211107.GA3037358-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.