* [Intel-wired-lan] [PATCH iwl-net v1] ice: fix typo in assignment
@ 2024-03-05 0:37 ` Jesse Brandeburg
0 siblings, 0 replies; 6+ messages in thread
From: Jesse Brandeburg @ 2024-03-05 0:37 UTC (permalink / raw)
To: intel-wired-lan
Cc: Wojciech Drewek, netdev, Eric Dumazet, Tony Nguyen,
Michal Swiatkowski, Jakub Kicinski, Paolo Abeni, David S. Miller
Fix an obviously incorrect assignment, created with a typo or cut-n-paste
error.
Fixes: 5995ef88e3a8 ("ice: realloc VSI stats arrays")
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
---
drivers/net/ethernet/intel/ice/ice_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
index 097bf8fd6bf0..fc23dbe302b4 100644
--- a/drivers/net/ethernet/intel/ice/ice_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_lib.c
@@ -3192,7 +3192,7 @@ ice_vsi_realloc_stat_arrays(struct ice_vsi *vsi)
}
}
- tx_ring_stats = vsi_stat->rx_ring_stats;
+ tx_ring_stats = vsi_stat->tx_ring_stats;
vsi_stat->tx_ring_stats =
krealloc_array(vsi_stat->tx_ring_stats, req_txq,
sizeof(*vsi_stat->tx_ring_stats),
base-commit: 948abb59ebd3892c425165efd8fb2f5954db8de7
--
2.39.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH iwl-net v1] ice: fix typo in assignment
@ 2024-03-05 0:37 ` Jesse Brandeburg
0 siblings, 0 replies; 6+ messages in thread
From: Jesse Brandeburg @ 2024-03-05 0:37 UTC (permalink / raw)
To: intel-wired-lan
Cc: Jesse Brandeburg, netdev, Tony Nguyen, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Michal Swiatkowski,
Wojciech Drewek
Fix an obviously incorrect assignment, created with a typo or cut-n-paste
error.
Fixes: 5995ef88e3a8 ("ice: realloc VSI stats arrays")
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
---
drivers/net/ethernet/intel/ice/ice_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
index 097bf8fd6bf0..fc23dbe302b4 100644
--- a/drivers/net/ethernet/intel/ice/ice_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_lib.c
@@ -3192,7 +3192,7 @@ ice_vsi_realloc_stat_arrays(struct ice_vsi *vsi)
}
}
- tx_ring_stats = vsi_stat->rx_ring_stats;
+ tx_ring_stats = vsi_stat->tx_ring_stats;
vsi_stat->tx_ring_stats =
krealloc_array(vsi_stat->tx_ring_stats, req_txq,
sizeof(*vsi_stat->tx_ring_stats),
base-commit: 948abb59ebd3892c425165efd8fb2f5954db8de7
--
2.39.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix typo in assignment
2024-03-05 0:37 ` Jesse Brandeburg
@ 2024-03-05 12:21 ` Simon Horman
-1 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2024-03-05 12:21 UTC (permalink / raw)
To: Jesse Brandeburg
Cc: Michal Swiatkowski, Wojciech Drewek, netdev, Eric Dumazet,
Tony Nguyen, Jakub Kicinski, intel-wired-lan, Paolo Abeni,
David S. Miller
On Mon, Mar 04, 2024 at 04:37:07PM -0800, Jesse Brandeburg wrote:
> Fix an obviously incorrect assignment, created with a typo or cut-n-paste
> error.
>
> Fixes: 5995ef88e3a8 ("ice: realloc VSI stats arrays")
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH iwl-net v1] ice: fix typo in assignment
@ 2024-03-05 12:21 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2024-03-05 12:21 UTC (permalink / raw)
To: Jesse Brandeburg
Cc: intel-wired-lan, netdev, Tony Nguyen, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Michal Swiatkowski,
Wojciech Drewek
On Mon, Mar 04, 2024 at 04:37:07PM -0800, Jesse Brandeburg wrote:
> Fix an obviously incorrect assignment, created with a typo or cut-n-paste
> error.
>
> Fixes: 5995ef88e3a8 ("ice: realloc VSI stats arrays")
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix typo in assignment
2024-03-05 0:37 ` Jesse Brandeburg
@ 2024-03-05 12:27 ` Paul Menzel
-1 siblings, 0 replies; 6+ messages in thread
From: Paul Menzel @ 2024-03-05 12:27 UTC (permalink / raw)
To: Jesse Brandeburg
Cc: Paolo Abeni, Wojciech Drewek, netdev, Eric Dumazet, Tony Nguyen,
Jakub Kicinski, Michal Swiatkowski, intel-wired-lan,
David S. Miller
Dear Jesse,
Thank you for your patch.
Am 05.03.24 um 01:37 schrieb Jesse Brandeburg:
> Fix an obviously incorrect assignment, created with a typo or cut-n-paste
> error.
It’s probably just me, but with these one letter typos I still have to
search the diff two or three times to spot the typo. Maybe even use
(next time) as commit message summary:
ice: Assign tx ring stats value to tx stats and not rx ones
> Fixes: 5995ef88e3a8 ("ice: realloc VSI stats arrays")
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
> index 097bf8fd6bf0..fc23dbe302b4 100644
> --- a/drivers/net/ethernet/intel/ice/ice_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_lib.c
> @@ -3192,7 +3192,7 @@ ice_vsi_realloc_stat_arrays(struct ice_vsi *vsi)
> }
> }
>
> - tx_ring_stats = vsi_stat->rx_ring_stats;
> + tx_ring_stats = vsi_stat->tx_ring_stats;
> vsi_stat->tx_ring_stats =
> krealloc_array(vsi_stat->tx_ring_stats, req_txq,
> sizeof(*vsi_stat->tx_ring_stats),
>
> base-commit: 948abb59ebd3892c425165efd8fb2f5954db8de7
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix typo in assignment
@ 2024-03-05 12:27 ` Paul Menzel
0 siblings, 0 replies; 6+ messages in thread
From: Paul Menzel @ 2024-03-05 12:27 UTC (permalink / raw)
To: Jesse Brandeburg
Cc: intel-wired-lan, Wojciech Drewek, netdev, Eric Dumazet,
Tony Nguyen, Michal Swiatkowski, Jakub Kicinski, Paolo Abeni,
David S. Miller
Dear Jesse,
Thank you for your patch.
Am 05.03.24 um 01:37 schrieb Jesse Brandeburg:
> Fix an obviously incorrect assignment, created with a typo or cut-n-paste
> error.
It’s probably just me, but with these one letter typos I still have to
search the diff two or three times to spot the typo. Maybe even use
(next time) as commit message summary:
ice: Assign tx ring stats value to tx stats and not rx ones
> Fixes: 5995ef88e3a8 ("ice: realloc VSI stats arrays")
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
> index 097bf8fd6bf0..fc23dbe302b4 100644
> --- a/drivers/net/ethernet/intel/ice/ice_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_lib.c
> @@ -3192,7 +3192,7 @@ ice_vsi_realloc_stat_arrays(struct ice_vsi *vsi)
> }
> }
>
> - tx_ring_stats = vsi_stat->rx_ring_stats;
> + tx_ring_stats = vsi_stat->tx_ring_stats;
> vsi_stat->tx_ring_stats =
> krealloc_array(vsi_stat->tx_ring_stats, req_txq,
> sizeof(*vsi_stat->tx_ring_stats),
>
> base-commit: 948abb59ebd3892c425165efd8fb2f5954db8de7
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-03-05 12:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-05 0:37 [Intel-wired-lan] [PATCH iwl-net v1] ice: fix typo in assignment Jesse Brandeburg
2024-03-05 0:37 ` Jesse Brandeburg
2024-03-05 12:21 ` [Intel-wired-lan] " Simon Horman
2024-03-05 12:21 ` Simon Horman
2024-03-05 12:27 ` [Intel-wired-lan] " Paul Menzel
2024-03-05 12:27 ` Paul Menzel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.