From: Christoph Hellwig <hch@lst.de>
To: Philipp Reisner <philipp.reisner@linbit.com>
Cc: "Christoph Hellwig" <hch@lst.de>,
"Lars Ellenberg" <lars.ellenberg@linbit.com>,
"Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>,
drbd-dev@lists.linbit.com, linux-block@vger.kernel.org
Subject: Re: drbd queue limits conversion ping
Date: Tue, 5 Mar 2024 14:38:12 +0100 [thread overview]
Message-ID: <20240305133812.GA1345@lst.de> (raw)
In-Reply-To: <CADGDV=WJWZHj89rebvNJ2BOhuqG=_Nr5S3+QXp6LTEGGKyzuKQ@mail.gmail.com>
On Tue, Mar 05, 2024 at 10:39:55AM +0100, Philipp Reisner wrote:
> Christoph,
>
> we are fine with the queue limit conversion as you did it. Lars and I
> reviewed it, and Christoph ran the tests. All fine.
Can you provide formal Reviewed-by and Tested-by tags? I'll resend the
patches standalone, maybe reply to those.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Philipp Reisner <philipp.reisner@linbit.com>
Cc: linux-block@vger.kernel.org,
Lars Ellenberg <lars.ellenberg@linbit.com>,
Christoph Hellwig <hch@lst.de>,
drbd-dev@lists.linbit.com
Subject: Re: drbd queue limits conversion ping
Date: Tue, 5 Mar 2024 14:38:12 +0100 [thread overview]
Message-ID: <20240305133812.GA1345@lst.de> (raw)
In-Reply-To: <CADGDV=WJWZHj89rebvNJ2BOhuqG=_Nr5S3+QXp6LTEGGKyzuKQ@mail.gmail.com>
On Tue, Mar 05, 2024 at 10:39:55AM +0100, Philipp Reisner wrote:
> Christoph,
>
> we are fine with the queue limit conversion as you did it. Lars and I
> reviewed it, and Christoph ran the tests. All fine.
Can you provide formal Reviewed-by and Tested-by tags? I'll resend the
patches standalone, maybe reply to those.
next prev parent reply other threads:[~2024-03-05 13:38 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 10:29 atomic queue limit updates for stackable devices v2 Christoph Hellwig
2024-02-26 10:29 ` Christoph Hellwig
2024-02-26 10:29 ` [PATCH 01/16] block: add a queue_limits_set helper Christoph Hellwig
2024-02-26 10:29 ` Christoph Hellwig
2024-02-26 10:29 ` [PATCH 02/16] block: add a queue_limits_stack_bdev helper Christoph Hellwig
2024-02-26 10:29 ` Christoph Hellwig
2024-02-26 10:29 ` [PATCH 03/16] dm: use queue_limits_set Christoph Hellwig
2024-02-26 10:29 ` Christoph Hellwig
2024-02-26 10:29 ` [PATCH 04/16] md: add queue limit helpers Christoph Hellwig
2024-02-26 10:29 ` Christoph Hellwig
2024-02-26 11:38 ` Yu Kuai
2024-02-26 11:38 ` Yu Kuai
2024-02-27 14:36 ` Christoph Hellwig
2024-02-27 14:36 ` Christoph Hellwig
2024-02-28 1:38 ` Yu Kuai
2024-02-28 1:38 ` Yu Kuai
2024-02-26 10:29 ` [PATCH 05/16] md/raid0: use the atomic queue limit update APIs Christoph Hellwig
2024-02-26 10:29 ` Christoph Hellwig
2024-02-26 10:29 ` [PATCH 06/16] md/raid1: " Christoph Hellwig
2024-02-26 10:29 ` Christoph Hellwig
2024-02-26 11:29 ` Yu Kuai
2024-02-26 11:29 ` Yu Kuai
2024-02-27 15:26 ` Christoph Hellwig
2024-02-27 15:26 ` Christoph Hellwig
2024-02-27 21:54 ` Song Liu
2024-02-27 21:54 ` Song Liu
2024-02-28 1:42 ` Yu Kuai
2024-02-28 1:42 ` Yu Kuai
2024-02-26 10:29 ` [PATCH 07/16] md/raid10: " Christoph Hellwig
2024-02-26 10:29 ` Christoph Hellwig
2024-02-26 10:29 ` [PATCH 08/16] md/raid5: " Christoph Hellwig
2024-02-26 10:29 ` Christoph Hellwig
2024-02-26 10:29 ` [PATCH 09/16] block: remove disk_stack_limits Christoph Hellwig
2024-02-26 10:29 ` Christoph Hellwig
2024-02-26 10:29 ` [PATCH 10/16] drbd: pass the max_hw_sectors limit to blk_alloc_disk Christoph Hellwig
2024-02-26 10:29 ` Christoph Hellwig
2024-03-03 15:14 ` drbd queue limits conversion ping Christoph Hellwig
2024-03-03 15:14 ` Christoph Hellwig
2024-03-04 15:31 ` Philipp Reisner
2024-03-04 15:31 ` Philipp Reisner
2024-03-05 9:39 ` Philipp Reisner
2024-03-05 9:39 ` Philipp Reisner
2024-03-05 13:38 ` Christoph Hellwig [this message]
2024-03-05 13:38 ` Christoph Hellwig
2024-02-26 10:29 ` [PATCH 11/16] drbd: refactor drbd_reconsider_queue_parameters Christoph Hellwig
2024-02-26 10:29 ` Christoph Hellwig
2024-02-26 10:30 ` [PATCH 12/16] drbd: refactor the backing dev max_segments calculation Christoph Hellwig
2024-02-26 10:30 ` Christoph Hellwig
2024-02-26 10:30 ` [PATCH 13/16] drbd: merge drbd_setup_queue_param into drbd_reconsider_queue_parameters Christoph Hellwig
2024-02-26 10:30 ` Christoph Hellwig
2024-02-26 10:30 ` [PATCH 14/16] drbd: don't set max_write_zeroes_sectors in decide_on_discard_support Christoph Hellwig
2024-02-26 10:30 ` Christoph Hellwig
2024-02-26 10:30 ` [PATCH 15/16] drbd: split out a drbd_discard_supported helper Christoph Hellwig
2024-02-26 10:30 ` Christoph Hellwig
2024-02-26 10:30 ` [PATCH 16/16] drbd: atomically update queue limits in drbd_reconsider_queue_parameters Christoph Hellwig
2024-02-26 10:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240305133812.GA1345@lst.de \
--to=hch@lst.de \
--cc=christoph.boehmwalder@linbit.com \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.