From: Jakub Kicinski <kuba@kernel.org>
To: Dragos Tatulea <dtatulea@nvidia.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"dsahern@kernel.org" <dsahern@kernel.org>,
Gal Pressman <gal@nvidia.com>,
"steffen.klassert@secunet.com" <steffen.klassert@secunet.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leon Romanovsky <leonro@nvidia.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"almasrymina@google.com" <almasrymina@google.com>,
"Anatoli.Chechelnickiy@m.interpipe.biz"
<Anatoli.Chechelnickiy@m.interpipe.biz>,
"ian.kumlien@gmail.com" <ian.kumlien@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [RFC] net: esp: fix bad handling of pages from page_pool
Date: Wed, 6 Mar 2024 08:09:31 -0800 [thread overview]
Message-ID: <20240306080931.2e24101b@kernel.org> (raw)
In-Reply-To: <320ef2399e48ba0a8a11a3b258b7ad88384f42fb.camel@nvidia.com>
On Wed, 6 Mar 2024 16:00:46 +0000 Dragos Tatulea wrote:
> > Hm, that's a judgment call.
> > Part of me wants to put it next to napi_frag_unref(), since we
> > basically need to factor out the insides of this function.
> > When you post the patch the page pool crowd will give us
> > their opinions.
>
> Why not have napi_pp_put_page simply return false if CONFIG_PAGE_POOL is not
> set?
Without LTO it may still be a function call.
Plus, subjectively, I think that it's a bit too much logic to encode in
the caller (you must also check skb->pp_recycle, AFAIU)
Maybe we should make skb_pp_recycle() take struct page and move it to
skbuff.h ? Rename it to skb_page_unref() ?
> Regarding stable would I need to send a separate fix that does the raw pp page
> check without the API?
You can put them in one patch, I reckon.
next prev parent reply other threads:[~2024-03-06 16:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 9:48 [RFC] net: esp: fix bad handling of pages from page_pool Dragos Tatulea
2024-03-06 3:04 ` Jakub Kicinski
2024-03-06 13:05 ` Dragos Tatulea
2024-03-06 15:22 ` Jakub Kicinski
2024-03-06 16:00 ` Dragos Tatulea
2024-03-06 16:09 ` Jakub Kicinski [this message]
2024-03-06 16:40 ` Mina Almasry
2024-03-06 17:09 ` Dragos Tatulea
2024-03-06 17:27 ` Mina Almasry
2024-03-06 17:41 ` Jakub Kicinski
2024-03-06 18:41 ` Mina Almasry
2024-03-06 18:46 ` Mina Almasry
2024-03-07 2:16 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240306080931.2e24101b@kernel.org \
--to=kuba@kernel.org \
--cc=Anatoli.Chechelnickiy@m.interpipe.biz \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=herbert@gondor.apana.org.au \
--cc=ian.kumlien@gmail.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.