From: Jakub Kicinski <kuba@kernel.org>
To: Dragos Tatulea <dtatulea@nvidia.com>
Cc: "almasrymina@google.com" <almasrymina@google.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
Gal Pressman <gal@nvidia.com>,
"dsahern@kernel.org" <dsahern@kernel.org>,
"steffen.klassert@secunet.com" <steffen.klassert@secunet.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
Leon Romanovsky <leonro@nvidia.com>,
"edumazet@google.com" <edumazet@google.com>,
"ian.kumlien@gmail.com" <ian.kumlien@gmail.com>,
"Anatoli.Chechelnickiy@m.interpipe.biz"
<Anatoli.Chechelnickiy@m.interpipe.biz>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [RFC] net: esp: fix bad handling of pages from page_pool
Date: Wed, 6 Mar 2024 09:41:33 -0800 [thread overview]
Message-ID: <20240306094133.7075c39f@kernel.org> (raw)
In-Reply-To: <9a78b37abdf40daafd9936299ea2c08f936ad3d5.camel@nvidia.com>
On Wed, 6 Mar 2024 17:09:57 +0000 Dragos Tatulea wrote:
> > Does the caller need to check skb->pp_recycle? pp_recycle seems like a
> > redundant bit. We can tell whether the page is pp by checking
> > is_pp_page(page). the pages in the frag must be pp pages when
> > skb->pp_recycle is set and must be non pp pages when the
> > skb->pp_recycle is not set, so it all seems redundant to me.
> >
> AFAIU we don't have to check for pp_recycle, at least not in this specific case.
Definitely not something we assuming in a fix that needs to go
to stable.
So far, AFAIU, it's legal to have an skb without skb->pp_recycle
set, which holds full page refs to a PP page.
next prev parent reply other threads:[~2024-03-06 17:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 9:48 [RFC] net: esp: fix bad handling of pages from page_pool Dragos Tatulea
2024-03-06 3:04 ` Jakub Kicinski
2024-03-06 13:05 ` Dragos Tatulea
2024-03-06 15:22 ` Jakub Kicinski
2024-03-06 16:00 ` Dragos Tatulea
2024-03-06 16:09 ` Jakub Kicinski
2024-03-06 16:40 ` Mina Almasry
2024-03-06 17:09 ` Dragos Tatulea
2024-03-06 17:27 ` Mina Almasry
2024-03-06 17:41 ` Jakub Kicinski [this message]
2024-03-06 18:41 ` Mina Almasry
2024-03-06 18:46 ` Mina Almasry
2024-03-07 2:16 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240306094133.7075c39f@kernel.org \
--to=kuba@kernel.org \
--cc=Anatoli.Chechelnickiy@m.interpipe.biz \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=herbert@gondor.apana.org.au \
--cc=ian.kumlien@gmail.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.