From: Jakub Kicinski <kuba@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Yury Norov <yury.norov@gmail.com>,
netdev@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Mark Brown <broonie@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Herve Codina <herve.codina@bootlin.com>,
Paolo Abeni <pabeni@redhat.com>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v6 1/5] net: wan: Add support for QMC HDLC
Date: Wed, 6 Mar 2024 08:22:59 -0800 [thread overview]
Message-ID: <20240306082259.5a29a5aa@kernel.org> (raw)
In-Reply-To: <Zehxwo2wCLkZBQzc@smile.fi.intel.com>
On Wed, 6 Mar 2024 15:38:10 +0200 Andy Shevchenko wrote:
> > It's minor, but you can avoid conditionals doing something like:
> >
> > netdev->stats.rx_over_errors += !!(flags & QMC_RX_FLAG_HDLC_OVF);
>
> This is harder to read.
+1
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Yury Norov <yury.norov@gmail.com>,
Herve Codina <herve.codina@bootlin.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, Andrew Lunn <andrew@lunn.ch>,
Mark Brown <broonie@kernel.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v6 1/5] net: wan: Add support for QMC HDLC
Date: Wed, 6 Mar 2024 08:22:59 -0800 [thread overview]
Message-ID: <20240306082259.5a29a5aa@kernel.org> (raw)
In-Reply-To: <Zehxwo2wCLkZBQzc@smile.fi.intel.com>
On Wed, 6 Mar 2024 15:38:10 +0200 Andy Shevchenko wrote:
> > It's minor, but you can avoid conditionals doing something like:
> >
> > netdev->stats.rx_over_errors += !!(flags & QMC_RX_FLAG_HDLC_OVF);
>
> This is harder to read.
+1
next prev parent reply other threads:[~2024-03-06 16:23 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 8:07 [PATCH v6 0/5] Add support for QMC HDLC Herve Codina
2024-03-06 8:07 ` Herve Codina
2024-03-06 8:07 ` [PATCH v6 1/5] net: wan: " Herve Codina
2024-03-06 8:07 ` Herve Codina
2024-03-06 10:56 ` Ratheesh Kannoth
2024-03-06 13:37 ` Herve Codina
2024-03-06 16:01 ` [EXTERNAL] " Ratheesh Kannoth
2024-03-06 16:22 ` Jakub Kicinski
2024-03-06 17:46 ` Herve Codina
2024-03-06 17:52 ` Jakub Kicinski
2024-03-06 13:27 ` Yury Norov
2024-03-06 13:27 ` Yury Norov
2024-03-06 13:38 ` Andy Shevchenko
2024-03-06 13:38 ` Andy Shevchenko
2024-03-06 16:22 ` Jakub Kicinski [this message]
2024-03-06 16:22 ` Jakub Kicinski
2024-03-06 8:07 ` [PATCH v6 2/5] MAINTAINERS: Add the Freescale QMC HDLC driver entry Herve Codina
2024-03-06 8:07 ` Herve Codina
2024-03-06 8:07 ` [PATCH v6 3/5] lib/bitmap: Introduce bitmap_scatter() and bitmap_gather() helpers Herve Codina
2024-03-06 8:07 ` Herve Codina
2024-03-06 13:11 ` Yury Norov
2024-03-06 13:11 ` Yury Norov
2024-03-06 13:39 ` Andy Shevchenko
2024-03-06 13:39 ` Andy Shevchenko
2024-03-07 7:31 ` Herve Codina
2024-03-07 7:31 ` Herve Codina
2024-03-07 11:14 ` Yury Norov
2024-03-06 8:07 ` [PATCH v6 4/5] net: wan: fsl_qmc_hdlc: Add runtime timeslots changes support Herve Codina
2024-03-06 8:07 ` Herve Codina
2024-03-06 13:06 ` Yury Norov
2024-03-06 13:06 ` Yury Norov
2024-03-06 13:43 ` Andy Shevchenko
2024-03-06 13:43 ` Andy Shevchenko
2024-03-06 15:43 ` Herve Codina
2024-03-06 15:43 ` Herve Codina
2024-03-06 15:55 ` Andy Shevchenko
2024-03-06 15:55 ` Andy Shevchenko
2024-03-07 7:26 ` Herve Codina
2024-03-07 7:26 ` Herve Codina
2024-03-06 8:07 ` [PATCH v6 5/5] net: wan: fsl_qmc_hdlc: Add framer support Herve Codina
2024-03-06 8:07 ` Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240306082259.5a29a5aa@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herve.codina@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vadim.fedorenko@linux.dev \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.