From: "Michael Büsch" <m@bues.ch>
To: James Dutton <james.dutton@gmail.com>
Cc: Rand Deeb <rand.sec96@gmail.com>,
deeb.rand@confident.ru, jonas.gorski@gmail.com,
khoroshilov@ispras.ru, kvalo@kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
lvc-project@linuxtesting.org,
voskresenski.stanislav@confident.ru
Subject: Re: [PATCH v3] ssb: Fix potential NULL pointer dereference in ssb_device_uevent
Date: Fri, 8 Mar 2024 05:50:49 +0100 [thread overview]
Message-ID: <20240308055049.50a830fc@barney> (raw)
In-Reply-To: <CAAMvbhGmu5VtkA=KnxoHr=Fg_4=1yHFP_SERwKD_rxH=jpM1BA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 448 bytes --]
On Thu, 7 Mar 2024 22:02:29 +0000
James Dutton <james.dutton@gmail.com> wrote:
> If one does a NULL check after it has been previously dereferenced,
> the compiler will totally remove the NULL check anyway,
I think the kernel uses -fno-delete-null-pointer-checks.
But anyway, this doesn't invalidate the point of having a NULL check.
The intent of the code was very clear.
So don't remove it.
--
Michael Büsch
https://bues.ch/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-03-08 5:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 12:30 [PATCH v3] ssb: Fix potential NULL pointer dereference in ssb_device_uevent Rand Deeb
2024-03-06 15:54 ` Jeff Johnson
2024-03-06 19:51 ` Jonas Gorski
2024-03-07 13:41 ` Rand Deeb
2024-03-07 18:24 ` Michael Büsch
2024-03-07 21:19 ` Rand Deeb
2024-03-07 21:38 ` Michael Büsch
2024-03-07 22:02 ` James Dutton
2024-03-08 4:50 ` Michael Büsch [this message]
2024-03-07 23:29 ` Rand Deeb
2024-03-08 1:04 ` James Dutton
2024-03-08 12:11 ` Rand Deeb
2024-03-08 5:09 ` Michael Büsch
2024-03-08 11:36 ` Rand Deeb
2024-03-08 15:44 ` Michael Büsch
2024-03-12 15:31 ` [v3] ssb: Fix potential NULL pointer dereference in ssb_device_uevent() Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240308055049.50a830fc@barney \
--to=m@bues.ch \
--cc=deeb.rand@confident.ru \
--cc=james.dutton@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=khoroshilov@ispras.ru \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=rand.sec96@gmail.com \
--cc=voskresenski.stanislav@confident.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.