* [linux-next:master 12015/12944] drivers/firmware/arm_scmi/powercap.c:723 scmi_powercap_domain_init_fc() error: buffer overflow 'fc' 2 <= 6
@ 2024-03-09 23:43 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-03-09 23:43 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Pierre Gondois <pierre.gondois@arm.com>
CC: Viresh Kumar <viresh.kumar@linaro.org>
CC: Cristian Marussi <cristian.marussi@arm.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 8ffc8b1bbd505e27e2c8439d326b6059c906c9dd
commit: 2441caa84aac8abf1be9e20db3e6bb921e74c8a2 [12015/12944] firmware: arm_scmi: Populate fast channel rate_limit
:::::: branch date: 2 days ago
:::::: commit date: 4 days ago
config: nios2-randconfig-r071-20240309 (https://download.01.org/0day-ci/archive/20240310/202403100744.7Op3PI8L-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 13.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202403100744.7Op3PI8L-lkp@intel.com/
smatch warnings:
drivers/firmware/arm_scmi/powercap.c:723 scmi_powercap_domain_init_fc() error: buffer overflow 'fc' 2 <= 6
vim +/fc +723 drivers/firmware/arm_scmi/powercap.c
0316f99c4780b0 Cristian Marussi 2022-07-04 693
855aa26e5f56d4 Cristian Marussi 2022-07-04 694 static void scmi_powercap_domain_init_fc(const struct scmi_protocol_handle *ph,
855aa26e5f56d4 Cristian Marussi 2022-07-04 695 u32 domain, struct scmi_fc_info **p_fc)
855aa26e5f56d4 Cristian Marussi 2022-07-04 696 {
855aa26e5f56d4 Cristian Marussi 2022-07-04 697 struct scmi_fc_info *fc;
855aa26e5f56d4 Cristian Marussi 2022-07-04 698
855aa26e5f56d4 Cristian Marussi 2022-07-04 699 fc = devm_kcalloc(ph->dev, POWERCAP_FC_MAX, sizeof(*fc), GFP_KERNEL);
855aa26e5f56d4 Cristian Marussi 2022-07-04 700 if (!fc)
855aa26e5f56d4 Cristian Marussi 2022-07-04 701 return;
855aa26e5f56d4 Cristian Marussi 2022-07-04 702
855aa26e5f56d4 Cristian Marussi 2022-07-04 703 ph->hops->fastchannel_init(ph, POWERCAP_DESCRIBE_FASTCHANNEL,
855aa26e5f56d4 Cristian Marussi 2022-07-04 704 POWERCAP_CAP_SET, 4, domain,
855aa26e5f56d4 Cristian Marussi 2022-07-04 705 &fc[POWERCAP_FC_CAP].set_addr,
2441caa84aac8a Pierre Gondois 2024-02-22 706 &fc[POWERCAP_FC_CAP].set_db,
2441caa84aac8a Pierre Gondois 2024-02-22 707 &fc[POWERCAP_FC_CAP].rate_limit);
855aa26e5f56d4 Cristian Marussi 2022-07-04 708
855aa26e5f56d4 Cristian Marussi 2022-07-04 709 ph->hops->fastchannel_init(ph, POWERCAP_DESCRIBE_FASTCHANNEL,
855aa26e5f56d4 Cristian Marussi 2022-07-04 710 POWERCAP_CAP_GET, 4, domain,
2441caa84aac8a Pierre Gondois 2024-02-22 711 &fc[POWERCAP_FC_CAP].get_addr, NULL,
2441caa84aac8a Pierre Gondois 2024-02-22 712 &fc[POWERCAP_FC_CAP].rate_limit);
855aa26e5f56d4 Cristian Marussi 2022-07-04 713
855aa26e5f56d4 Cristian Marussi 2022-07-04 714 ph->hops->fastchannel_init(ph, POWERCAP_DESCRIBE_FASTCHANNEL,
855aa26e5f56d4 Cristian Marussi 2022-07-04 715 POWERCAP_PAI_SET, 4, domain,
855aa26e5f56d4 Cristian Marussi 2022-07-04 716 &fc[POWERCAP_FC_PAI].set_addr,
2441caa84aac8a Pierre Gondois 2024-02-22 717 &fc[POWERCAP_FC_PAI].set_db,
2441caa84aac8a Pierre Gondois 2024-02-22 718 &fc[POWERCAP_FC_PAI].rate_limit);
855aa26e5f56d4 Cristian Marussi 2022-07-04 719
855aa26e5f56d4 Cristian Marussi 2022-07-04 720 ph->hops->fastchannel_init(ph, POWERCAP_DESCRIBE_FASTCHANNEL,
855aa26e5f56d4 Cristian Marussi 2022-07-04 721 POWERCAP_PAI_GET, 4, domain,
2441caa84aac8a Pierre Gondois 2024-02-22 722 &fc[POWERCAP_FC_PAI].get_addr, NULL,
2441caa84aac8a Pierre Gondois 2024-02-22 @723 &fc[POWERCAP_PAI_GET].rate_limit);
855aa26e5f56d4 Cristian Marussi 2022-07-04 724
855aa26e5f56d4 Cristian Marussi 2022-07-04 725 *p_fc = fc;
855aa26e5f56d4 Cristian Marussi 2022-07-04 726 }
855aa26e5f56d4 Cristian Marussi 2022-07-04 727
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* [linux-next:master 12015/12944] drivers/firmware/arm_scmi/powercap.c:723 scmi_powercap_domain_init_fc() error: buffer overflow 'fc' 2 <= 6
@ 2024-03-11 5:26 Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2024-03-11 5:26 UTC (permalink / raw)
To: oe-kbuild, Pierre Gondois
Cc: lkp, oe-kbuild-all, Viresh Kumar, Cristian Marussi
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 8ffc8b1bbd505e27e2c8439d326b6059c906c9dd
commit: 2441caa84aac8abf1be9e20db3e6bb921e74c8a2 [12015/12944] firmware: arm_scmi: Populate fast channel rate_limit
config: nios2-randconfig-r071-20240309 (https://download.01.org/0day-ci/archive/20240310/202403100744.7Op3PI8L-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 13.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202403100744.7Op3PI8L-lkp@intel.com/
smatch warnings:
drivers/firmware/arm_scmi/powercap.c:723 scmi_powercap_domain_init_fc() error: buffer overflow 'fc' 2 <= 6
vim +/fc +723 drivers/firmware/arm_scmi/powercap.c
855aa26e5f56d4 Cristian Marussi 2022-07-04 694 static void scmi_powercap_domain_init_fc(const struct scmi_protocol_handle *ph,
855aa26e5f56d4 Cristian Marussi 2022-07-04 695 u32 domain, struct scmi_fc_info **p_fc)
855aa26e5f56d4 Cristian Marussi 2022-07-04 696 {
855aa26e5f56d4 Cristian Marussi 2022-07-04 697 struct scmi_fc_info *fc;
855aa26e5f56d4 Cristian Marussi 2022-07-04 698
855aa26e5f56d4 Cristian Marussi 2022-07-04 699 fc = devm_kcalloc(ph->dev, POWERCAP_FC_MAX, sizeof(*fc), GFP_KERNEL);
^^^^^^^^^^^^^^^
Need to bump this value. Currently it's 2.
855aa26e5f56d4 Cristian Marussi 2022-07-04 700 if (!fc)
855aa26e5f56d4 Cristian Marussi 2022-07-04 701 return;
855aa26e5f56d4 Cristian Marussi 2022-07-04 702
855aa26e5f56d4 Cristian Marussi 2022-07-04 703 ph->hops->fastchannel_init(ph, POWERCAP_DESCRIBE_FASTCHANNEL,
855aa26e5f56d4 Cristian Marussi 2022-07-04 704 POWERCAP_CAP_SET, 4, domain,
855aa26e5f56d4 Cristian Marussi 2022-07-04 705 &fc[POWERCAP_FC_CAP].set_addr,
2441caa84aac8a Pierre Gondois 2024-02-22 706 &fc[POWERCAP_FC_CAP].set_db,
2441caa84aac8a Pierre Gondois 2024-02-22 707 &fc[POWERCAP_FC_CAP].rate_limit);
855aa26e5f56d4 Cristian Marussi 2022-07-04 708
855aa26e5f56d4 Cristian Marussi 2022-07-04 709 ph->hops->fastchannel_init(ph, POWERCAP_DESCRIBE_FASTCHANNEL,
855aa26e5f56d4 Cristian Marussi 2022-07-04 710 POWERCAP_CAP_GET, 4, domain,
2441caa84aac8a Pierre Gondois 2024-02-22 711 &fc[POWERCAP_FC_CAP].get_addr, NULL,
2441caa84aac8a Pierre Gondois 2024-02-22 712 &fc[POWERCAP_FC_CAP].rate_limit);
855aa26e5f56d4 Cristian Marussi 2022-07-04 713
855aa26e5f56d4 Cristian Marussi 2022-07-04 714 ph->hops->fastchannel_init(ph, POWERCAP_DESCRIBE_FASTCHANNEL,
855aa26e5f56d4 Cristian Marussi 2022-07-04 715 POWERCAP_PAI_SET, 4, domain,
855aa26e5f56d4 Cristian Marussi 2022-07-04 716 &fc[POWERCAP_FC_PAI].set_addr,
2441caa84aac8a Pierre Gondois 2024-02-22 717 &fc[POWERCAP_FC_PAI].set_db,
2441caa84aac8a Pierre Gondois 2024-02-22 718 &fc[POWERCAP_FC_PAI].rate_limit);
855aa26e5f56d4 Cristian Marussi 2022-07-04 719
855aa26e5f56d4 Cristian Marussi 2022-07-04 720 ph->hops->fastchannel_init(ph, POWERCAP_DESCRIBE_FASTCHANNEL,
855aa26e5f56d4 Cristian Marussi 2022-07-04 721 POWERCAP_PAI_GET, 4, domain,
2441caa84aac8a Pierre Gondois 2024-02-22 722 &fc[POWERCAP_FC_PAI].get_addr, NULL,
2441caa84aac8a Pierre Gondois 2024-02-22 @723 &fc[POWERCAP_PAI_GET].rate_limit);
^^^^^^^^^^^^^^^^
And this is 6.
855aa26e5f56d4 Cristian Marussi 2022-07-04 724
855aa26e5f56d4 Cristian Marussi 2022-07-04 725 *p_fc = fc;
855aa26e5f56d4 Cristian Marussi 2022-07-04 726 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-11 5:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-09 23:43 [linux-next:master 12015/12944] drivers/firmware/arm_scmi/powercap.c:723 scmi_powercap_domain_init_fc() error: buffer overflow 'fc' 2 <= 6 kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2024-03-11 5:26 Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.