* [PATCH] nouveau: reset the bo resource bus info after an eviction
@ 2024-03-11 7:20 Dave Airlie
2024-03-11 13:02 ` Timur Tabi
2024-03-11 13:51 ` Christian König
0 siblings, 2 replies; 3+ messages in thread
From: Dave Airlie @ 2024-03-11 7:20 UTC (permalink / raw)
To: dri-devel; +Cc: nouveau, Dave Airlie, Christian König
From: Dave Airlie <airlied@redhat.com>
Later attempts to refault the bo won't happen and the whole
GPU does to lunch. I think Christian's refactoring of this
code out to the driver broke this not very well tested path.
Fixes: 141b15e59175 ("drm/nouveau: move io_reserve_lru handling into the driver v5")
Cc: Christian König <christian.koenig@amd.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/nouveau/nouveau_bo.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
index c6c544d7c911..a4e8f625fce6 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bo.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
@@ -1271,6 +1271,8 @@ nouveau_ttm_io_mem_reserve(struct ttm_device *bdev, struct ttm_resource *reg)
drm_vma_node_unmap(&nvbo->bo.base.vma_node,
bdev->dev_mapping);
nouveau_ttm_io_mem_free_locked(drm, nvbo->bo.resource);
+ nvbo->bo.resource->bus.offset = 0;
+ nvbo->bo.resource->bus.addr = NULL;
goto retry;
}
--
2.43.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nouveau: reset the bo resource bus info after an eviction
2024-03-11 7:20 [PATCH] nouveau: reset the bo resource bus info after an eviction Dave Airlie
@ 2024-03-11 13:02 ` Timur Tabi
2024-03-11 13:51 ` Christian König
1 sibling, 0 replies; 3+ messages in thread
From: Timur Tabi @ 2024-03-11 13:02 UTC (permalink / raw)
To: dri-devel@lists.freedesktop.org, airlied@gmail.com
Cc: airlied@redhat.com, nouveau@lists.freedesktop.org,
christian.koenig@amd.com
On Mon, 2024-03-11 at 17:20 +1000, Dave Airlie wrote:
> Later attempts to refault the bo won't happen and the whole
> GPU does to lunch. I think Christian's refactoring of this
Typo: I think you meant "goes to lunch".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nouveau: reset the bo resource bus info after an eviction
2024-03-11 7:20 [PATCH] nouveau: reset the bo resource bus info after an eviction Dave Airlie
2024-03-11 13:02 ` Timur Tabi
@ 2024-03-11 13:51 ` Christian König
1 sibling, 0 replies; 3+ messages in thread
From: Christian König @ 2024-03-11 13:51 UTC (permalink / raw)
To: Dave Airlie, dri-devel; +Cc: nouveau, Dave Airlie
Am 11.03.24 um 08:20 schrieb Dave Airlie:
> From: Dave Airlie <airlied@redhat.com>
>
> Later attempts to refault the bo won't happen and the whole
> GPU does to lunch. I think Christian's refactoring of this
> code out to the driver broke this not very well tested path.
Yeah that is certainly possible.
>
> Fixes: 141b15e59175 ("drm/nouveau: move io_reserve_lru handling into the driver v5")
> Cc: Christian König <christian.koenig@amd.com>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_bo.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
> index c6c544d7c911..a4e8f625fce6 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
> @@ -1271,6 +1271,8 @@ nouveau_ttm_io_mem_reserve(struct ttm_device *bdev, struct ttm_resource *reg)
> drm_vma_node_unmap(&nvbo->bo.base.vma_node,
> bdev->dev_mapping);
> nouveau_ttm_io_mem_free_locked(drm, nvbo->bo.resource);
> + nvbo->bo.resource->bus.offset = 0;
> + nvbo->bo.resource->bus.addr = NULL;
> goto retry;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-11 13:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-11 7:20 [PATCH] nouveau: reset the bo resource bus info after an eviction Dave Airlie
2024-03-11 13:02 ` Timur Tabi
2024-03-11 13:51 ` Christian König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.