All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Hector Palacios <hector.palacios@digi.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	lvc-project@linuxtesting.org
Subject: Re: [PATCH] mtd: rawnand: hynix: fixed typo
Date: Fri, 15 Mar 2024 13:14:12 +0100	[thread overview]
Message-ID: <20240315131412.488167c1@xps-13> (raw)
In-Reply-To: <529774b9-20be-485d-b218-2452ce536770@gmail.com>

Hi Maxim,

korotkov.maxim.s@gmail.com wrote on Fri, 15 Mar 2024 14:45:47 +0300:

> Hi,
> 
> On 15.03.2024 14:23, Miquel Raynal wrote:
> > Isn't it done like that on purpose? Read-retry is not a mandatory
> > feature.  
> 
> Works it as designed? I'm not sure about it.
> I wouldn't rule it out, but it's a little weird that the hynix_nand_rr_init() function
> is used as if it can return an error but never returns.
> 
> Probably  checking  of value returned from hynix_nand_rr_init()
> should be removed in hynix_nand_init()

It is indeed confusing. I'll take it.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Hector Palacios <hector.palacios@digi.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	lvc-project@linuxtesting.org
Subject: Re: [PATCH] mtd: rawnand: hynix: fixed typo
Date: Fri, 15 Mar 2024 13:14:12 +0100	[thread overview]
Message-ID: <20240315131412.488167c1@xps-13> (raw)
In-Reply-To: <529774b9-20be-485d-b218-2452ce536770@gmail.com>

Hi Maxim,

korotkov.maxim.s@gmail.com wrote on Fri, 15 Mar 2024 14:45:47 +0300:

> Hi,
> 
> On 15.03.2024 14:23, Miquel Raynal wrote:
> > Isn't it done like that on purpose? Read-retry is not a mandatory
> > feature.  
> 
> Works it as designed? I'm not sure about it.
> I wouldn't rule it out, but it's a little weird that the hynix_nand_rr_init() function
> is used as if it can return an error but never returns.
> 
> Probably  checking  of value returned from hynix_nand_rr_init()
> should be removed in hynix_nand_init()

It is indeed confusing. I'll take it.

Thanks,
Miquèl

  reply	other threads:[~2024-03-15 12:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 10:27 [PATCH] mtd: rawnand: hynix: fixed typo Maxim Korotkov
2024-03-13 10:27 ` Maxim Korotkov
2024-03-15 11:23 ` Miquel Raynal
2024-03-15 11:23   ` Miquel Raynal
2024-03-15 11:45   ` Maxim Korotkov
2024-03-15 11:45     ` Maxim Korotkov
2024-03-15 12:14     ` Miquel Raynal [this message]
2024-03-15 12:14       ` Miquel Raynal
2024-03-25 10:18 ` Miquel Raynal
2024-03-25 10:18   ` Miquel Raynal
2024-03-25 10:20 ` Miquel Raynal
2024-03-25 10:20   ` Miquel Raynal
2024-03-25 15:41 ` Andy Shevchenko
2024-03-25 15:41   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240315131412.488167c1@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=bbrezillon@kernel.org \
    --cc=hector.palacios@digi.com \
    --cc=korotkov.maxim.s@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.