Re: [PATCH 3/4] PM: EM: Add em_dev_update_chip_binning()

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20240314140421.3563571-4-lukasz.luba@arm.com>
References: <20240314140421.3563571-4-lukasz.luba@arm.com>
TO: Lukasz Luba <lukasz.luba@arm.com>
TO: linux-kernel@vger.kernel.org
TO: linux-pm@vger.kernel.org
CC: lukasz.luba@arm.com
CC: dietmar.eggemann@arm.com
CC: linux-arm-kernel@lists.infradead.org
CC: sboyd@kernel.org
CC: nm@ti.com
CC: linux-samsung-soc@vger.kernel.org
CC: daniel.lezcano@linaro.org
CC: rafael@kernel.org
CC: viresh.kumar@linaro.org
CC: krzysztof.kozlowski@linaro.org
CC: alim.akhtar@samsung.com
CC: m.szyprowski@samsung.com
CC: mhiramat@kernel.org

Hi Lukasz,

kernel test robot noticed the following build warnings:

[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on linus/master next-20240315]
[cannot apply to krzk/for-next clk/clk-next soc/for-next rafael-pm/acpi-bus rafael-pm/devprop v6.8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Lukasz-Luba/OPP-OF-Export-dev_opp_pm_calc_power-for-usage-from-EM/20240314-220719
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link:    https://lore.kernel.org/r/20240314140421.3563571-4-lukasz.luba%40arm.com
patch subject: [PATCH 3/4] PM: EM: Add em_dev_update_chip_binning()
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: powerpc64-randconfig-r071-20240315 (https://download.01.org/0day-ci/archive/20240316/202403160905.OfEMtk76-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 13.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202403160905.OfEMtk76-lkp@intel.com/

smatch warnings:
kernel/power/energy_model.c:824 em_dev_update_chip_binning() error: uninitialized symbol 'ret'.

vim +/ret +824 kernel/power/energy_model.c

3114fc30ea7e1fd Lukasz Luba 2024-03-14  800  
3114fc30ea7e1fd Lukasz Luba 2024-03-14  801  /**
3114fc30ea7e1fd Lukasz Luba 2024-03-14  802   * em_dev_update_chip_binning() - Update Energy Model with new values after
3114fc30ea7e1fd Lukasz Luba 2024-03-14  803   *			the new voltage information is present in the OPPs.
3114fc30ea7e1fd Lukasz Luba 2024-03-14  804   * @dev		: Device for which the Energy Model has to be updated.
3114fc30ea7e1fd Lukasz Luba 2024-03-14  805   *
3114fc30ea7e1fd Lukasz Luba 2024-03-14  806   * This function allows to update easily the EM with new values available in
3114fc30ea7e1fd Lukasz Luba 2024-03-14  807   * the OPP framework and DT. It can be used after the chip has been properly
3114fc30ea7e1fd Lukasz Luba 2024-03-14  808   * verified by device drivers and the voltages adjusted for the 'chip binning'.
3114fc30ea7e1fd Lukasz Luba 2024-03-14  809   * It uses the "dynamic-power-coefficient" DT property to calculate the power
3114fc30ea7e1fd Lukasz Luba 2024-03-14  810   * values for EM. For power calculation it uses the new adjusted voltage
3114fc30ea7e1fd Lukasz Luba 2024-03-14  811   * values known for OPPs, which might be changed after boot.
3114fc30ea7e1fd Lukasz Luba 2024-03-14  812   */
3114fc30ea7e1fd Lukasz Luba 2024-03-14  813  int em_dev_update_chip_binning(struct device *dev)
3114fc30ea7e1fd Lukasz Luba 2024-03-14  814  {
3114fc30ea7e1fd Lukasz Luba 2024-03-14  815  	struct em_perf_table __rcu *em_table;
3114fc30ea7e1fd Lukasz Luba 2024-03-14  816  	struct em_perf_domain *pd;
3114fc30ea7e1fd Lukasz Luba 2024-03-14  817  	int i, ret;
3114fc30ea7e1fd Lukasz Luba 2024-03-14  818  
3114fc30ea7e1fd Lukasz Luba 2024-03-14  819  	if (IS_ERR_OR_NULL(dev))
3114fc30ea7e1fd Lukasz Luba 2024-03-14  820  		return -EINVAL;
3114fc30ea7e1fd Lukasz Luba 2024-03-14  821  
3114fc30ea7e1fd Lukasz Luba 2024-03-14  822  	pd = em_pd_get(dev);
3114fc30ea7e1fd Lukasz Luba 2024-03-14  823  	if (!pd) {
3114fc30ea7e1fd Lukasz Luba 2024-03-14 @824  		dev_warn(dev, "Couldn't find Energy Model %d\n", ret);

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki