From: kernel test robot <lkp@intel.com>
To: Lukasz Luba <lukasz.luba@arm.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, lukasz.luba@arm.com,
dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org,
sboyd@kernel.org, nm@ti.com, linux-samsung-soc@vger.kernel.org,
daniel.lezcano@linaro.org, rafael@kernel.org,
viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org,
alim.akhtar@samsung.com, m.szyprowski@samsung.com,
mhiramat@kernel.org
Subject: Re: [PATCH 3/4] PM: EM: Add em_dev_update_chip_binning()
Date: Fri, 15 Mar 2024 23:54:04 +0800 [thread overview]
Message-ID: <202403152322.1OIlZSAj-lkp@intel.com> (raw)
In-Reply-To: <20240314140421.3563571-4-lukasz.luba@arm.com>
Hi Lukasz,
kernel test robot noticed the following build warnings:
[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on linus/master next-20240315]
[cannot apply to krzk/for-next clk/clk-next soc/for-next rafael-pm/acpi-bus rafael-pm/devprop v6.8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Lukasz-Luba/OPP-OF-Export-dev_opp_pm_calc_power-for-usage-from-EM/20240314-220719
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/20240314140421.3563571-4-lukasz.luba%40arm.com
patch subject: [PATCH 3/4] PM: EM: Add em_dev_update_chip_binning()
config: x86_64-randconfig-123-20240315 (https://download.01.org/0day-ci/archive/20240315/202403152322.1OIlZSAj-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240315/202403152322.1OIlZSAj-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403152322.1OIlZSAj-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
kernel/power/energy_model.c:168:15: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct em_perf_table [noderef] __rcu *table @@ got struct em_perf_table * @@
kernel/power/energy_model.c:168:15: sparse: expected struct em_perf_table [noderef] __rcu *table
kernel/power/energy_model.c:168:15: sparse: got struct em_perf_table *
kernel/power/energy_model.c:169:15: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const *objp @@ got struct em_perf_table [noderef] __rcu *table @@
kernel/power/energy_model.c:169:15: sparse: expected void const *objp
kernel/power/energy_model.c:169:15: sparse: got struct em_perf_table [noderef] __rcu *table
kernel/power/energy_model.c:177:15: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct em_perf_table [noderef] __rcu *table @@ got struct em_perf_table * @@
kernel/power/energy_model.c:177:15: sparse: expected struct em_perf_table [noderef] __rcu *table
kernel/power/energy_model.c:177:15: sparse: got struct em_perf_table *
kernel/power/energy_model.c:179:19: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct callback_head *head @@ got struct callback_head [noderef] __rcu * @@
kernel/power/energy_model.c:179:19: sparse: expected struct callback_head *head
kernel/power/energy_model.c:179:19: sparse: got struct callback_head [noderef] __rcu *
kernel/power/energy_model.c:190:19: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct kref *kref @@ got struct kref [noderef] __rcu * @@
kernel/power/energy_model.c:190:19: sparse: expected struct kref *kref
kernel/power/energy_model.c:190:19: sparse: got struct kref [noderef] __rcu *
kernel/power/energy_model.c:208:15: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct em_perf_table [noderef] __rcu *table @@ got void * @@
kernel/power/energy_model.c:208:15: sparse: expected struct em_perf_table [noderef] __rcu *table
kernel/power/energy_model.c:208:15: sparse: got void *
kernel/power/energy_model.c:212:20: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct kref *kref @@ got struct kref [noderef] __rcu * @@
kernel/power/energy_model.c:212:20: sparse: expected struct kref *kref
kernel/power/energy_model.c:212:20: sparse: got struct kref [noderef] __rcu *
kernel/power/energy_model.c:328:19: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct kref *kref @@ got struct kref [noderef] __rcu * @@
kernel/power/energy_model.c:328:19: sparse: expected struct kref *kref
kernel/power/energy_model.c:328:19: sparse: got struct kref [noderef] __rcu *
kernel/power/energy_model.c:333:45: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct em_perf_state *table @@ got struct em_perf_state [noderef] __rcu * @@
kernel/power/energy_model.c:333:45: sparse: expected struct em_perf_state *table
kernel/power/energy_model.c:333:45: sparse: got struct em_perf_state [noderef] __rcu *
kernel/power/energy_model.c:433:45: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected struct em_perf_state *table @@ got struct em_perf_state [noderef] __rcu * @@
kernel/power/energy_model.c:433:45: sparse: expected struct em_perf_state *table
kernel/power/energy_model.c:433:45: sparse: got struct em_perf_state [noderef] __rcu *
kernel/power/energy_model.c:450:15: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const *objp @@ got struct em_perf_table [noderef] __rcu *[assigned] em_table @@
kernel/power/energy_model.c:450:15: sparse: expected void const *objp
kernel/power/energy_model.c:450:15: sparse: got struct em_perf_table [noderef] __rcu *[assigned] em_table
kernel/power/energy_model.c:621:55: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct em_perf_state *table @@ got struct em_perf_state [noderef] __rcu * @@
kernel/power/energy_model.c:621:55: sparse: expected struct em_perf_state *table
kernel/power/energy_model.c:621:55: sparse: got struct em_perf_state [noderef] __rcu *
kernel/power/energy_model.c:676:16: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct em_perf_state *new_ps @@ got struct em_perf_state [noderef] __rcu * @@
kernel/power/energy_model.c:676:16: sparse: expected struct em_perf_state *new_ps
kernel/power/energy_model.c:676:16: sparse: got struct em_perf_state [noderef] __rcu *
kernel/power/energy_model.c:694:37: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct em_perf_state *table @@ got struct em_perf_state [noderef] __rcu * @@
kernel/power/energy_model.c:694:37: sparse: expected struct em_perf_state *table
kernel/power/energy_model.c:694:37: sparse: got struct em_perf_state [noderef] __rcu *
kernel/power/energy_model.c:729:38: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected struct em_perf_state *table @@ got struct em_perf_state [noderef] __rcu * @@
kernel/power/energy_model.c:729:38: sparse: expected struct em_perf_state *table
kernel/power/energy_model.c:729:38: sparse: got struct em_perf_state [noderef] __rcu *
>> kernel/power/energy_model.c:836:53: sparse: sparse: dereference of noderef expression
kernel/power/energy_model.c:845:32: sparse: sparse: dereference of noderef expression
vim +836 kernel/power/energy_model.c
800
801 /**
802 * em_dev_update_chip_binning() - Update Energy Model with new values after
803 * the new voltage information is present in the OPPs.
804 * @dev : Device for which the Energy Model has to be updated.
805 *
806 * This function allows to update easily the EM with new values available in
807 * the OPP framework and DT. It can be used after the chip has been properly
808 * verified by device drivers and the voltages adjusted for the 'chip binning'.
809 * It uses the "dynamic-power-coefficient" DT property to calculate the power
810 * values for EM. For power calculation it uses the new adjusted voltage
811 * values known for OPPs, which might be changed after boot.
812 */
813 int em_dev_update_chip_binning(struct device *dev)
814 {
815 struct em_perf_table __rcu *em_table;
816 struct em_perf_domain *pd;
817 int i, ret;
818
819 if (IS_ERR_OR_NULL(dev))
820 return -EINVAL;
821
822 pd = em_pd_get(dev);
823 if (!pd) {
824 dev_warn(dev, "Couldn't find Energy Model %d\n", ret);
825 return -EINVAL;
826 }
827
828 em_table = em_table_dup(pd);
829 if (!em_table) {
830 dev_warn(dev, "EM: allocation failed\n");
831 return -ENOMEM;
832 }
833
834 /* Update power values which might change due to new voltage in OPPs */
835 for (i = 0; i < pd->nr_perf_states; i++) {
> 836 unsigned long freq = em_table->state[i].frequency;
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Lukasz Luba <lukasz.luba@arm.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, lukasz.luba@arm.com,
dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org,
sboyd@kernel.org, nm@ti.com, linux-samsung-soc@vger.kernel.org,
daniel.lezcano@linaro.org, rafael@kernel.org,
viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org,
alim.akhtar@samsung.com, m.szyprowski@samsung.com,
mhiramat@kernel.org
Subject: Re: [PATCH 3/4] PM: EM: Add em_dev_update_chip_binning()
Date: Fri, 15 Mar 2024 23:54:04 +0800 [thread overview]
Message-ID: <202403152322.1OIlZSAj-lkp@intel.com> (raw)
In-Reply-To: <20240314140421.3563571-4-lukasz.luba@arm.com>
Hi Lukasz,
kernel test robot noticed the following build warnings:
[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on linus/master next-20240315]
[cannot apply to krzk/for-next clk/clk-next soc/for-next rafael-pm/acpi-bus rafael-pm/devprop v6.8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Lukasz-Luba/OPP-OF-Export-dev_opp_pm_calc_power-for-usage-from-EM/20240314-220719
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/20240314140421.3563571-4-lukasz.luba%40arm.com
patch subject: [PATCH 3/4] PM: EM: Add em_dev_update_chip_binning()
config: x86_64-randconfig-123-20240315 (https://download.01.org/0day-ci/archive/20240315/202403152322.1OIlZSAj-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240315/202403152322.1OIlZSAj-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403152322.1OIlZSAj-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
kernel/power/energy_model.c:168:15: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct em_perf_table [noderef] __rcu *table @@ got struct em_perf_table * @@
kernel/power/energy_model.c:168:15: sparse: expected struct em_perf_table [noderef] __rcu *table
kernel/power/energy_model.c:168:15: sparse: got struct em_perf_table *
kernel/power/energy_model.c:169:15: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const *objp @@ got struct em_perf_table [noderef] __rcu *table @@
kernel/power/energy_model.c:169:15: sparse: expected void const *objp
kernel/power/energy_model.c:169:15: sparse: got struct em_perf_table [noderef] __rcu *table
kernel/power/energy_model.c:177:15: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct em_perf_table [noderef] __rcu *table @@ got struct em_perf_table * @@
kernel/power/energy_model.c:177:15: sparse: expected struct em_perf_table [noderef] __rcu *table
kernel/power/energy_model.c:177:15: sparse: got struct em_perf_table *
kernel/power/energy_model.c:179:19: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct callback_head *head @@ got struct callback_head [noderef] __rcu * @@
kernel/power/energy_model.c:179:19: sparse: expected struct callback_head *head
kernel/power/energy_model.c:179:19: sparse: got struct callback_head [noderef] __rcu *
kernel/power/energy_model.c:190:19: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct kref *kref @@ got struct kref [noderef] __rcu * @@
kernel/power/energy_model.c:190:19: sparse: expected struct kref *kref
kernel/power/energy_model.c:190:19: sparse: got struct kref [noderef] __rcu *
kernel/power/energy_model.c:208:15: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct em_perf_table [noderef] __rcu *table @@ got void * @@
kernel/power/energy_model.c:208:15: sparse: expected struct em_perf_table [noderef] __rcu *table
kernel/power/energy_model.c:208:15: sparse: got void *
kernel/power/energy_model.c:212:20: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct kref *kref @@ got struct kref [noderef] __rcu * @@
kernel/power/energy_model.c:212:20: sparse: expected struct kref *kref
kernel/power/energy_model.c:212:20: sparse: got struct kref [noderef] __rcu *
kernel/power/energy_model.c:328:19: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct kref *kref @@ got struct kref [noderef] __rcu * @@
kernel/power/energy_model.c:328:19: sparse: expected struct kref *kref
kernel/power/energy_model.c:328:19: sparse: got struct kref [noderef] __rcu *
kernel/power/energy_model.c:333:45: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct em_perf_state *table @@ got struct em_perf_state [noderef] __rcu * @@
kernel/power/energy_model.c:333:45: sparse: expected struct em_perf_state *table
kernel/power/energy_model.c:333:45: sparse: got struct em_perf_state [noderef] __rcu *
kernel/power/energy_model.c:433:45: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected struct em_perf_state *table @@ got struct em_perf_state [noderef] __rcu * @@
kernel/power/energy_model.c:433:45: sparse: expected struct em_perf_state *table
kernel/power/energy_model.c:433:45: sparse: got struct em_perf_state [noderef] __rcu *
kernel/power/energy_model.c:450:15: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const *objp @@ got struct em_perf_table [noderef] __rcu *[assigned] em_table @@
kernel/power/energy_model.c:450:15: sparse: expected void const *objp
kernel/power/energy_model.c:450:15: sparse: got struct em_perf_table [noderef] __rcu *[assigned] em_table
kernel/power/energy_model.c:621:55: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct em_perf_state *table @@ got struct em_perf_state [noderef] __rcu * @@
kernel/power/energy_model.c:621:55: sparse: expected struct em_perf_state *table
kernel/power/energy_model.c:621:55: sparse: got struct em_perf_state [noderef] __rcu *
kernel/power/energy_model.c:676:16: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct em_perf_state *new_ps @@ got struct em_perf_state [noderef] __rcu * @@
kernel/power/energy_model.c:676:16: sparse: expected struct em_perf_state *new_ps
kernel/power/energy_model.c:676:16: sparse: got struct em_perf_state [noderef] __rcu *
kernel/power/energy_model.c:694:37: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct em_perf_state *table @@ got struct em_perf_state [noderef] __rcu * @@
kernel/power/energy_model.c:694:37: sparse: expected struct em_perf_state *table
kernel/power/energy_model.c:694:37: sparse: got struct em_perf_state [noderef] __rcu *
kernel/power/energy_model.c:729:38: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected struct em_perf_state *table @@ got struct em_perf_state [noderef] __rcu * @@
kernel/power/energy_model.c:729:38: sparse: expected struct em_perf_state *table
kernel/power/energy_model.c:729:38: sparse: got struct em_perf_state [noderef] __rcu *
>> kernel/power/energy_model.c:836:53: sparse: sparse: dereference of noderef expression
kernel/power/energy_model.c:845:32: sparse: sparse: dereference of noderef expression
vim +836 kernel/power/energy_model.c
800
801 /**
802 * em_dev_update_chip_binning() - Update Energy Model with new values after
803 * the new voltage information is present in the OPPs.
804 * @dev : Device for which the Energy Model has to be updated.
805 *
806 * This function allows to update easily the EM with new values available in
807 * the OPP framework and DT. It can be used after the chip has been properly
808 * verified by device drivers and the voltages adjusted for the 'chip binning'.
809 * It uses the "dynamic-power-coefficient" DT property to calculate the power
810 * values for EM. For power calculation it uses the new adjusted voltage
811 * values known for OPPs, which might be changed after boot.
812 */
813 int em_dev_update_chip_binning(struct device *dev)
814 {
815 struct em_perf_table __rcu *em_table;
816 struct em_perf_domain *pd;
817 int i, ret;
818
819 if (IS_ERR_OR_NULL(dev))
820 return -EINVAL;
821
822 pd = em_pd_get(dev);
823 if (!pd) {
824 dev_warn(dev, "Couldn't find Energy Model %d\n", ret);
825 return -EINVAL;
826 }
827
828 em_table = em_table_dup(pd);
829 if (!em_table) {
830 dev_warn(dev, "EM: allocation failed\n");
831 return -ENOMEM;
832 }
833
834 /* Update power values which might change due to new voltage in OPPs */
835 for (i = 0; i < pd->nr_perf_states; i++) {
> 836 unsigned long freq = em_table->state[i].frequency;
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-15 15:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 14:04 [PATCH 0/4] Update Energy Model after chip binning adjusted voltages Lukasz Luba
2024-03-14 14:04 ` Lukasz Luba
2024-03-14 14:04 ` [PATCH 1/4] OPP: OF: Export dev_opp_pm_calc_power() for usage from EM Lukasz Luba
2024-03-14 14:04 ` Lukasz Luba
2024-03-14 14:04 ` [PATCH 2/4] PM: EM: Change the em_adjust_new_capacity() to re-use code Lukasz Luba
2024-03-14 14:04 ` Lukasz Luba
2024-03-14 14:04 ` [PATCH 3/4] PM: EM: Add em_dev_update_chip_binning() Lukasz Luba
2024-03-14 14:04 ` Lukasz Luba
2024-03-14 14:32 ` Christian Loehle
2024-03-14 14:32 ` Christian Loehle
2024-03-22 10:26 ` Lukasz Luba
2024-03-22 10:26 ` Lukasz Luba
2024-03-15 15:54 ` kernel test robot [this message]
2024-03-15 15:54 ` kernel test robot
2024-03-15 16:36 ` kernel test robot
2024-03-15 16:36 ` kernel test robot
2024-03-14 14:04 ` [PATCH 4/4] soc: samsung: exynos-asv: Update Energy Model after adjusting voltage Lukasz Luba
2024-03-14 14:04 ` Lukasz Luba
-- strict thread matches above, loose matches on Subject: below --
2024-03-16 2:06 [PATCH 3/4] PM: EM: Add em_dev_update_chip_binning() kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202403152322.1OIlZSAj-lkp@intel.com \
--to=lkp@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=m.szyprowski@samsung.com \
--cc=mhiramat@kernel.org \
--cc=nm@ti.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.