From: Jason Gunthorpe <jgg@nvidia.com>
To: Peter Xu <peterx@redhat.com>
Cc: Muchun Song <muchun.song@linux.dev>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Mike Rapoport <rppt@kernel.org>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 11/13] mm/treewide: Replace pXd_huge() with pXd_leaf()
Date: Mon, 18 Mar 2024 13:16:23 -0300 [thread overview]
Message-ID: <20240318161623.GB5825@nvidia.com> (raw)
In-Reply-To: <ZfL0qh0re5BpYGba@x1n>
On Thu, Mar 14, 2024 at 08:59:22AM -0400, Peter Xu wrote:
> > > --- a/mm/hmm.c
> > > +++ b/mm/hmm.c
> > > @@ -429,7 +429,7 @@ static int hmm_vma_walk_pud(pud_t *pudp, unsigned long start, unsigned long end,
> > > return hmm_vma_walk_hole(start, end, -1, walk);
> > > }
> > >
> > > - if (pud_huge(pud) && pud_devmap(pud)) {
> > > + if (pud_leaf(pud) && pud_devmap(pud)) {
> >
> > Didn't previous patch say devmap implies leaf ? Or is it only for GUP ?
>
> This is an extra safety check that I didn't remove. Devmap used separate
> bits even though I'm not clear on why. It should still imply a leaf though.
Yes, something is very wrong if devmap is true on non-leaf..
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Peter Xu <peterx@redhat.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Matthew Wilcox <willy@infradead.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Andrew Morton <akpm@linux-foundation.org>,
"x86@kernel.org" <x86@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Muchun Song <muchun.song@linux.dev>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>
Subject: Re: [PATCH 11/13] mm/treewide: Replace pXd_huge() with pXd_leaf()
Date: Mon, 18 Mar 2024 13:16:23 -0300 [thread overview]
Message-ID: <20240318161623.GB5825@nvidia.com> (raw)
In-Reply-To: <ZfL0qh0re5BpYGba@x1n>
On Thu, Mar 14, 2024 at 08:59:22AM -0400, Peter Xu wrote:
> > > --- a/mm/hmm.c
> > > +++ b/mm/hmm.c
> > > @@ -429,7 +429,7 @@ static int hmm_vma_walk_pud(pud_t *pudp, unsigned long start, unsigned long end,
> > > return hmm_vma_walk_hole(start, end, -1, walk);
> > > }
> > >
> > > - if (pud_huge(pud) && pud_devmap(pud)) {
> > > + if (pud_leaf(pud) && pud_devmap(pud)) {
> >
> > Didn't previous patch say devmap implies leaf ? Or is it only for GUP ?
>
> This is an extra safety check that I didn't remove. Devmap used separate
> bits even though I'm not clear on why. It should still imply a leaf though.
Yes, something is very wrong if devmap is true on non-leaf..
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Peter Xu <peterx@redhat.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Matthew Wilcox <willy@infradead.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Andrew Morton <akpm@linux-foundation.org>,
"x86@kernel.org" <x86@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Muchun Song <muchun.song@linux.dev>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>
Subject: Re: [PATCH 11/13] mm/treewide: Replace pXd_huge() with pXd_leaf()
Date: Mon, 18 Mar 2024 13:16:23 -0300 [thread overview]
Message-ID: <20240318161623.GB5825@nvidia.com> (raw)
In-Reply-To: <ZfL0qh0re5BpYGba@x1n>
On Thu, Mar 14, 2024 at 08:59:22AM -0400, Peter Xu wrote:
> > > --- a/mm/hmm.c
> > > +++ b/mm/hmm.c
> > > @@ -429,7 +429,7 @@ static int hmm_vma_walk_pud(pud_t *pudp, unsigned long start, unsigned long end,
> > > return hmm_vma_walk_hole(start, end, -1, walk);
> > > }
> > >
> > > - if (pud_huge(pud) && pud_devmap(pud)) {
> > > + if (pud_leaf(pud) && pud_devmap(pud)) {
> >
> > Didn't previous patch say devmap implies leaf ? Or is it only for GUP ?
>
> This is an extra safety check that I didn't remove. Devmap used separate
> bits even though I'm not clear on why. It should still imply a leaf though.
Yes, something is very wrong if devmap is true on non-leaf..
Jason
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-18 16:17 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 21:47 [PATCH 00/13] mm/treewide: Remove pXd_huge() API peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` [PATCH 01/13] mm/hmm: Process pud swap entry without pud_huge() peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` [PATCH 02/13] mm/gup: Cache p4d in follow_p4d_mask() peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` [PATCH 03/13] mm/gup: Check p4d presence before going on peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` [PATCH 04/13] mm/x86: Change pXd_huge() behavior to exclude swap entries peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` [PATCH 05/13] mm/sparc: " peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` [PATCH 06/13] mm/arm: Use macros to define pmd/pud helpers peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` [PATCH 07/13] mm/arm: Redefine pmd_huge() with pmd_leaf() peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` [PATCH 08/13] mm/arm64: Merge pXd_huge() and pXd_leaf() definitions peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` [PATCH 09/13] mm/powerpc: Redefine pXd_huge() with pXd_leaf() peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` peterx
2024-03-14 8:45 ` Christophe Leroy
2024-03-14 8:45 ` Christophe Leroy
2024-03-14 8:45 ` Christophe Leroy
2024-03-14 12:53 ` Peter Xu
2024-03-14 12:53 ` Peter Xu
2024-03-14 12:53 ` Peter Xu
2024-03-14 13:11 ` Christophe Leroy
2024-03-14 13:11 ` Christophe Leroy
2024-03-14 13:11 ` Christophe Leroy
2024-03-18 16:15 ` Jason Gunthorpe
2024-03-18 16:15 ` Jason Gunthorpe
2024-03-18 16:15 ` Jason Gunthorpe
2024-03-19 23:07 ` Christophe Leroy
2024-03-19 23:07 ` Christophe Leroy
2024-03-19 23:07 ` Christophe Leroy
2024-03-19 23:26 ` Jason Gunthorpe
2024-03-19 23:26 ` Jason Gunthorpe
2024-03-19 23:26 ` Jason Gunthorpe
2024-03-20 6:16 ` Christophe Leroy
2024-03-20 6:16 ` Christophe Leroy
2024-03-20 6:16 ` Christophe Leroy
2024-03-20 16:09 ` Peter Xu
2024-03-20 16:09 ` Peter Xu
2024-03-20 16:09 ` Peter Xu
2024-03-20 17:40 ` Christophe Leroy
2024-03-20 17:40 ` Christophe Leroy
2024-03-20 17:40 ` Christophe Leroy
2024-03-20 20:24 ` Peter Xu
2024-03-20 20:24 ` Peter Xu
2024-03-20 20:24 ` Peter Xu
2024-03-13 21:47 ` [PATCH 10/13] mm/gup: Merge pXd huge mapping checks peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` [PATCH 11/13] mm/treewide: Replace pXd_huge() with pXd_leaf() peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` peterx
2024-03-14 8:50 ` Christophe Leroy
2024-03-14 8:50 ` Christophe Leroy
2024-03-14 8:50 ` Christophe Leroy
2024-03-14 12:59 ` Peter Xu
2024-03-14 12:59 ` Peter Xu
2024-03-14 12:59 ` Peter Xu
2024-03-18 16:16 ` Jason Gunthorpe [this message]
2024-03-18 16:16 ` Jason Gunthorpe
2024-03-18 16:16 ` Jason Gunthorpe
2024-03-13 21:47 ` [PATCH 12/13] mm/treewide: Remove pXd_huge() peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` peterx
2024-03-14 8:56 ` Christophe Leroy
2024-03-14 8:56 ` Christophe Leroy
2024-03-14 8:56 ` Christophe Leroy
2024-03-14 14:08 ` Peter Xu
2024-03-14 14:08 ` Peter Xu
2024-03-14 14:08 ` Peter Xu
2024-03-13 21:47 ` [PATCH 13/13] mm: Document pXd_leaf() API peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` peterx
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240318161623.GB5825@nvidia.com \
--to=jgg@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=muchun.song@linux.dev \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.