From: Simon Horman <horms@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: Wojciech Drewek <wojciech.drewek@intel.com>,
netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [iwl-net v1 2/2] ice: tc: allow zero flags in parsing tc flower
Date: Tue, 19 Mar 2024 11:36:36 +0000 [thread overview]
Message-ID: <20240319113636.GF185808@kernel.org> (raw)
In-Reply-To: <20240315110821.511321-3-michal.swiatkowski@linux.intel.com>
On Fri, Mar 15, 2024 at 12:08:21PM +0100, Michal Swiatkowski wrote:
> The check for flags is done to not pass empty lookups to adding switch
> rule functions. Since metadata is always added to lookups there is no
> need to check against the flag.
>
> It is also fixing the problem with such rule:
> $ tc filter add dev gtp_dev ingress protocol ip prio 0 flower \
> enc_dst_port 2123 action drop
> Switch block in case of GTP can't parse the destination port, because it
> should always be set to GTP specific value. The same with ethertype. The
> result is that there is no other matching criteria than GTP tunnel. In
> this case flags is 0, rule can't be added only because of defensive
> check against flags.
>
> Fixes: 9a225f81f540 ("ice: Support GTP-U and GTP-C offload in switchdev")
> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Wojciech Drewek <wojciech.drewek@intel.com>
Subject: Re: [iwl-net v1 2/2] ice: tc: allow zero flags in parsing tc flower
Date: Tue, 19 Mar 2024 11:36:36 +0000 [thread overview]
Message-ID: <20240319113636.GF185808@kernel.org> (raw)
In-Reply-To: <20240315110821.511321-3-michal.swiatkowski@linux.intel.com>
On Fri, Mar 15, 2024 at 12:08:21PM +0100, Michal Swiatkowski wrote:
> The check for flags is done to not pass empty lookups to adding switch
> rule functions. Since metadata is always added to lookups there is no
> need to check against the flag.
>
> It is also fixing the problem with such rule:
> $ tc filter add dev gtp_dev ingress protocol ip prio 0 flower \
> enc_dst_port 2123 action drop
> Switch block in case of GTP can't parse the destination port, because it
> should always be set to GTP specific value. The same with ethertype. The
> result is that there is no other matching criteria than GTP tunnel. In
> this case flags is 0, rule can't be added only because of defensive
> check against flags.
>
> Fixes: 9a225f81f540 ("ice: Support GTP-U and GTP-C offload in switchdev")
> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-03-19 11:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 11:08 [Intel-wired-lan] [iwl-net v1 0/2] ice: two fixes for tc code Michal Swiatkowski
2024-03-15 11:08 ` Michal Swiatkowski
2024-03-15 11:08 ` [Intel-wired-lan] [iwl-net v1 1/2] ice: tc: check src_vsi in case of traffic from VF Michal Swiatkowski
2024-03-15 11:08 ` Michal Swiatkowski
2024-03-19 11:36 ` [Intel-wired-lan] " Simon Horman
2024-03-19 11:36 ` Simon Horman
2024-04-12 6:37 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2024-04-12 6:37 ` Buvaneswaran, Sujai
2024-03-15 11:08 ` [Intel-wired-lan] [iwl-net v1 2/2] ice: tc: allow zero flags in parsing tc flower Michal Swiatkowski
2024-03-15 11:08 ` Michal Swiatkowski
2024-03-19 11:36 ` Simon Horman [this message]
2024-03-19 11:36 ` Simon Horman
2024-04-12 6:38 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2024-04-12 6:38 ` Buvaneswaran, Sujai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240319113636.GF185808@kernel.org \
--to=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.