From: Sean Anderson <sean.anderson@linux.dev>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org
Cc: Michal Simek <michal.simek@amd.com>,
David Airlie <airlied@gmail.com>,
linux-kernel@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>,
linux-arm-kernel@lists.infradead.org,
Sean Anderson <sean.anderson@linux.dev>
Subject: [PATCH v2 4/8] drm: zynqmp_dp: Rearrange zynqmp_dp for better padding
Date: Tue, 19 Mar 2024 18:51:17 -0400 [thread overview]
Message-ID: <20240319225122.3048400-5-sean.anderson@linux.dev> (raw)
In-Reply-To: <20240319225122.3048400-1-sean.anderson@linux.dev>
Sort the members of struct zynqmp_dp to reduce padding necessary for
alignment.
Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
---
Changes in v2:
- New
drivers/gpu/drm/xlnx/zynqmp_dp.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
index 8635b5673386..f1834c8e3c02 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
@@ -255,10 +255,10 @@ struct zynqmp_dp_link_config {
* @fmt: format identifier string
*/
struct zynqmp_dp_mode {
- u8 bw_code;
- u8 lane_cnt;
- int pclock;
const char *fmt;
+ int pclock;
+ u8 bw_code;
+ u8 lane_cnt;
};
/**
@@ -295,27 +295,27 @@ struct zynqmp_dp_config {
* @train_set: set of training data
*/
struct zynqmp_dp {
+ struct drm_dp_aux aux;
+ struct drm_bridge bridge;
+ struct delayed_work hpd_work;
+
+ struct drm_bridge *next_bridge;
struct device *dev;
struct zynqmp_dpsub *dpsub;
void __iomem *iomem;
struct reset_control *reset;
- int irq;
-
- struct drm_bridge bridge;
- struct drm_bridge *next_bridge;
-
- struct zynqmp_dp_config config;
- struct drm_dp_aux aux;
struct phy *phy[ZYNQMP_DP_MAX_LANES];
- u8 num_lanes;
- struct delayed_work hpd_work;
+
enum drm_connector_status status;
+ int irq;
bool enabled;
- u8 dpcd[DP_RECEIVER_CAP_SIZE];
- struct zynqmp_dp_link_config link_config;
struct zynqmp_dp_mode mode;
+ struct zynqmp_dp_link_config link_config;
+ struct zynqmp_dp_config config;
+ u8 dpcd[DP_RECEIVER_CAP_SIZE];
u8 train_set[ZYNQMP_DP_MAX_LANES];
+ u8 num_lanes;
};
static inline struct zynqmp_dp *bridge_to_dp(struct drm_bridge *bridge)
--
2.35.1.1320.gc452695387.dirty
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sean Anderson <sean.anderson@linux.dev>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org
Cc: Michal Simek <michal.simek@amd.com>,
David Airlie <airlied@gmail.com>,
linux-kernel@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>,
linux-arm-kernel@lists.infradead.org,
Sean Anderson <sean.anderson@linux.dev>
Subject: [PATCH v2 4/8] drm: zynqmp_dp: Rearrange zynqmp_dp for better padding
Date: Tue, 19 Mar 2024 18:51:17 -0400 [thread overview]
Message-ID: <20240319225122.3048400-5-sean.anderson@linux.dev> (raw)
In-Reply-To: <20240319225122.3048400-1-sean.anderson@linux.dev>
Sort the members of struct zynqmp_dp to reduce padding necessary for
alignment.
Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
---
Changes in v2:
- New
drivers/gpu/drm/xlnx/zynqmp_dp.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
index 8635b5673386..f1834c8e3c02 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
@@ -255,10 +255,10 @@ struct zynqmp_dp_link_config {
* @fmt: format identifier string
*/
struct zynqmp_dp_mode {
- u8 bw_code;
- u8 lane_cnt;
- int pclock;
const char *fmt;
+ int pclock;
+ u8 bw_code;
+ u8 lane_cnt;
};
/**
@@ -295,27 +295,27 @@ struct zynqmp_dp_config {
* @train_set: set of training data
*/
struct zynqmp_dp {
+ struct drm_dp_aux aux;
+ struct drm_bridge bridge;
+ struct delayed_work hpd_work;
+
+ struct drm_bridge *next_bridge;
struct device *dev;
struct zynqmp_dpsub *dpsub;
void __iomem *iomem;
struct reset_control *reset;
- int irq;
-
- struct drm_bridge bridge;
- struct drm_bridge *next_bridge;
-
- struct zynqmp_dp_config config;
- struct drm_dp_aux aux;
struct phy *phy[ZYNQMP_DP_MAX_LANES];
- u8 num_lanes;
- struct delayed_work hpd_work;
+
enum drm_connector_status status;
+ int irq;
bool enabled;
- u8 dpcd[DP_RECEIVER_CAP_SIZE];
- struct zynqmp_dp_link_config link_config;
struct zynqmp_dp_mode mode;
+ struct zynqmp_dp_link_config link_config;
+ struct zynqmp_dp_config config;
+ u8 dpcd[DP_RECEIVER_CAP_SIZE];
u8 train_set[ZYNQMP_DP_MAX_LANES];
+ u8 num_lanes;
};
static inline struct zynqmp_dp *bridge_to_dp(struct drm_bridge *bridge)
--
2.35.1.1320.gc452695387.dirty
next prev parent reply other threads:[~2024-03-19 22:52 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 22:51 [PATCH v2 0/8] drm: zynqmp_dp: Misc. patches and debugfs support Sean Anderson
2024-03-19 22:51 ` Sean Anderson
2024-03-19 22:51 ` [PATCH v2 1/8] drm: xlnx: Fix kerneldoc Sean Anderson
2024-03-19 22:51 ` Sean Anderson
2024-03-20 5:42 ` Tomi Valkeinen
2024-03-20 5:42 ` Tomi Valkeinen
2024-03-20 6:05 ` Randy Dunlap
2024-03-20 6:05 ` Randy Dunlap
2024-03-21 15:33 ` Sean Anderson
2024-03-21 15:33 ` Sean Anderson
2024-03-22 5:50 ` Tomi Valkeinen
2024-03-22 5:50 ` Tomi Valkeinen
2024-03-22 15:22 ` Sean Anderson
2024-03-22 15:22 ` Sean Anderson
2024-03-19 22:51 ` [PATCH v2 2/8] drm: zynqmp_dp: Downgrade log level for aux retries message Sean Anderson
2024-03-19 22:51 ` Sean Anderson
2024-03-20 5:46 ` Tomi Valkeinen
2024-03-20 5:46 ` Tomi Valkeinen
2024-03-19 22:51 ` [PATCH v2 3/8] drm: zynqmp_dp: Adjust training values per-lane Sean Anderson
2024-03-19 22:51 ` Sean Anderson
2024-03-20 5:57 ` Tomi Valkeinen
2024-03-20 5:57 ` Tomi Valkeinen
2024-03-21 15:35 ` Sean Anderson
2024-03-21 15:35 ` Sean Anderson
2024-03-19 22:51 ` Sean Anderson [this message]
2024-03-19 22:51 ` [PATCH v2 4/8] drm: zynqmp_dp: Rearrange zynqmp_dp for better padding Sean Anderson
2024-03-20 6:14 ` Tomi Valkeinen
2024-03-20 6:14 ` Tomi Valkeinen
2024-03-21 15:43 ` Sean Anderson
2024-03-21 15:43 ` Sean Anderson
2024-03-19 22:51 ` [PATCH v2 5/8] drm: zynqmp_dp: Don't retrain the link in our IRQ Sean Anderson
2024-03-19 22:51 ` Sean Anderson
2024-03-20 6:53 ` Tomi Valkeinen
2024-03-20 6:53 ` Tomi Valkeinen
2024-03-21 15:52 ` Sean Anderson
2024-03-21 15:52 ` Sean Anderson
2024-03-21 17:25 ` Tomi Valkeinen
2024-03-21 17:25 ` Tomi Valkeinen
2024-03-21 18:01 ` Sean Anderson
2024-03-21 18:01 ` Sean Anderson
2024-03-21 19:08 ` Tomi Valkeinen
2024-03-21 19:08 ` Tomi Valkeinen
2024-03-21 19:17 ` Sean Anderson
2024-03-21 19:17 ` Sean Anderson
2024-03-22 5:32 ` Tomi Valkeinen
2024-03-22 5:32 ` Tomi Valkeinen
2024-03-22 16:18 ` Sean Anderson
2024-03-22 16:18 ` Sean Anderson
2024-03-22 18:09 ` Tomi Valkeinen
2024-03-22 18:09 ` Tomi Valkeinen
2024-03-22 21:22 ` Sean Anderson
2024-03-22 21:22 ` Sean Anderson
2024-03-23 8:54 ` Tomi Valkeinen
2024-03-23 8:54 ` Tomi Valkeinen
2024-03-19 22:51 ` [PATCH v2 6/8] drm: zynqmp_dp: Add locking Sean Anderson
2024-03-19 22:51 ` Sean Anderson
2024-03-19 22:51 ` [PATCH v2 7/8] drm: zynqmp_dp: Split off several helper functions Sean Anderson
2024-03-19 22:51 ` Sean Anderson
2024-03-20 7:36 ` Tomi Valkeinen
2024-03-20 7:36 ` Tomi Valkeinen
2024-03-19 22:51 ` [PATCH v2 8/8] drm: zynqmp_dp: Add debugfs interface for compliance testing Sean Anderson
2024-03-19 22:51 ` Sean Anderson
2024-03-20 7:49 ` Tomi Valkeinen
2024-03-20 7:49 ` Tomi Valkeinen
2024-03-21 16:08 ` Sean Anderson
2024-03-21 16:08 ` Sean Anderson
2024-03-21 16:31 ` Tomi Valkeinen
2024-03-21 16:31 ` Tomi Valkeinen
2024-03-21 16:35 ` Sean Anderson
2024-03-21 16:35 ` Sean Anderson
2024-03-19 23:02 ` [PATCH v2 0/8] drm: zynqmp_dp: Misc. patches and debugfs support Sean Anderson
2024-03-19 23:02 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240319225122.3048400-5-sean.anderson@linux.dev \
--to=sean.anderson@linux.dev \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=michal.simek@amd.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.