From: Eugen Hristev <eugen.hristev@collabora.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, jaegeuk@kernel.org, chao@kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel@collabora.com,
eugen.hristev@collabora.com, viro@zeniv.linux.org.uk,
brauner@kernel.org, jack@suse.cz, krisman@suse.de,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: [PATCH v14 6/9] ext4: Log error when lookup of encoded dentry fails
Date: Wed, 20 Mar 2024 10:46:19 +0200 [thread overview]
Message-ID: <20240320084622.46643-7-eugen.hristev@collabora.com> (raw)
In-Reply-To: <20240320084622.46643-1-eugen.hristev@collabora.com>
From: Gabriel Krisman Bertazi <krisman@collabora.com>
If the volume is in strict mode, ext4_ci_compare can report a broken
encoding name. This will not trigger on a bad lookup, which is caught
earlier, only if the actual disk name is bad.
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
---
fs/ext4/namei.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 2d0ee232fbe7..3268cf45d9db 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -1477,6 +1477,9 @@ static bool ext4_match(struct inode *parent,
* only case where it happens is on a disk
* corruption or ENOMEM.
*/
+ if (ret == -EINVAL)
+ EXT4_ERROR_INODE(parent,
+ "Directory contains filename that is invalid UTF-8");
return false;
}
return ret;
--
2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Eugen Hristev via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, jaegeuk@kernel.org, chao@kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Cc: krisman@suse.de, brauner@kernel.org, jack@suse.cz,
linux-kernel@vger.kernel.org, eugen.hristev@collabora.com,
viro@zeniv.linux.org.uk, kernel@collabora.com,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: [f2fs-dev] [PATCH v14 6/9] ext4: Log error when lookup of encoded dentry fails
Date: Wed, 20 Mar 2024 10:46:19 +0200 [thread overview]
Message-ID: <20240320084622.46643-7-eugen.hristev@collabora.com> (raw)
In-Reply-To: <20240320084622.46643-1-eugen.hristev@collabora.com>
From: Gabriel Krisman Bertazi <krisman@collabora.com>
If the volume is in strict mode, ext4_ci_compare can report a broken
encoding name. This will not trigger on a bad lookup, which is caught
earlier, only if the actual disk name is bad.
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
---
fs/ext4/namei.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 2d0ee232fbe7..3268cf45d9db 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -1477,6 +1477,9 @@ static bool ext4_match(struct inode *parent,
* only case where it happens is on a disk
* corruption or ENOMEM.
*/
+ if (ret == -EINVAL)
+ EXT4_ERROR_INODE(parent,
+ "Directory contains filename that is invalid UTF-8");
return false;
}
return ret;
--
2.34.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2024-03-20 8:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 8:46 [PATCH v14 0/9] Cache insensitive cleanup for ext4/f2fs Eugen Hristev
2024-03-20 8:46 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-03-20 8:46 ` [PATCH v14 1/9] ext4: Simplify the handling of cached insensitive names Eugen Hristev
2024-03-20 8:46 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-03-20 8:46 ` [PATCH v14 2/9] f2fs: " Eugen Hristev
2024-03-20 8:46 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-03-20 8:46 ` [PATCH v14 3/9] libfs: Introduce case-insensitive string comparison helper Eugen Hristev
2024-03-20 8:46 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-03-20 8:46 ` [PATCH v14 4/9] ext4: Reuse generic_ci_match for ci comparisons Eugen Hristev
2024-03-20 8:46 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-03-20 8:46 ` [PATCH v14 5/9] f2fs: " Eugen Hristev
2024-03-20 8:46 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-03-20 8:46 ` Eugen Hristev [this message]
2024-03-20 8:46 ` [f2fs-dev] [PATCH v14 6/9] ext4: Log error when lookup of encoded dentry fails Eugen Hristev via Linux-f2fs-devel
2024-03-20 8:46 ` [PATCH v14 7/9] f2fs: " Eugen Hristev
2024-03-20 8:46 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-03-22 22:11 ` Gabriel Krisman Bertazi
2024-03-22 22:11 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-03-20 8:46 ` [PATCH v14 8/9] ext4: Move CONFIG_UNICODE defguards into the code flow Eugen Hristev
2024-03-20 8:46 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-03-25 16:26 ` Gabriel Krisman Bertazi
2024-03-25 16:26 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-03-20 8:46 ` [PATCH v14 9/9] f2fs: " Eugen Hristev
2024-03-20 8:46 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240320084622.46643-7-eugen.hristev@collabora.com \
--to=eugen.hristev@collabora.com \
--cc=adilger.kernel@dilger.ca \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=krisman@suse.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.