From: Simon Horman <horms@kernel.org>
To: Erwan Velu <erwanaliasr1@gmail.com>
Cc: Erwan Velu <e.velu@criteo.com>,
linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,
intel-wired-lan@lists.osuosl.org,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] i40e: Report MFS in decimal base instead of hex
Date: Wed, 20 Mar 2024 11:19:26 +0000 [thread overview]
Message-ID: <20240320111926.GR185808@kernel.org> (raw)
In-Reply-To: <20240319141657.2783609-1-e.velu@criteo.com>
On Tue, Mar 19, 2024 at 03:16:55PM +0100, Erwan Velu wrote:
> If the MFS is set below the default (0x2600), a warning message is
> reported like the following :
>
> MFS for port 1 has been set below the default: 600
>
> This message is a bit confusing as the number shown here (600) is in
> fact an hexa number: 0x600 = 1536
>
> Without any explicit "0x" prefix, this message is read like the MFS is
> set to 600 bytes.
>
> MFS, as per MTUs, are usually expressed in decimal base.
>
> This commit reports both current and default MFS values in decimal
> so it's less confusing for end-users.
>
> A typical warning message looks like the following :
>
> MFS for port 1 (1536) has been set below the default (9728)
>
Hi Erwan,
If this is for (iwl-)net, then it should probably have a Fixes tag.
I expect it is sufficient to respond to this email with an appropriate tag.
> Signed-off-by: Erwan Velu <e.velu@criteo.com>
That not withstanding, this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
...
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Erwan Velu <erwanaliasr1@gmail.com>
Cc: Erwan Velu <e.velu@criteo.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH iwl-net] i40e: Report MFS in decimal base instead of hex
Date: Wed, 20 Mar 2024 11:19:26 +0000 [thread overview]
Message-ID: <20240320111926.GR185808@kernel.org> (raw)
In-Reply-To: <20240319141657.2783609-1-e.velu@criteo.com>
On Tue, Mar 19, 2024 at 03:16:55PM +0100, Erwan Velu wrote:
> If the MFS is set below the default (0x2600), a warning message is
> reported like the following :
>
> MFS for port 1 has been set below the default: 600
>
> This message is a bit confusing as the number shown here (600) is in
> fact an hexa number: 0x600 = 1536
>
> Without any explicit "0x" prefix, this message is read like the MFS is
> set to 600 bytes.
>
> MFS, as per MTUs, are usually expressed in decimal base.
>
> This commit reports both current and default MFS values in decimal
> so it's less confusing for end-users.
>
> A typical warning message looks like the following :
>
> MFS for port 1 (1536) has been set below the default (9728)
>
Hi Erwan,
If this is for (iwl-)net, then it should probably have a Fixes tag.
I expect it is sufficient to respond to this email with an appropriate tag.
> Signed-off-by: Erwan Velu <e.velu@criteo.com>
That not withstanding, this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
...
next prev parent reply other threads:[~2024-03-20 11:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 14:16 [Intel-wired-lan] [PATCH iwl-net] i40e: Report MFS in decimal base instead of hex Erwan Velu
2024-03-19 14:16 ` Erwan Velu
2024-03-20 11:19 ` Simon Horman [this message]
2024-03-20 11:19 ` Simon Horman
2024-04-16 23:11 ` [Intel-wired-lan] " Brelinski, Tony
2024-04-16 23:11 ` Brelinski, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240320111926.GR185808@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=e.velu@criteo.com \
--cc=edumazet@google.com \
--cc=erwanaliasr1@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.