From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [CI 7/8] drm/xe/bo: Allow eviction of unbound local bos
Date: Wed, 20 Mar 2024 14:43:55 +0100 [thread overview]
Message-ID: <20240320134356.73655-7-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20240320134356.73655-1-thomas.hellstrom@linux.intel.com>
Local bos that don't have any gpu_vmas set up are allowed
to be evicted. Support that.
Fixes: 24f947d58fe5 ("drm/xe: Use DRM GPUVM helpers for external- and evicted objects")
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
drivers/gpu/drm/xe/xe_bo.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
index db4cd1da8ef3..87e6aff52ca6 100644
--- a/drivers/gpu/drm/xe/xe_bo.c
+++ b/drivers/gpu/drm/xe/xe_bo.c
@@ -1029,10 +1029,14 @@ static bool xe_bo_eviction_valuable(struct ttm_buffer_object *ttm_bo,
if (vm && !drm_gpuvm_is_extobj(&vm->gpuvm, &ttm_bo->base) &&
vm->is_validating) {
xe_vm_assert_held(vm);
+ /* Not bound to the vm? */
+ if (list_empty(&ttm_bo->base.gpuva.list))
+ goto allow;
return false;
}
}
+allow:
return ttm_bo_eviction_valuable(ttm_bo, place);
}
--
2.44.0
next prev parent reply other threads:[~2024-03-20 13:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 13:43 [CI 1/8] drm/xe: Make TLB invalidation fences unordered Thomas Hellström
2024-03-20 13:43 ` [CI 2/8] drm/xe: Use ring ops TLB invalidation for rebinds Thomas Hellström
2024-03-20 13:43 ` [CI 3/8] drm/xe: Reserve fences where needed Thomas Hellström
2024-03-20 13:43 ` [CI 4/8] drm/xe: Rework rebinding Thomas Hellström
2024-03-20 13:43 ` [CI 5/8] drm/xe: Move vma rebinding to the drm_exec locking loop Thomas Hellström
2024-03-20 13:43 ` [CI 6/8] drm/xe/bo: Forward the decision to evict local objects during validation Thomas Hellström
2024-03-20 13:43 ` Thomas Hellström [this message]
2024-03-20 13:43 ` [CI 8/8] drm/xe/bo: Allow migrating local bos to TT to make room in VRAM Thomas Hellström
2024-03-20 13:48 ` ✓ CI.Patch_applied: success for series starting with [CI,1/8] drm/xe: Make TLB invalidation fences unordered Patchwork
2024-03-20 13:49 ` ✓ CI.checkpatch: " Patchwork
2024-03-20 13:50 ` ✓ CI.KUnit: " Patchwork
2024-03-20 14:00 ` ✓ CI.Build: " Patchwork
2024-03-20 14:03 ` ✓ CI.Hooks: " Patchwork
2024-03-20 14:04 ` ✓ CI.checksparse: " Patchwork
2024-03-20 14:36 ` ✗ CI.BAT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-03-20 10:10 [CI 1/8] " Thomas Hellström
2024-03-20 10:10 ` [CI 7/8] drm/xe/bo: Allow eviction of unbound local bos Thomas Hellström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240320134356.73655-7-thomas.hellstrom@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.