Re: [PATCH net v2 0/2] MT7530 DSA subdriver fix VLAN egress and handling of all link-local frames

From: Jakub Kicinski <kuba@kernel.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: "Arınç ÜNAL" <arinc.unal@arinc9.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Daniel Golle" <daniel@makrotopia.org>,
	"DENG Qingfang" <dqfext@gmail.com>,
	"Sean Wang" <sean.wang@mediatek.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	"Bartel Eerdekens" <bartel.eerdekens@constell8.be>,
	erkin.bozoglu@xeront.com, mithat.guner@xeront.com
Subject: Re: [PATCH net v2 0/2] MT7530 DSA subdriver fix VLAN egress and handling of all link-local frames
Date: Thu, 21 Mar 2024 07:42:24 -0700	[thread overview]
Message-ID: <20240321074224.5850c05e@kernel.org> (raw)
In-Reply-To: <20240321-tentacled-pearl-ferret-efd5be@lemur>

On Thu, 21 Mar 2024 09:19:02 -0400 Konstantin Ryabitsev wrote:
> On Thu, Mar 21, 2024 at 02:29:19PM +0300, Arınç ÜNAL wrote:
> > > For future memory: I think the SoB in the cover letter is not required,
> > > and is, at least to me, a bit confusing.
> > > 
> > > No action needed here, I'll keep this unmodified, but I suggest to omit
> > > it in future submission.  
> > 
> > b4 puts it on the cover letter so it's not my doing.  
> 
> This is done because many subsystems use the cover letter as the merge commit
> message. 

Could be wrong, but I think it was DaveM who originated this practice,
in networking..

> Those subsystems who don't follow this practice don't generally care
> if there's a Signed-Off-By in the cover letter anyway, so I don't see why this
> is a concern that it's there.

Because we have to remove it, extra work. And the benefit of adding it
in the first place is unclear.