Re: [PATCH 1/4] dt-bindings: arm: qcom,coresight-funnel: Add label for multi-ouput

From: Rob Herring <robh@kernel.org>
To: Tao Zhang <quic_taozha@quicinc.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Konrad Dybcio <konradybcio@gmail.com>,
	Mike Leach <mike.leach@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Jinlong Mao <quic_jinlmao@quicinc.com>,
	Leo Yan <leo.yan@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Tingwei Zhang <quic_tingweiz@quicinc.com>,
	Yuanfang Zhang <quic_yuanfang@quicinc.com>,
	Trilok Soni <quic_tsoni@quicinc.com>,
	Song Chai <quic_songchai@quicinc.com>,
	linux-arm-msm@vger.kernel.org, andersson@kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: arm: qcom,coresight-funnel: Add label for multi-ouput
Date: Thu, 21 Mar 2024 09:42:26 -0500	[thread overview]
Message-ID: <20240321144226.GA1689544-robh@kernel.org> (raw)
In-Reply-To: <1711009927-17873-2-git-send-email-quic_taozha@quicinc.com>

On Thu, Mar 21, 2024 at 04:32:04PM +0800, Tao Zhang wrote:
> Add new property "label" to label the source corresponding to the
> output connection. When the funnel supports multi-output, this
> property needs to be introduced to mark which source component a
> certain output connection corresponds to.
> 
> Signed-off-by: Tao Zhang <quic_taozha@quicinc.com>
> ---
>  .../arm/arm,coresight-dynamic-funnel.yaml     | 34 ++++++++++++++++---
>  1 file changed, 30 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
> index 44a1041cb0fc..cde62c286d29 100644
> --- a/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
> @@ -66,13 +66,39 @@ properties:
>          $ref: /schemas/graph.yaml#/properties/port
>  
>    out-ports:
> -    $ref: /schemas/graph.yaml#/properties/ports
> -    additionalProperties: false
> -
> +    type: object
>      properties:
> +      "#address-cells":
> +        const: 1
> +
> +      "#size-cells":
> +        const: 0
> +
>        port:
> +        type: object
> +
> +    patternProperties:
> +      '^port(@[0-7])?$':
> +        type: object
>          description: Output connection to CoreSight Trace bus
> -        $ref: /schemas/graph.yaml#/properties/port

Nope, now you have no constraints on port node properties. Please look 
at how other bindings are done to add properties on endpoint node.

> +
> +        patternProperties:
> +          "^endpoint(@[0-9a-f]+)?$":
> +            type: object
> +            properties:
> +              remote-endpoint:
> +                description: |
> +                  phandle to an 'endpoint' subnode of a remote device node.
> +                  $ref: /schemas/types.yaml#/definitions/phandle

Don't need this.

> +              label:
> +                description: Label the source corresponding to the output connection
> +                $ref: /schemas/types.yaml#/definitions/string

label already has a type.

As this node is an output, aren't you labeling what the destination is, 
not the "source"?

Why can't you look at the remote connection to identify what it is?

> +    oneOf:
> +      - required:
> +          - port
> +      - required:
> +          - "#address-cells"
> +          - "#size-cells"

The common schema that you removed handles this.

Rob