From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 1/2] libswap: add two methods to create swapfile
Date: Fri, 22 Mar 2024 06:32:17 +0100 [thread overview]
Message-ID: <20240322053217.GA588706@pevik> (raw)
In-Reply-To: <CAEemH2c3SNktFnPpsnbXvtTvfEv84byRrNmjcz3YyQHem9mcGg@mail.gmail.com>
Hi Li,
> > - char mnt_path[100];
> > + char mnt_path[128];
> > nit: why this increase to 128? Why not PATH_MAX?
> No special meaning, I just thought of using 2 raised to the nth power.
> But you're right, PATCH_MAX will be safer.
+1
...
> Thanks, I would give the patch set more time in case others have comments.
Sure. Thanks for a nice work!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-03-22 5:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 3:02 [LTP] [PATCH v3 1/2] libswap: add two methods to create swapfile Li Wang
2024-03-22 3:02 ` [LTP] [PATCH v3 2/2] swapon01: create 128MB swapfile Li Wang
2024-03-22 5:00 ` [LTP] [PATCH v3 1/2] libswap: add two methods to create swapfile Petr Vorel
2024-03-22 5:26 ` Li Wang
2024-03-22 5:32 ` Petr Vorel [this message]
2024-03-25 2:53 ` Li Wang
2024-04-15 15:20 ` Petr Vorel
2024-04-16 6:35 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240322053217.GA588706@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.