* [cel:nfsd-5.15.y 1/391] include/linux/fsnotify.h:235:52: error: too few arguments to function call, expected 6, have 5
@ 2024-03-25 0:47 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-03-25 0:47 UTC (permalink / raw)
To: Amir Goldstein
Cc: llvm, oe-kbuild-all, Chuck Lever, Jan Kara,
Gabriel Krisman Bertazi
tree: git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux nfsd-5.15.y
head: 00f016a743ef8a7ac9a13c48499a67614a0077ed
commit: af7130545d85312d5caf9c37e308db100ac172ac [1/391] fsnotify: pass data_type to fsnotify_name()
config: arm-allnoconfig (https://download.01.org/0day-ci/archive/20240325/202403250847.mkfBiQLx-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 23de3862dce582ce91c1aa914467d982cb1a73b4)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240325/202403250847.mkfBiQLx-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403250847.mkfBiQLx-lkp@intel.com/
Note: the cel/nfsd-5.15.y HEAD 00f016a743ef8a7ac9a13c48499a67614a0077ed builds fine.
It only hurts bisectability.
All errors (new ones prefixed by >>):
In file included from fs/kernfs/file.c:14:
In file included from include/linux/pagemap.h:8:
In file included from include/linux/mm.h:1608:
include/linux/vmstat.h:450:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
450 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
In file included from fs/kernfs/file.c:16:
>> include/linux/fsnotify.h:235:52: error: too few arguments to function call, expected 6, have 5
235 | fsnotify_name(dir, mask, inode, &dentry->d_name, 0);
| ~~~~~~~~~~~~~ ^
include/linux/fsnotify.h:29:19: note: 'fsnotify_name' declared here
29 | static inline int fsnotify_name(__u32 mask, const void *data, int data_type,
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
30 | struct inode *dir, const struct qstr *name,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
31 | u32 cookie)
| ~~~~~~~~~~
fs/kernfs/file.c:128:15: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
128 | return NULL + !*ppos;
| ~~~~ ^
2 warnings and 1 error generated.
vim +235 include/linux/fsnotify.h
ece95912db94d9 Jan Kara 2008-02-06 218
3d7b7272ce9deb Amir Goldstein 2022-01-20 219 /*
3d7b7272ce9deb Amir Goldstein 2022-01-20 220 * fsnotify_delete - @dentry was unlinked and unhashed
3d7b7272ce9deb Amir Goldstein 2022-01-20 221 *
3d7b7272ce9deb Amir Goldstein 2022-01-20 222 * Caller must make sure that dentry->d_name is stable.
3d7b7272ce9deb Amir Goldstein 2022-01-20 223 *
3d7b7272ce9deb Amir Goldstein 2022-01-20 224 * Note: unlike fsnotify_unlink(), we have to pass also the unlinked inode
3d7b7272ce9deb Amir Goldstein 2022-01-20 225 * as this may be called after d_delete() and old_dentry may be negative.
3d7b7272ce9deb Amir Goldstein 2022-01-20 226 */
3d7b7272ce9deb Amir Goldstein 2022-01-20 227 static inline void fsnotify_delete(struct inode *dir, struct inode *inode,
3d7b7272ce9deb Amir Goldstein 2022-01-20 228 struct dentry *dentry)
3d7b7272ce9deb Amir Goldstein 2022-01-20 229 {
3d7b7272ce9deb Amir Goldstein 2022-01-20 230 __u32 mask = FS_DELETE;
3d7b7272ce9deb Amir Goldstein 2022-01-20 231
3d7b7272ce9deb Amir Goldstein 2022-01-20 232 if (S_ISDIR(inode->i_mode))
3d7b7272ce9deb Amir Goldstein 2022-01-20 233 mask |= FS_ISDIR;
3d7b7272ce9deb Amir Goldstein 2022-01-20 234
3d7b7272ce9deb Amir Goldstein 2022-01-20 @235 fsnotify_name(dir, mask, inode, &dentry->d_name, 0);
3d7b7272ce9deb Amir Goldstein 2022-01-20 236 }
3d7b7272ce9deb Amir Goldstein 2022-01-20 237
:::::: The code at line 235 was first introduced by commit
:::::: 3d7b7272ce9deb7157670f584274f37d8b12f81f fsnotify: invalidate dcache before IN_DELETE event
:::::: TO: Amir Goldstein <amir73il@gmail.com>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-03-25 0:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-25 0:47 [cel:nfsd-5.15.y 1/391] include/linux/fsnotify.h:235:52: error: too few arguments to function call, expected 6, have 5 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.