Re: [PATCH 4/8] rust: add driver abstraction

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Mar 26, 2024 at 05:36:14AM +1000, David Airlie wrote:
> > I stopped here.  Please build on existing code in the kernel, and also,
> > a real user of these structures is needed to see if/how any of this
> > actually works.  Why not implement something that uses them that we can
> > actually review?
> 
> Seems like you missed where the cover letter explained that this was
> in the context of:
> https://lore.kernel.org/dri-devel/Zfsj0_tb-0-tNrJy@cassiopeiae/T/#u

Yes I did.

> Can we stop feeding the chicken/egg problem? :-) This posting attempts
> to focus people on *device* abstraction problem, by posting small
> patch series directly affecting things in an effort to get them
> reviewed, or we post the full patch series touching every subsystem
> and then nobody reviews it because it's 50 patches and it isn't
> focused on the one thing they care about.

Would you want to review new api additions without ever seeing how they
are used at all?  I can't agree to that, and neither would you, that's
not how any of this works, sorry.

I can provide general "this looks really odd" comments, but I can never
give a "acked-by:" for something that doesn't have a user, that's just
impossible.

I understand your prediciment, so work at it in tiny steps like everyone
does when adding new apis, this isn't new.

thanks,

greg k-h