Re: [PATCH 7/8] rust: add revocable objects

[Danilo Krummrich <dakr@redhat.com>]

On Mon, Mar 25, 2024 at 07:21:32PM +0100, Greg KH wrote:
> On Mon, Mar 25, 2024 at 06:49:11PM +0100, Danilo Krummrich wrote:
> > From: Wedson Almeida Filho <wedsonaf@gmail.com>
> > 
> > This implements the Revocable and AsyncRevocable types.
> > 
> > Revocable allows access to objects to be safely revoked at run time.
> > 
> > This is useful, for example, for resources allocated during device probe;
> > when the device is removed, the driver should stop accessing the device
> > resources even if other state is kept in memory due to existing
> > references (i.e., device context data is ref-counted and has a non-zero
> > refcount after removal of the device).
> 
> Again, device removal is different from unbinding a driver from a
> device.  Please fix this all up.

I think this isn't an "again", "[PATCH 8/8] rust: add device::Data" actually
phrased things differently (which indeed isn't great and needs to be fixed).

This comment indeed implies that device removal actually means unbinding a
driver from a device. I think "device remove" is meant here as the drivers
remove() callback is called.

Your comment seems to imply you have a different understanding of what "device
remove" means?

> 
> greg k-h
>