Re: [PATCH 5/5] arm64: dts: Add device tree source for the Au-Zone Maivin Starter Kit

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	Trevor Zaharichuk <trevor@au-zone.com>,
	Greg Lytle <greg@au-zone.com>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH 5/5] arm64: dts: Add device tree source for the Au-Zone Maivin Starter Kit
Date: Tue, 26 Mar 2024 11:11:00 +0200	[thread overview]
Message-ID: <20240326091100.GA17454@pendragon.ideasonboard.com> (raw)
In-Reply-To: <8fa53bf5-2467-4d21-9ac9-2824c79a0187@linaro.org>

Hi Krzysztof,

On Tue, Mar 26, 2024 at 08:12:45AM +0100, Krzysztof Kozlowski wrote:
> On 25/03/2024 21:32, Laurent Pinchart wrote:
> > The Maivin board is an AI vision starter kit sold by Au-Zone
> > Technologies, developed in collaboration with Toradex and Vision
> > Components. It is based on a Toradex Verdin i.MX8MP SoM.
> > 
> > Add a device tree that covers the base set the peripherals found on the
> > board:
> 
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching.
> And drop redundant parts.
> arm64: dts: imx8mp-maivin: Add Au-Zone Maivin Starter Kit board

Including in the command line the name of the dts that is being added
doesn't seem to be a very common practice. See for instance

6d382d51d979 arm64: dts: freescale: Add SKOV IMX8MP CPU revB board

I can use

arm64: dts: freescale Add Au-Zone Maivin Starter Kit

if you prefer.

-- 
Regards,

Laurent Pinchart