All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: llvm@lists.linux.dev, Claudiu Manoil <claudiu.manoil@nxp.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>,
	Simon Horman <horms@kernel.org>, Ferenc Fejes <fejes@inf.elte.hu>,
	Wei Fang <wei.fang@nxp.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	bpf@vger.kernel.org
Subject: [PATCH 2/9] enetc: avoid truncating error message
Date: Tue, 26 Mar 2024 23:38:01 +0100	[thread overview]
Message-ID: <20240326223825.4084412-3-arnd@kernel.org> (raw)
In-Reply-To: <20240326223825.4084412-1-arnd@kernel.org>

From: Arnd Bergmann <arnd@arndb.de>

As clang points out, the error message in enetc_setup_xdp_prog()
still does not fit in the buffer and will be truncated:

drivers/net/ethernet/freescale/enetc/enetc.c:2771:3: error: 'snprintf' will always be truncated; specified size is 80, but format string expands to at least 87 [-Werror,-Wformat-truncation]

Replace it with an even shorter message that should fit.

Fixes: f968c56417f0 ("net: enetc: shorten enetc_setup_xdp_prog() error message to fit NETLINK_MAX_FMTMSG_LEN")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/ethernet/freescale/enetc/enetc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c
index 9f07f4947b63..5c45f42232d3 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc.c
@@ -2769,7 +2769,7 @@ static int enetc_setup_xdp_prog(struct net_device *ndev, struct bpf_prog *prog,
 	if (priv->min_num_stack_tx_queues + num_xdp_tx_queues >
 	    priv->num_tx_rings) {
 		NL_SET_ERR_MSG_FMT_MOD(extack,
-				       "Reserving %d XDP TXQs does not leave a minimum of %d for stack (total %d)",
+				       "Reserving %d XDP TXQs leaves under %d for stack (total %d)",
 				       num_xdp_tx_queues,
 				       priv->min_num_stack_tx_queues,
 				       priv->num_tx_rings);
-- 
2.39.2


  parent reply	other threads:[~2024-03-26 22:39 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26 22:37 [PATCH 0/9] enabled -Wformat-truncation for clang Arnd Bergmann
2024-03-26 22:37 ` Arnd Bergmann
2024-03-26 22:38 ` [PATCH 1/9] fbdev: shmobile: fix snprintf truncation Arnd Bergmann
2024-03-26 22:42   ` Laurent Pinchart
2024-03-27  8:13   ` Helge Deller
2024-03-26 22:38 ` Arnd Bergmann [this message]
2024-03-26 22:38 ` [PATCH 3/9] qed: avoid truncating work queue length Arnd Bergmann
2024-03-27 14:04   ` [EXTERNAL] " Subbaraya Sundeep Bhatta
2024-03-27 15:34     ` Arnd Bergmann
2024-03-27 17:08       ` Subbaraya Sundeep Bhatta
2024-03-26 22:38 ` [PATCH 4/9] mlx5: avoid truncating error message Arnd Bergmann
2024-03-27 14:08   ` [EXTERNAL] " Subbaraya Sundeep Bhatta
2024-03-26 22:38 ` [PATCH 5/9] surface3_power: avoid format string truncation warning Arnd Bergmann
2024-03-26 23:05   ` Nathan Chancellor
2024-03-27 10:58     ` Andy Shevchenko
2024-04-01  6:24   ` Uwe Kleine-König
2024-03-26 22:38 ` [PATCH 6/9] Input: IMS: fix printf string overflow Arnd Bergmann
2024-03-28 20:29   ` Dmitry Torokhov
2024-03-26 22:38 ` [PATCH 7/9] scsi: mylex: fix sysfs buffer lengths Arnd Bergmann
2024-03-27  7:40   ` Hannes Reinecke
2024-03-26 22:38 ` [PATCH 8/9] ALSA: aoa: avoid false-positive format truncation warning Arnd Bergmann
2024-03-26 22:38   ` Arnd Bergmann
2024-03-27  9:54   ` Takashi Iwai
2024-03-27  9:54     ` Takashi Iwai
2024-03-26 22:38 ` [PATCH 9/9] kbuild: enable -Wformat-truncation on clang Arnd Bergmann
2024-03-27  0:47 ` [PATCH 0/9] enabled -Wformat-truncation for clang Jakub Kicinski
2024-03-27  0:47   ` Jakub Kicinski
2024-03-29 19:30 ` patchwork-bot+netdevbpf
2024-03-29 19:30   ` patchwork-bot+netdevbpf
2024-04-02  1:48 ` (subset) " Martin K. Petersen
2024-04-02  1:48   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240326223825.4084412-3-arnd@kernel.org \
    --to=arnd@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bpf@vger.kernel.org \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fejes@inf.elte.hu \
    --cc=horms@kernel.org \
    --cc=justinstitt@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vladimir.oltean@nxp.com \
    --cc=wei.fang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.