From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: llvm@lists.linux.dev, Nathan Chancellor <nathan@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
ye xingchen <ye.xingchen@zte.com.cn>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/9] Input: IMS: fix printf string overflow
Date: Thu, 28 Mar 2024 13:29:22 -0700 [thread overview]
Message-ID: <ZgXTIiCvvj-eu6p-@google.com> (raw)
In-Reply-To: <20240326223825.4084412-7-arnd@kernel.org>
On Tue, Mar 26, 2024 at 11:38:05PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> clang warns about a string overflow in this driver
>
> drivers/input/misc/ims-pcu.c:1802:2: error: 'snprintf' will always be truncated; specified size is 10, but format string expands to at least 12 [-Werror,-Wformat-truncation]
> drivers/input/misc/ims-pcu.c:1814:2: error: 'snprintf' will always be truncated; specified size is 10, but format string expands to at least 12 [-Werror,-Wformat-truncation]
>
> Make the buffer a little longer to ensure it always fits.
>
> Fixes: 628329d52474 ("Input: add IMS Passenger Control Unit driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thank you.
--
Dmitry
next prev parent reply other threads:[~2024-03-28 20:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 22:37 [PATCH 0/9] enabled -Wformat-truncation for clang Arnd Bergmann
2024-03-26 22:37 ` Arnd Bergmann
2024-03-26 22:38 ` [PATCH 1/9] fbdev: shmobile: fix snprintf truncation Arnd Bergmann
2024-03-26 22:42 ` Laurent Pinchart
2024-03-27 8:13 ` Helge Deller
2024-03-26 22:38 ` [PATCH 2/9] enetc: avoid truncating error message Arnd Bergmann
2024-03-26 22:38 ` [PATCH 3/9] qed: avoid truncating work queue length Arnd Bergmann
2024-03-27 14:04 ` [EXTERNAL] " Subbaraya Sundeep Bhatta
2024-03-27 15:34 ` Arnd Bergmann
2024-03-27 17:08 ` Subbaraya Sundeep Bhatta
2024-03-26 22:38 ` [PATCH 4/9] mlx5: avoid truncating error message Arnd Bergmann
2024-03-27 14:08 ` [EXTERNAL] " Subbaraya Sundeep Bhatta
2024-03-26 22:38 ` [PATCH 5/9] surface3_power: avoid format string truncation warning Arnd Bergmann
2024-03-26 23:05 ` Nathan Chancellor
2024-03-27 10:58 ` Andy Shevchenko
2024-04-01 6:24 ` Uwe Kleine-König
2024-03-26 22:38 ` [PATCH 6/9] Input: IMS: fix printf string overflow Arnd Bergmann
2024-03-28 20:29 ` Dmitry Torokhov [this message]
2024-03-26 22:38 ` [PATCH 7/9] scsi: mylex: fix sysfs buffer lengths Arnd Bergmann
2024-03-27 7:40 ` Hannes Reinecke
2024-03-26 22:38 ` [PATCH 8/9] ALSA: aoa: avoid false-positive format truncation warning Arnd Bergmann
2024-03-26 22:38 ` Arnd Bergmann
2024-03-27 9:54 ` Takashi Iwai
2024-03-27 9:54 ` Takashi Iwai
2024-03-26 22:38 ` [PATCH 9/9] kbuild: enable -Wformat-truncation on clang Arnd Bergmann
2024-03-27 0:47 ` [PATCH 0/9] enabled -Wformat-truncation for clang Jakub Kicinski
2024-03-27 0:47 ` Jakub Kicinski
2024-03-29 19:30 ` patchwork-bot+netdevbpf
2024-03-29 19:30 ` patchwork-bot+netdevbpf
2024-04-02 1:48 ` (subset) " Martin K. Petersen
2024-04-02 1:48 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgXTIiCvvj-eu6p-@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.