From: Jakub Kicinski <kuba@kernel.org>
To: Wojciech Drewek <wojciech.drewek@intel.com>
Cc: netdev@vger.kernel.org, idosch@nvidia.com, edumazet@google.com,
marcin.szycik@linux.intel.com, anthony.l.nguyen@intel.com,
simon.horman@corigine.com, intel-wired-lan@lists.osuosl.org,
pabeni@redhat.com, przemyslaw.kitszel@intel.com
Subject: Re: [Intel-wired-lan] [PATCH net-next 0/3] ethtool: Max power support
Date: Fri, 29 Mar 2024 15:16:03 -0700 [thread overview]
Message-ID: <20240329151603.77981289@kernel.org> (raw)
In-Reply-To: <20240329092321.16843-1-wojciech.drewek@intel.com>
On Fri, 29 Mar 2024 10:23:18 +0100 Wojciech Drewek wrote:
> Some ethernet modules use nonstandard power levels [1]. Extend ethtool
> module implementation to support new attributes that will allow user
> to change maximum power. Rename structures and functions to be more
> generic. Introduce an example of the new API in ice driver.
I'm no SFP expert but seems reasonable.
Would be good to insert more references to the SFP / CMIS specs
which describe the standard registers.
Also the series is suffering from lack of docs and spec, please
update both:
Documentation/networking/ethtool-netlink.rst
Documentation/netlink/specs/ethtool.yaml
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Wojciech Drewek <wojciech.drewek@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
simon.horman@corigine.com, anthony.l.nguyen@intel.com,
edumazet@google.com, pabeni@redhat.com, idosch@nvidia.com,
przemyslaw.kitszel@intel.com, marcin.szycik@linux.intel.com
Subject: Re: [PATCH net-next 0/3] ethtool: Max power support
Date: Fri, 29 Mar 2024 15:16:03 -0700 [thread overview]
Message-ID: <20240329151603.77981289@kernel.org> (raw)
In-Reply-To: <20240329092321.16843-1-wojciech.drewek@intel.com>
On Fri, 29 Mar 2024 10:23:18 +0100 Wojciech Drewek wrote:
> Some ethernet modules use nonstandard power levels [1]. Extend ethtool
> module implementation to support new attributes that will allow user
> to change maximum power. Rename structures and functions to be more
> generic. Introduce an example of the new API in ice driver.
I'm no SFP expert but seems reasonable.
Would be good to insert more references to the SFP / CMIS specs
which describe the standard registers.
Also the series is suffering from lack of docs and spec, please
update both:
Documentation/networking/ethtool-netlink.rst
Documentation/netlink/specs/ethtool.yaml
next prev parent reply other threads:[~2024-03-29 22:16 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 9:23 [Intel-wired-lan] [PATCH net-next 0/3] ethtool: Max power support Wojciech Drewek
2024-03-29 9:23 ` Wojciech Drewek
2024-03-29 9:23 ` [Intel-wired-lan] [PATCH net-next 1/3] ethtool: Make module API more generic Wojciech Drewek
2024-03-29 9:23 ` Wojciech Drewek
2024-03-29 9:23 ` [Intel-wired-lan] [PATCH net-next 2/3] ethtool: Introduce max power support Wojciech Drewek
2024-03-29 9:23 ` Wojciech Drewek
2024-03-29 22:29 ` [Intel-wired-lan] " Jakub Kicinski
2024-03-29 22:29 ` Jakub Kicinski
2024-03-29 22:29 ` Jakub Kicinski
2024-03-29 22:29 ` [Intel-wired-lan] " Jakub Kicinski
2024-04-02 11:25 ` Wojciech Drewek
2024-04-02 11:25 ` Wojciech Drewek
2024-04-02 14:34 ` [Intel-wired-lan] " Jakub Kicinski
2024-04-02 14:34 ` Jakub Kicinski
2024-04-03 10:19 ` [Intel-wired-lan] " Wojciech Drewek
2024-04-03 10:19 ` Wojciech Drewek
2024-04-04 0:18 ` [Intel-wired-lan] " Jakub Kicinski
2024-04-04 0:18 ` Jakub Kicinski
2024-04-04 12:19 ` [Intel-wired-lan] " Wojciech Drewek
2024-04-04 12:19 ` Wojciech Drewek
2024-03-30 22:14 ` [Intel-wired-lan] " Andrew Lunn
2024-03-30 22:14 ` Andrew Lunn
2024-03-30 22:14 ` Andrew Lunn
2024-03-30 22:14 ` [Intel-wired-lan] " Andrew Lunn
2024-04-03 9:50 ` Wojciech Drewek
2024-04-03 9:50 ` Wojciech Drewek
2024-03-29 9:23 ` [Intel-wired-lan] [PATCH net-next 3/3] ice: Implement ethtool max power configuration Wojciech Drewek
2024-03-29 9:23 ` Wojciech Drewek
2024-03-29 22:16 ` Jakub Kicinski [this message]
2024-03-29 22:16 ` [PATCH net-next 0/3] ethtool: Max power support Jakub Kicinski
2024-04-02 9:58 ` [Intel-wired-lan] " Wojciech Drewek
2024-04-02 9:58 ` Wojciech Drewek
2024-03-30 21:57 ` [Intel-wired-lan] " Andrew Lunn
2024-03-30 21:57 ` Andrew Lunn
2024-03-30 21:57 ` Andrew Lunn
2024-03-30 21:57 ` [Intel-wired-lan] " Andrew Lunn
2024-04-02 11:38 ` Wojciech Drewek
2024-04-02 11:38 ` Wojciech Drewek
2024-04-02 14:25 ` Jakub Kicinski
2024-04-02 14:25 ` Jakub Kicinski
2024-04-02 14:53 ` Andrew Lunn
2024-04-02 14:53 ` Andrew Lunn
2024-04-02 14:46 ` Andrew Lunn
2024-04-02 14:46 ` Andrew Lunn
2024-04-02 14:57 ` Jakub Kicinski
2024-04-02 14:57 ` Jakub Kicinski
2024-04-03 13:18 ` Wojciech Drewek
2024-04-03 13:18 ` Wojciech Drewek
2024-04-03 13:40 ` Andrew Lunn
2024-04-03 13:40 ` Andrew Lunn
2024-04-04 12:21 ` Wojciech Drewek
2024-04-04 12:21 ` Wojciech Drewek
2024-04-03 13:49 ` Andrew Lunn
2024-04-03 13:49 ` Andrew Lunn
2024-04-04 12:45 ` Wojciech Drewek
2024-04-04 12:45 ` Wojciech Drewek
2024-04-04 13:53 ` Andrew Lunn
2024-04-04 13:53 ` Andrew Lunn
2024-04-09 12:20 ` Wojciech Drewek
2024-04-09 12:20 ` Wojciech Drewek
2024-04-09 13:39 ` Andrew Lunn
2024-04-09 13:39 ` Andrew Lunn
2024-04-12 13:21 ` Wojciech Drewek
2024-04-12 13:21 ` Wojciech Drewek
2024-04-15 22:03 ` Andrew Lunn
2024-04-15 22:03 ` Andrew Lunn
2024-04-18 11:48 ` Wojciech Drewek
2024-04-18 11:48 ` Wojciech Drewek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240329151603.77981289@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=marcin.szycik@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=simon.horman@corigine.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.