From: Jakub Kicinski <kuba@kernel.org>
To: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, ahmed.zaki@intel.com,
aleksander.lobakin@intel.com, alexandre.torgue@foss.st.com,
andrew@lunn.ch, cjubran@nvidia.com, corbet@lwn.net,
davem@davemloft.net, dtatulea@nvidia.com, edumazet@google.com,
gal@nvidia.com, hkallweit1@gmail.com, jacob.e.keller@intel.com,
jiri@resnulli.us, joabreu@synopsys.com, justinstitt@google.com,
kory.maincent@bootlin.com, leon@kernel.org, liuhangbin@gmail.com,
maxime.chevallier@bootlin.com, pabeni@redhat.com,
paul.greenwalt@intel.com, przemyslaw.kitszel@intel.com,
rdunlap@infradead.org, richardcochran@gmail.com,
saeed@kernel.org, tariqt@nvidia.com, vadim.fedorenko@linux.dev,
vladimir.oltean@nxp.com, wojciech.drewek@intel.com
Subject: Re: [PATCH net-next v1 1/6] ethtool: add interface to read Tx hardware timestamping statistics
Date: Tue, 2 Apr 2024 19:18:42 -0700 [thread overview]
Message-ID: <20240402191842.66decfd3@kernel.org> (raw)
In-Reply-To: <20240402205223.137565-2-rrameshbabu@nvidia.com>
On Tue, 2 Apr 2024 13:52:01 -0700 Rahul Rameshbabu wrote:
> +/**
> + * struct ethtool_ts_stats - HW timestamping statistics
> + * @tx_stats: struct group for TX HW timestamping
> + * @pkts: Number of packets successfully timestamped by the hardware.
> + * @lost: Number of hardware timestamping requests where the timestamping
> + * information from the hardware never arrived for submission with
> + * the skb.
> + * @err: Number of arbitrary timestamp generation error events that the
> + * hardware encountered, exclusive of @lost statistics. Cases such
> + * as resource exhaustion, unavailability, firmware errors, and
> + * detected illogical timestamp values not submitted with the skb
> + * are inclusive to this counter.
> + */
> +struct ethtool_ts_stats {
> + struct_group(tx_stats,
Doesn't seem like the group should be documented:
include/linux/ethtool.h:503: warning: Excess struct member 'tx_stats' description in 'ethtool_ts_stats'
--
pw-bot: cr
next prev parent reply other threads:[~2024-04-03 2:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 20:52 [PATCH net-next v1 0/6] ethtool HW timestamping statistics Rahul Rameshbabu
2024-04-02 20:52 ` [PATCH net-next v1 1/6] ethtool: add interface to read Tx hardware " Rahul Rameshbabu
2024-04-03 2:18 ` Jakub Kicinski [this message]
2024-04-03 5:14 ` Rahul Rameshbabu
2024-04-03 18:44 ` Keller, Jacob E
2024-04-03 20:56 ` Rahul Rameshbabu
2024-04-02 20:52 ` [PATCH net-next v1 2/6] net/mlx5e: Introduce lost_cqe statistic counter for PTP Tx port timestamping CQ Rahul Rameshbabu
2024-04-02 20:52 ` [PATCH net-next v1 3/6] net/mlx5e: Introduce timestamps statistic counter for Tx DMA layer Rahul Rameshbabu
2024-04-02 20:52 ` [PATCH net-next v1 4/6] net/mlx5e: Implement ethtool hardware timestamping statistics Rahul Rameshbabu
2024-04-02 20:52 ` [PATCH net-next v1 5/6] netlink: specs: ethtool: add header-flags enumeration Rahul Rameshbabu
2024-04-02 20:52 ` [PATCH net-next v1 6/6] tools: ynl: ethtool.py: Output timestamping statistics from tsinfo-get operation Rahul Rameshbabu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402191842.66decfd3@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=hkallweit1@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=joabreu@synopsys.com \
--cc=justinstitt@google.com \
--cc=kory.maincent@bootlin.com \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.greenwalt@intel.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
--cc=rrameshbabu@nvidia.com \
--cc=saeed@kernel.org \
--cc=tariqt@nvidia.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vladimir.oltean@nxp.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.