All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Marek Pazdan <mpazdan@arista.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	Ferruh Yigit <ferruh.yigit@amd.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	dev@dpdk.org
Subject: Re: [PATCH] lib: add get/set link settings interface
Date: Wed, 3 Apr 2024 10:23:02 -0700	[thread overview]
Message-ID: <20240403102302.6b700690@hermes.local> (raw)
In-Reply-To: <CAJUFdiGAnnmtXc1GhUe=CAQya5BYFhcLFiUx1WVs86-msdKvgw@mail.gmail.com>

On Wed, 3 Apr 2024 16:59:08 +0200
Marek Pazdan <mpazdan@arista.com> wrote:

> Hi Thomas,
> 
> Information like advertising: speed, pause, autonegotiation etc. and that
> same for link partner advertising.
> I try to mimic ethtool since it's a common, well known and widely used tool
> so adding an API which provides the same set of information in case the
> interface is passthrough to dpdk will be useful I think.
> I've 2 more patches dependent on the one we are discussing now, but I need
> patchwork id to add dependency information. I need moderator approval for
> the current patch.
> 
> Regards,
> Marek

DPDK already had this info under rte_eth_conf and it is supported
on all drivers. Why introduce yet another API and only for some drivers?

  parent reply	other threads:[~2024-04-03 17:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26 23:59 [PATCH] igc/ixgbe: add get/set link settings interface Marek Pazdan
2024-03-27 11:12 ` Bruce Richardson
2024-04-03 13:40 ` [PATCH] lib: " Marek Pazdan
2024-04-03 16:49   ` Tyler Retzlaff
2024-04-04  7:09     ` David Marchand
2024-04-05  0:55       ` Tyler Retzlaff
2024-04-05  0:56         ` Tyler Retzlaff
2024-04-05  8:58         ` David Marchand
2024-04-05 13:05           ` Dodji Seketeli
2024-04-03 13:59 ` Marek Pazdan
2024-04-03 14:48   ` Thomas Monjalon
2024-04-03 14:59     ` Marek Pazdan
2024-04-03 16:13       ` Thomas Monjalon
2024-04-03 17:23       ` Stephen Hemminger [this message]
2024-04-03 22:08         ` Marek Pazdan
2024-04-03 23:38           ` Stephen Hemminger
2024-07-22 14:55             ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240403102302.6b700690@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=mpazdan@arista.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.