From: Stephen Hemminger <stephen@networkplumber.org>
To: Marek Pazdan <mpazdan@arista.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
dev@dpdk.org
Subject: Re: [PATCH] lib: add get/set link settings interface
Date: Wed, 3 Apr 2024 16:38:46 -0700 [thread overview]
Message-ID: <20240403163846.7ed3ff4a@hermes.local> (raw)
In-Reply-To: <CAJUFdiGUTcyehcW-pwc3yYZ8Mb2+zQUVWC=Bbg+gZJRv1a3S9Q@mail.gmail.com>
On Thu, 4 Apr 2024 00:08:41 +0200
Marek Pazdan <mpazdan@arista.com> wrote:
> I can remove this part (rte_eth_config), but the new API provides other
> link information which is not available from the existing API, like
> supported/advertising/partner_advertising link modes.
> Additionally from what I see, rte_eth_confg is available from
> rte_eth_dev_conf_get API and it's copy of requested configuration:
> `memcpy(dev_conf, &dev->data->dev_conf, sizeof(struct rte_eth_conf));`
Then the new info should go in the rte_eth_config in a future version
of DPDK. Having bits in different places makes the API confusing.
next prev parent reply other threads:[~2024-04-03 23:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 23:59 [PATCH] igc/ixgbe: add get/set link settings interface Marek Pazdan
2024-03-27 11:12 ` Bruce Richardson
2024-04-03 13:40 ` [PATCH] lib: " Marek Pazdan
2024-04-03 16:49 ` Tyler Retzlaff
2024-04-04 7:09 ` David Marchand
2024-04-05 0:55 ` Tyler Retzlaff
2024-04-05 0:56 ` Tyler Retzlaff
2024-04-05 8:58 ` David Marchand
2024-04-05 13:05 ` Dodji Seketeli
2024-04-03 13:59 ` Marek Pazdan
2024-04-03 14:48 ` Thomas Monjalon
2024-04-03 14:59 ` Marek Pazdan
2024-04-03 16:13 ` Thomas Monjalon
2024-04-03 17:23 ` Stephen Hemminger
2024-04-03 22:08 ` Marek Pazdan
2024-04-03 23:38 ` Stephen Hemminger [this message]
2024-07-22 14:55 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240403163846.7ed3ff4a@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=mpazdan@arista.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.