All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernd Kuhls <bernd@kuhls.net>
To: buildroot@buildroot.org
Subject: [Buildroot] [PATCH 1/9] package/apg: add optional dependency to libxcrypt
Date: Wed,  3 Apr 2024 17:36:33 +0200	[thread overview]
Message-ID: <20240403153641.4122789-1-bernd@kuhls.net> (raw)

When glibc was bumped to version 2.39 in commit
b5680f53d60acf8ff6010082f873438a39bd5d97 it removed the deprecated
libcrypt support.

As glibc's libcrypt was providing apg's libcrypt dependency this broke
the apg build using glibc version 2.39.

To fix this select the libxcrypt dependency to apg when using a glibc
toolchain and add the dependency if selected.

Fixes:
http://autobuild.buildroot.net/results/3df84ae300bb648492cffc21e4481fc5abf02aeb/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/apg/Config.in | 1 +
 package/apg/apg.mk    | 4 ++++
 2 files changed, 5 insertions(+)

diff --git a/package/apg/Config.in b/package/apg/Config.in
index 94c286a178..f54ffdba39 100644
--- a/package/apg/Config.in
+++ b/package/apg/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_APG
 	bool "apg"
+	select BR2_PACKAGE_LIBXCRYPT if BR2_TOOLCHAIN_USES_GLIBC
 	help
 	  Automated Password Generator (APG).
 
diff --git a/package/apg/apg.mk b/package/apg/apg.mk
index 16661f4b8d..1929e21f58 100644
--- a/package/apg/apg.mk
+++ b/package/apg/apg.mk
@@ -9,6 +9,10 @@ APG_SITE = $(call github,wilx,apg,v$(APG_VERSION))
 APG_LICENSE = BSD-3-Clause
 APG_LICENSE_FILES = COPYING
 
+ifeq ($(BR2_PACKAGE_LIBXCRYPT),y)
+APG_DEPENDENCIES += libxcrypt
+endif
+
 define APG_BUILD_CMDS
 	$(MAKE) $(TARGET_CONFIGURE_OPTS) FLAGS="$(TARGET_CFLAGS)" -C $(@D)
 endef
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

             reply	other threads:[~2024-04-03 15:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-03 15:36 Bernd Kuhls [this message]
2024-04-03 15:36 ` [Buildroot] [PATCH 2/9] package/apr: add optional dependency to libxcrypt Bernd Kuhls
2024-04-03 15:36 ` [Buildroot] [PATCH 3/9] package/dovecot: " Bernd Kuhls
2024-04-03 15:36 ` [Buildroot] [PATCH 4/9] package/freeswitch: " Bernd Kuhls
2024-04-03 15:36 ` [Buildroot] [PATCH 5/9] package/leafnode2: " Bernd Kuhls
2024-04-03 15:36 ` [Buildroot] [PATCH 6/9] package/lighttpd: " Bernd Kuhls
2024-04-03 15:36 ` [Buildroot] [PATCH 7/9] package/pure-ftpd: " Bernd Kuhls
2024-04-03 15:36 ` [Buildroot] [PATCH 8/9] package/squid: " Bernd Kuhls
2024-04-03 15:36 ` [Buildroot] [PATCH 9/9] package/sysvinit: " Bernd Kuhls
2024-04-03 19:56 ` [Buildroot] [PATCH 1/9] package/apg: " Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240403153641.4122789-1-bernd@kuhls.net \
    --to=bernd@kuhls.net \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.