All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernd Kuhls <bernd@kuhls.net>
To: buildroot@buildroot.org
Subject: [Buildroot] [PATCH 9/9] package/sysvinit: add optional dependency to libxcrypt
Date: Wed,  3 Apr 2024 17:36:41 +0200	[thread overview]
Message-ID: <20240403153641.4122789-9-bernd@kuhls.net> (raw)
In-Reply-To: <20240403153641.4122789-1-bernd@kuhls.net>

When glibc was bumped to version 2.39 in commit
b5680f53d60acf8ff6010082f873438a39bd5d97 it removed the deprecated
libcrypt support.

As glibc's libcrypt was providing sysvinit's libcrypt dependency this
broke the sysvinit build using glibc version 2.39.

To fix this select the libxcrypt dependency to sysvinit when using a
glibc toolchain and add the dependency if selected.

Fixes:
http://autobuild.buildroot.net/results/3a9/3a99389bd7b6db7f9467b34c7bead1d58ce5a18d/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/sysvinit/Config.in   | 1 +
 package/sysvinit/sysvinit.mk | 4 ++++
 2 files changed, 5 insertions(+)

diff --git a/package/sysvinit/Config.in b/package/sysvinit/Config.in
index 7f27a70fcc..e5ca1d7f2d 100644
--- a/package/sysvinit/Config.in
+++ b/package/sysvinit/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_SYSVINIT
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_INIT_SYSV
 	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
+	select BR2_PACKAGE_LIBXCRYPT if BR2_TOOLCHAIN_USES_GLIBC
 	help
 	  System V style implementation of /sbin/init, parent of all
 	  processes
diff --git a/package/sysvinit/sysvinit.mk b/package/sysvinit/sysvinit.mk
index 49c92ec2ac..7f37cea131 100644
--- a/package/sysvinit/sysvinit.mk
+++ b/package/sysvinit/sysvinit.mk
@@ -18,6 +18,10 @@ SYSVINIT_DEPENDENCIES += libselinux
 SYSVINIT_MAKE_OPTS += WITH_SELINUX="yes"
 endif
 
+ifeq ($(BR2_PACKAGE_LIBXCRYPT),y)
+SYSVINIT_DEPENDENCIES += libxcrypt
+endif
+
 define SYSVINIT_BUILD_CMDS
 	$(TARGET_CONFIGURE_OPTS) $(MAKE) $(SYSVINIT_MAKE_OPTS) -C $(@D)/src
 endef
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2024-04-03 15:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-03 15:36 [Buildroot] [PATCH 1/9] package/apg: add optional dependency to libxcrypt Bernd Kuhls
2024-04-03 15:36 ` [Buildroot] [PATCH 2/9] package/apr: " Bernd Kuhls
2024-04-03 15:36 ` [Buildroot] [PATCH 3/9] package/dovecot: " Bernd Kuhls
2024-04-03 15:36 ` [Buildroot] [PATCH 4/9] package/freeswitch: " Bernd Kuhls
2024-04-03 15:36 ` [Buildroot] [PATCH 5/9] package/leafnode2: " Bernd Kuhls
2024-04-03 15:36 ` [Buildroot] [PATCH 6/9] package/lighttpd: " Bernd Kuhls
2024-04-03 15:36 ` [Buildroot] [PATCH 7/9] package/pure-ftpd: " Bernd Kuhls
2024-04-03 15:36 ` [Buildroot] [PATCH 8/9] package/squid: " Bernd Kuhls
2024-04-03 15:36 ` Bernd Kuhls [this message]
2024-04-03 19:56 ` [Buildroot] [PATCH 1/9] package/apg: " Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240403153641.4122789-9-bernd@kuhls.net \
    --to=bernd@kuhls.net \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.